diff mbox

[U-Boot,08/10] x86: Correct a few progress message nits

Message ID 1412950921-20052-9-git-send-email-sjg@chromium.org
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass Oct. 10, 2014, 2:21 p.m. UTC 
We should use puts() instead of printf() where possible. Also clarify
the setup.bin message.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 arch/x86/lib/bootm.c  | 2 +-
 arch/x86/lib/zimage.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Simon Glass Nov. 8, 2014, 7:24 p.m. UTC | #1 
On 10 October 2014 08:21, Simon Glass <sjg@chromium.org> wrote:
> We should use puts() instead of printf() where possible. Also clarify
> the setup.bin message.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  arch/x86/lib/bootm.c  | 2 +-
>  arch/x86/lib/zimage.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

Applied to u-boot-x86 and now in mainline.
diff mbox

Patch

diff --git a/arch/x86/lib/bootm.c b/arch/x86/lib/bootm.c
index 46a1d96..86030cf 100644
--- a/arch/x86/lib/bootm.c
+++ b/arch/x86/lib/bootm.c
@@ -121,7 +121,7 @@  static int boot_prep_linux(bootm_headers_t *images)
 	} else if (images->ep) {
 		cmd_line_dest = (void *)images->ep + COMMAND_LINE_OFFSET;
 	} else {
-		printf("## Kernel loading failed (no setup) ...\n");
+		printf("## Kernel loading failed (missing x86 kernel setup) ...\n");
 		goto error;
 	}
 
diff --git a/arch/x86/lib/zimage.c b/arch/x86/lib/zimage.c
index aa5597c..566b048 100644
--- a/arch/x86/lib/zimage.c
+++ b/arch/x86/lib/zimage.c
@@ -307,12 +307,12 @@  int do_zboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 	base_ptr = load_zimage(bzImage_addr, bzImage_size, &load_address);
 
 	if (!base_ptr) {
-		printf("## Kernel loading failed ...\n");
+		puts("## Kernel loading failed ...\n");
 		return -1;
 	}
 	if (setup_zimage(base_ptr, (char *)base_ptr + COMMAND_LINE_OFFSET,
 			0, initrd_addr, initrd_size)) {
-		printf("Setting up boot parameters failed ...\n");
+		puts("Setting up boot parameters failed ...\n");
 		return -1;
 	}