| Message ID | 1412073677-9776-1-git-send-email-sr@denx.de |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Stefano Babic |
| Headers | show |
On Tue, Sep 30, 2014 at 3:41 AM, Stefan Roese <sr@denx.de> wrote: > Zeroing GD in board_init_f() is not needed any more. As its now done in > crt0.S. The patch that clears the GD in crt0.S is this one: > > aae2aef9 [arm: Set up global data before board_init_f()] from Simon. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Tim Harvey <tharvey@gateworks.com> > Cc: Stefano Babic <sbabic@denx.de> > --- > board/gateworks/gw_ventana/gw_ventana_spl.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/board/gateworks/gw_ventana/gw_ventana_spl.c b/board/gateworks/gw_ventana/gw_ventana_spl.c > index 9fc253b..ca35b3c 100644 > --- a/board/gateworks/gw_ventana/gw_ventana_spl.c > +++ b/board/gateworks/gw_ventana/gw_ventana_spl.c > @@ -402,13 +402,6 @@ void board_init_f(ulong dummy) > struct ventana_board_info ventana_info; > int board_model; > > - /* > - * Zero out global data: > - * - this shoudl be done by crt0.S > - * - failure to zero it will cause i2c_setup to fail > - */ > - memset((void *)gd, 0, sizeof(struct global_data)); > - > /* setup AIPS and disable watchdog */ > arch_cpu_init(); > > -- > 2.1.0 > Acked-by: Tim Harvey <tharvey@gateworks.com> Tim
On 30/09/2014 12:41, Stefan Roese wrote: > Zeroing GD in board_init_f() is not needed any more. As its now done in > crt0.S. The patch that clears the GD in crt0.S is this one: > > aae2aef9 [arm: Set up global data before board_init_f()] from Simon. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Tim Harvey <tharvey@gateworks.com> > Cc: Stefano Babic <sbabic@denx.de> > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic
diff --git a/board/gateworks/gw_ventana/gw_ventana_spl.c b/board/gateworks/gw_ventana/gw_ventana_spl.c index 9fc253b..ca35b3c 100644 --- a/board/gateworks/gw_ventana/gw_ventana_spl.c +++ b/board/gateworks/gw_ventana/gw_ventana_spl.c @@ -402,13 +402,6 @@ void board_init_f(ulong dummy) struct ventana_board_info ventana_info; int board_model; - /* - * Zero out global data: - * - this shoudl be done by crt0.S - * - failure to zero it will cause i2c_setup to fail - */ - memset((void *)gd, 0, sizeof(struct global_data)); - /* setup AIPS and disable watchdog */ arch_cpu_init();
Zeroing GD in board_init_f() is not needed any more. As its now done in crt0.S. The patch that clears the GD in crt0.S is this one: aae2aef9 [arm: Set up global data before board_init_f()] from Simon. Signed-off-by: Stefan Roese <sr@denx.de> Cc: Tim Harvey <tharvey@gateworks.com> Cc: Stefano Babic <sbabic@denx.de> --- board/gateworks/gw_ventana/gw_ventana_spl.c | 7 ------- 1 file changed, 7 deletions(-)