diff mbox

[U-Boot,v2] buildman: refactor help message

Message ID 1408702361-12930-1-git-send-email-yamada.m@jp.panasonic.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Masahiro Yamada Aug. 22, 2014, 10:12 a.m. UTC
"buildman [options]" is displayed by default.

Append the rest of help messages to parser.usage
instead of replacing it.

Besides, "-b <branch>" is not mandatory since commit fea5858e.
Drop it from the usage.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

Changes in v2:
  - Drop "-b <branch>" from the usage

 tools/buildman/buildman.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass Aug. 23, 2014, 2:03 a.m. UTC | #1
On 22 August 2014 04:12, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> "buildman [options]" is displayed by default.
>
> Append the rest of help messages to parser.usage
> instead of replacing it.
>
> Besides, "-b <branch>" is not mandatory since commit fea5858e.
> Drop it from the usage.

Yes.

>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

Acked-by: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Tom Rini Aug. 23, 2014, 12:40 p.m. UTC | #2
On Fri, Aug 22, 2014 at 07:12:41PM +0900, Masahiro Yamada wrote:

> "buildman [options]" is displayed by default.
> 
> Append the rest of help messages to parser.usage
> instead of replacing it.
> 
> Besides, "-b <branch>" is not mandatory since commit fea5858e.
> Drop it from the usage.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/tools/buildman/buildman.py b/tools/buildman/buildman.py
index 6ca8dc6..e18859b 100755
--- a/tools/buildman/buildman.py
+++ b/tools/buildman/buildman.py
@@ -118,7 +118,7 @@  parser.add_option('-u', '--show_unknown', action='store_true',
 parser.add_option('-v', '--verbose', action='store_true',
        default=False, help='Show build results while the build progresses')
 
-parser.usage = """buildman -b <branch> [options]
+parser.usage += """
 
 Build U-Boot for all commits in a branch. Use -n to do a dry run"""