| Message ID | 1403252161-20526-3-git-send-email-voice.shen@atmel.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | Andreas Bießmann |
| Headers | show |
Hi Bo, > -/* No NOR flash */ > +/* NOR flash */ > +#define CONFIG_CMD_FLASH > + > +#ifdef CONFIG_CMD_FLASH > +#define CONFIG_SYS_FLASH_CFI > +#define CONFIG_FLASH_CFI_DRIVER > +#define CONFIG_SYS_FLASH_BASE 0x10000000 > +#define CONFIG_SYS_MAX_FLASH_SECT 0x20000 > +#define CONFIG_SYS_MAX_FLASH_BANKS 1 > +#else > #define CONFIG_SYS_NO_FLASH > +#endif The NOR flash device on the SAMA5D3x CPU modules supports hardware sector protection and according to the flash datasheet: "All blocks power-up in a locked state to protect array data from being altered during power transitions". In order to make your patch set work: #define CONFIG_SYS_FLASH_PROTECTION needs adding into the include/configs/sama5d3xek.h file. Andy.
Hi Andy, On 06/30/2014 05:55 PM, Andy Pont wrote: > Hi Bo, > >> -/* No NOR flash */ >> +/* NOR flash */ >> +#define CONFIG_CMD_FLASH >> + >> +#ifdef CONFIG_CMD_FLASH >> +#define CONFIG_SYS_FLASH_CFI >> +#define CONFIG_FLASH_CFI_DRIVER >> +#define CONFIG_SYS_FLASH_BASE 0x10000000 >> +#define CONFIG_SYS_MAX_FLASH_SECT 0x20000 >> +#define CONFIG_SYS_MAX_FLASH_BANKS 1 >> +#else >> #define CONFIG_SYS_NO_FLASH >> +#endif > > The NOR flash device on the SAMA5D3x CPU modules supports hardware sector > protection and according to the flash datasheet: "All blocks power-up in a > locked state to protect array data from being altered during power > transitions". In order to make your patch set work: > > #define CONFIG_SYS_FLASH_PROTECTION > > needs adding into the include/configs/sama5d3xek.h file. Thanks for your information. I will add it into next version. Thanks again. > Andy. > Best Regards, Bo Shen
Hi Bo, > >> +#ifdef CONFIG_CMD_FLASH > >> +#define CONFIG_SYS_FLASH_CFI > >> +#define CONFIG_FLASH_CFI_DRIVER > >> +#define CONFIG_SYS_FLASH_BASE 0x10000000 > >> +#define CONFIG_SYS_MAX_FLASH_SECT 0x20000 Is this the correct value for CONFIG_SYS_MAX_FLASH_SECT? Shouldn't it be 127 (if we ignore the top boot block) or 131 if they are included? Regards, Andy.
Hi Andy, On 06/30/2014 06:46 PM, Andy Pont wrote: > Hi Bo, > >>>> +#ifdef CONFIG_CMD_FLASH >>>> +#define CONFIG_SYS_FLASH_CFI >>>> +#define CONFIG_FLASH_CFI_DRIVER >>>> +#define CONFIG_SYS_FLASH_BASE 0x10000000 >>>> +#define CONFIG_SYS_MAX_FLASH_SECT 0x20000 > > Is this the correct value for CONFIG_SYS_MAX_FLASH_SECT? Shouldn't it be > 127 (if we ignore the top boot block) or 131 if they are included? oops, I fill this with the sector size. Thanks point it out. Here, I think we should fill with 131. > Regards, > > Andy. > Best Regards, Bo Shen
diff --git a/include/configs/sama5d3xek.h b/include/configs/sama5d3xek.h index da27180..63d6775 100644 --- a/include/configs/sama5d3xek.h +++ b/include/configs/sama5d3xek.h @@ -79,8 +79,18 @@ #define CONFIG_BOOTP_GATEWAY #define CONFIG_BOOTP_HOSTNAME -/* No NOR flash */ +/* NOR flash */ +#define CONFIG_CMD_FLASH + +#ifdef CONFIG_CMD_FLASH +#define CONFIG_SYS_FLASH_CFI +#define CONFIG_FLASH_CFI_DRIVER +#define CONFIG_SYS_FLASH_BASE 0x10000000 +#define CONFIG_SYS_MAX_FLASH_SECT 0x20000 +#define CONFIG_SYS_MAX_FLASH_BANKS 1 +#else #define CONFIG_SYS_NO_FLASH +#endif /* * Command line configuration.
Signed-off-by: Bo Shen <voice.shen@atmel.com> --- include/configs/sama5d3xek.h | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)