| Message ID | 1398806002-25067-1-git-send-email-eric.nelson@boundarydevices.com |
|---|---|
| State | Superseded |
| Delegated to: | Anatolij Gustschin |
| Headers | show |
Hello Eric, On Tue, Apr 29, 2014 at 6:13 PM, Eric Nelson <eric.nelson@boundarydevices.com> wrote: > This patch updates the i.MX video driver to store the > frame-buffer address in the fb_base field of the global > data structure *gd. > > By doing this, you can find the frame buffer address > using the 'bdinfo' command: > > U-Boot > bdinfo > arch_number = 0x00000EB9 > ... > FB base = 0x4F35F1C0 > > This is very useful when debugging display connections. > > Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com> > --- > drivers/video/mxc_ipuv3_fb.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/mxc_ipuv3_fb.c b/drivers/video/mxc_ipuv3_fb.c > index 3e21fb2..08a94c2 100644 > --- a/drivers/video/mxc_ipuv3_fb.c > +++ b/drivers/video/mxc_ipuv3_fb.c > @@ -10,9 +10,9 @@ > * > * SPDX-License-Identifier: GPL-2.0+ > */ > - Don't remove lines. > #include <common.h> > #include <asm/errno.h> > +#include <asm/global_data.h> > #include <linux/string.h> > #include <linux/list.h> > #include <linux/fb.h> > @@ -24,6 +24,8 @@ > #include "mxcfb.h" > #include "ipu_regs.h" > > +DECLARE_GLOBAL_DATA_PTR; > + > static int mxcfb_map_video_memory(struct fb_info *fbi); > static int mxcfb_unmap_video_memory(struct fb_info *fbi); > > @@ -415,6 +417,7 @@ static int mxcfb_map_video_memory(struct fb_info *fbi) > > fbi->screen_size = fbi->fix.smem_len; > > + gd->fb_base = fbi->fix.smem_start; I would add a new line after this. It looks ugly too close of the comment and memset. > /* Clear the screen */ > memset((char *)fbi->screen_base, 0, fbi->fix.smem_len); Apart from that, please add my Acked-by.
Hi Otavio, On 04/29/2014 02:26 PM, Otavio Salvador wrote: > Hello Eric, > > On Tue, Apr 29, 2014 at 6:13 PM, Eric Nelson > <eric.nelson@boundarydevices.com> wrote: >> This patch updates the i.MX video driver to store the >> frame-buffer address in the fb_base field of the global >> data structure *gd. >> >> By doing this, you can find the frame buffer address >> using the 'bdinfo' command: >> >> U-Boot > bdinfo >> arch_number = 0x00000EB9 >> ... >> FB base = 0x4F35F1C0 >> >> This is very useful when debugging display connections. >> >> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com> >> --- >> drivers/video/mxc_ipuv3_fb.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/video/mxc_ipuv3_fb.c b/drivers/video/mxc_ipuv3_fb.c >> index 3e21fb2..08a94c2 100644 >> --- a/drivers/video/mxc_ipuv3_fb.c >> +++ b/drivers/video/mxc_ipuv3_fb.c >> @@ -10,9 +10,9 @@ >> * >> * SPDX-License-Identifier: GPL-2.0+ >> */ >> - > > Don't remove lines. > Oops. That's where my "#define DEBUG" lived... >> #include <common.h> >> #include <asm/errno.h> >> +#include <asm/global_data.h> >> #include <linux/string.h> >> #include <linux/list.h> >> #include <linux/fb.h> >> @@ -24,6 +24,8 @@ >> #include "mxcfb.h" >> #include "ipu_regs.h" >> >> +DECLARE_GLOBAL_DATA_PTR; >> + >> static int mxcfb_map_video_memory(struct fb_info *fbi); >> static int mxcfb_unmap_video_memory(struct fb_info *fbi); >> >> @@ -415,6 +417,7 @@ static int mxcfb_map_video_memory(struct fb_info *fbi) >> >> fbi->screen_size = fbi->fix.smem_len; >> >> + gd->fb_base = fbi->fix.smem_start; > > I would add a new line after this. It looks ugly too close of the > comment and memset. > This is the part that keeps me from thinking I can ever get a patch V1 right... >> /* Clear the screen */ >> memset((char *)fbi->screen_base, 0, fbi->fix.smem_len); > > Apart from that, please add my Acked-by. > Will do in V2. Regards, Eric
On Tuesday, April 29, 2014 at 11:26:41 PM, Otavio Salvador wrote: [...] > > /* Clear the screen */ > > memset((char *)fbi->screen_base, 0, fbi->fix.smem_len); > > Apart from that, please add my Acked-by. Please add proper tags, otherwise patchwork cannot pick this automatically and you are only adding work onto others' shoulders . Best regards, Marek Vasut
diff --git a/drivers/video/mxc_ipuv3_fb.c b/drivers/video/mxc_ipuv3_fb.c index 3e21fb2..08a94c2 100644 --- a/drivers/video/mxc_ipuv3_fb.c +++ b/drivers/video/mxc_ipuv3_fb.c @@ -10,9 +10,9 @@ * * SPDX-License-Identifier: GPL-2.0+ */ - #include <common.h> #include <asm/errno.h> +#include <asm/global_data.h> #include <linux/string.h> #include <linux/list.h> #include <linux/fb.h> @@ -24,6 +24,8 @@ #include "mxcfb.h" #include "ipu_regs.h" +DECLARE_GLOBAL_DATA_PTR; + static int mxcfb_map_video_memory(struct fb_info *fbi); static int mxcfb_unmap_video_memory(struct fb_info *fbi); @@ -415,6 +417,7 @@ static int mxcfb_map_video_memory(struct fb_info *fbi) fbi->screen_size = fbi->fix.smem_len; + gd->fb_base = fbi->fix.smem_start; /* Clear the screen */ memset((char *)fbi->screen_base, 0, fbi->fix.smem_len);
This patch updates the i.MX video driver to store the frame-buffer address in the fb_base field of the global data structure *gd. By doing this, you can find the frame buffer address using the 'bdinfo' command: U-Boot > bdinfo arch_number = 0x00000EB9 ... FB base = 0x4F35F1C0 This is very useful when debugging display connections. Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com> --- drivers/video/mxc_ipuv3_fb.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)