| Message ID | 1396481069-24950-11-git-send-email-sjg@chromium.org |
|---|---|
| State | Changes Requested |
| Delegated to: | Minkyu Kang |
| Headers | show |
On 03/04/14 08:24, Simon Glass wrote: > Enable LCD for snow. This is a 1366 x 768 panel. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > Changes in v2: > - Add a device tree node for the snow EDP bridge chip > > arch/arm/dts/exynos5250-snow.dts | 57 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > > diff --git a/arch/arm/dts/exynos5250-snow.dts b/arch/arm/dts/exynos5250-snow.dts > index 42a687b..2a6bc78 100644 > --- a/arch/arm/dts/exynos5250-snow.dts > +++ b/arch/arm/dts/exynos5250-snow.dts > @@ -88,6 +88,19 @@ > reg = <0x22>; > compatible = "maxim,max98095-codec"; > }; > + > + ptn3460-bridge@20 { > + compatible = "nxp,ptn3460"; > + reg = <0x20>; > + /* > + * TODO(sjg@chromium.org): Exynos GPIOs broken > + * powerdown-gpio = <&gpy2 5 0>; > + * reset-gpio = <&gpx1 5 0>; > + * edid-emulation = <5>; > + * pinctrl-names = "default"; > + * pinctrl-0 = <&ptn3460_gpios>; > + */ Now you can use GPIOs. Thanks, Minkyu Kang.
Hi Minkyu, On 15 May 2014 00:51, Minkyu Kang <mk7.kang@samsung.com> wrote: > On 03/04/14 08:24, Simon Glass wrote: >> Enable LCD for snow. This is a 1366 x 768 panel. >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> --- >> >> Changes in v2: >> - Add a device tree node for the snow EDP bridge chip >> >> arch/arm/dts/exynos5250-snow.dts | 57 ++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 57 insertions(+) >> >> diff --git a/arch/arm/dts/exynos5250-snow.dts b/arch/arm/dts/exynos5250-snow.dts >> index 42a687b..2a6bc78 100644 >> --- a/arch/arm/dts/exynos5250-snow.dts >> +++ b/arch/arm/dts/exynos5250-snow.dts >> @@ -88,6 +88,19 @@ >> reg = <0x22>; >> compatible = "maxim,max98095-codec"; >> }; >> + >> + ptn3460-bridge@20 { >> + compatible = "nxp,ptn3460"; >> + reg = <0x20>; >> + /* >> + * TODO(sjg@chromium.org): Exynos GPIOs broken >> + * powerdown-gpio = <&gpy2 5 0>; >> + * reset-gpio = <&gpx1 5 0>; >> + * edid-emulation = <5>; >> + * pinctrl-names = "default"; >> + * pinctrl-0 = <&ptn3460_gpios>; >> + */ > > Now you can use GPIOs. Yes it is a big help. However, I would like to make this change in a follow-on series. It involves changing the code to stop hard-coding the GPIOs. But there are many GPIOs involved, not just this bridge chip, and not just the LCD. So I think we need a separate series after this one to move the GPIOs to the device tree. Regards, Simon
diff --git a/arch/arm/dts/exynos5250-snow.dts b/arch/arm/dts/exynos5250-snow.dts index 42a687b..2a6bc78 100644 --- a/arch/arm/dts/exynos5250-snow.dts +++ b/arch/arm/dts/exynos5250-snow.dts @@ -88,6 +88,19 @@ reg = <0x22>; compatible = "maxim,max98095-codec"; }; + + ptn3460-bridge@20 { + compatible = "nxp,ptn3460"; + reg = <0x20>; + /* + * TODO(sjg@chromium.org): Exynos GPIOs broken + * powerdown-gpio = <&gpy2 5 0>; + * reset-gpio = <&gpx1 5 0>; + * edid-emulation = <5>; + * pinctrl-names = "default"; + * pinctrl-0 = <&ptn3460_gpios>; + */ + }; }; i2c@12c60000 { @@ -192,4 +205,48 @@ /* UP LEFT */ 0x070b0067 0x070c0069>; }; + + fimd@14400000 { + samsung,vl-freq = <60>; + samsung,vl-col = <1366>; + samsung,vl-row = <768>; + samsung,vl-width = <1366>; + samsung,vl-height = <768>; + + samsung,vl-clkp; + samsung,vl-dp; + samsung,vl-hsp; + samsung,vl-vsp; + + samsung,vl-bpix = <4>; + + samsung,vl-hspw = <32>; + samsung,vl-hbpd = <80>; + samsung,vl-hfpd = <48>; + samsung,vl-vspw = <5>; + samsung,vl-vbpd = <14>; + samsung,vl-vfpd = <3>; + samsung,vl-cmd-allow-len = <0xf>; + + samsung,winid = <0>; + samsung,interface-mode = <1>; + samsung,dp-enabled = <1>; + samsung,dual-lcd-enabled = <0>; + }; + + dp@145b0000 { + samsung,lt-status = <0>; + + samsung,master-mode = <0>; + samsung,bist-mode = <0>; + samsung,bist-pattern = <0>; + samsung,h-sync-polarity = <0>; + samsung,v-sync-polarity = <0>; + samsung,interlaced = <0>; + samsung,color-space = <0>; + samsung,dynamic-range = <0>; + samsung,ycbcr-coeff = <0>; + samsung,color-depth = <1>; + }; + };
Enable LCD for snow. This is a 1366 x 768 panel. Signed-off-by: Simon Glass <sjg@chromium.org> --- Changes in v2: - Add a device tree node for the snow EDP bridge chip arch/arm/dts/exynos5250-snow.dts | 57 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+)