| Message ID | 1396481069-24950-10-git-send-email-sjg@chromium.org |
|---|---|
| State | Changes Requested |
| Delegated to: | Minkyu Kang |
| Headers | show |
On 03/04/14 08:24, Simon Glass wrote: > At present the GPIO numbering patch has not been applied, so exynos GPIO > numbering is inconsistent (there are large gaps). Disable interrupts to > avoid a crash on boot. now, gpio patch is merged to u-boot-samsung. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > Changes in v2: None > > arch/arm/dts/exynos5250-snow.dts | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > Thanks, Minkyu Kang.
Hi Minkyu, On 15 May 2014 00:51, Minkyu Kang <mk7.kang@samsung.com> wrote: > On 03/04/14 08:24, Simon Glass wrote: >> At present the GPIO numbering patch has not been applied, so exynos GPIO >> numbering is inconsistent (there are large gaps). Disable interrupts to >> avoid a crash on boot. > > now, gpio patch is merged to u-boot-samsung. I don't see it in mainline yet, and there are conflicts. But I'll see if I can send a new series. > >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> --- >> >> Changes in v2: None >> >> arch/arm/dts/exynos5250-snow.dts | 12 ++++++++++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> > > Thanks, > Minkyu Kang. > Regards, Simon
On 20/05/14 06:27, Simon Glass wrote: > Hi Minkyu, > > On 15 May 2014 00:51, Minkyu Kang <mk7.kang@samsung.com> wrote: >> On 03/04/14 08:24, Simon Glass wrote: >>> At present the GPIO numbering patch has not been applied, so exynos GPIO >>> numbering is inconsistent (there are large gaps). Disable interrupts to >>> avoid a crash on boot. >> >> now, gpio patch is merged to u-boot-samsung. > > I don't see it in mainline yet, and there are conflicts. But I'll see > if I can send a new series. > please find this commit (f6ae1ca05839f92b103aaa0743d1d0012ba9773d) >> >>> >>> Signed-off-by: Simon Glass <sjg@chromium.org> >>> --- >>> >>> Changes in v2: None >>> >>> arch/arm/dts/exynos5250-snow.dts | 12 ++++++++++-- >>> 1 file changed, 10 insertions(+), 2 deletions(-) >>> >> >> Thanks, >> Minkyu Kang. >> > > Regards, > Simon > Thanks, Minkyu Kang.
Hi Minkyu, On 19 May 2014 18:53, Minkyu Kang <mk7.kang@samsung.com> wrote: > On 20/05/14 06:27, Simon Glass wrote: >> Hi Minkyu, >> >> On 15 May 2014 00:51, Minkyu Kang <mk7.kang@samsung.com> wrote: >>> On 03/04/14 08:24, Simon Glass wrote: >>>> At present the GPIO numbering patch has not been applied, so exynos GPIO >>>> numbering is inconsistent (there are large gaps). Disable interrupts to >>>> avoid a crash on boot. >>> >>> now, gpio patch is merged to u-boot-samsung. >> >> I don't see it in mainline yet, and there are conflicts. But I'll see >> if I can send a new series. >> > > please find this commit (f6ae1ca05839f92b103aaa0743d1d0012ba9773d) OK thanks, I think I have something that can be applied. I can correct the GPIO numbers now, so will replace this patch. Regards, Simon
diff --git a/arch/arm/dts/exynos5250-snow.dts b/arch/arm/dts/exynos5250-snow.dts index 9b48a0c..42a687b 100644 --- a/arch/arm/dts/exynos5250-snow.dts +++ b/arch/arm/dts/exynos5250-snow.dts @@ -44,7 +44,11 @@ reg = <0x1e>; compatible = "google,cros-ec"; i2c-max-frequency = <100000>; - ec-interrupt = <&gpio 782 1>; + /* + * GPIO numbering is broken on exynos at present + * + * ec-interrupt = <&gpio 782 1>; + */ }; power-regulator@48 { @@ -60,7 +64,11 @@ reg = <0>; compatible = "google,cros-ec"; spi-max-frequency = <5000000>; - ec-interrupt = <&gpio 782 1>; + /* + * GPIO numbering is broken on exynos at present + * + * ec-interrupt = <&gpio 782 1>; + */ optimise-flash-write; status = "disabled"; };
At present the GPIO numbering patch has not been applied, so exynos GPIO numbering is inconsistent (there are large gaps). Disable interrupts to avoid a crash on boot. Signed-off-by: Simon Glass <sjg@chromium.org> --- Changes in v2: None arch/arm/dts/exynos5250-snow.dts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)