diff mbox

[U-Boot] mmc: set rca to 1 for MMC cards

Message ID 1391123472-11099-1-git-send-email-swarren@wwwdotorg.org
State Accepted
Delegated to: Pantelis Antoniou
Headers show

Commit Message

Stephen Warren Jan. 30, 2014, 11:11 p.m. UTC 
From: Stephen Warren <swarren@nvidia.com>

U-Boot currently sets MMC cards' RCA register to 0. This value is
reserved according to the specification. Use a value of 1 instead, just
like the Linux kernel.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 drivers/mmc/mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jaehoon Chung Feb. 4, 2014, 1:04 a.m. UTC | #1 
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

On 01/31/2014 08:11 AM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> U-Boot currently sets MMC cards' RCA register to 0. This value is
> reserved according to the specification. Use a value of 1 instead, just
> like the Linux kernel.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  drivers/mmc/mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index c6a1c23fbf1c..7efc2bedbe11 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -430,7 +430,7 @@ int mmc_complete_op_cond(struct mmc *mmc)
>  	mmc->ocr = cmd.response[0];
>  
>  	mmc->high_capacity = ((mmc->ocr & OCR_HCS) == OCR_HCS);
> -	mmc->rca = 0;
> +	mmc->rca = 1;
>  
>  	return 0;
>  }
>
Pantelis Antoniou Feb. 7, 2014, 3:32 p.m. UTC | #2 
Looks good.

On Jan 31, 2014, at 1:11 AM, Stephen Warren wrote:

> From: Stephen Warren <swarren@nvidia.com>
> 
> U-Boot currently sets MMC cards' RCA register to 0. This value is
> reserved according to the specification. Use a value of 1 instead, just
> like the Linux kernel.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> drivers/mmc/mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index c6a1c23fbf1c..7efc2bedbe11 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -430,7 +430,7 @@ int mmc_complete_op_cond(struct mmc *mmc)
> 	mmc->ocr = cmd.response[0];
> 
> 	mmc->high_capacity = ((mmc->ocr & OCR_HCS) == OCR_HCS);
> -	mmc->rca = 0;
> +	mmc->rca = 1;
> 
> 	return 0;
> }
> -- 
> 1.8.1.5
> 

Applied, Thanks.

Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
diff mbox

Patch

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index c6a1c23fbf1c..7efc2bedbe11 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -430,7 +430,7 @@  int mmc_complete_op_cond(struct mmc *mmc)
 	mmc->ocr = cmd.response[0];
 
 	mmc->high_capacity = ((mmc->ocr & OCR_HCS) == OCR_HCS);
-	mmc->rca = 0;
+	mmc->rca = 1;
 
 	return 0;
 }