| Message ID | 1391009943-8028-3-git-send-email-lothar.felten@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
On Wed, Jan 29, 2014 at 04:39:03PM +0100, Lothar Felten wrote: > Signed-off-by: Lothar Felten <lothar.felten@gmail.com> > --- > board/silica/pengwyn/board.c | 10 +++++----- > include/configs/pengwyn.h | 6 ++---- > 2 files changed, 7 insertions(+), 9 deletions(-) > > diff --git a/board/silica/pengwyn/board.c b/board/silica/pengwyn/board.c > index d5dbd3b..97d7de4 100644 > --- a/board/silica/pengwyn/board.c > +++ b/board/silica/pengwyn/board.c > @@ -77,11 +77,11 @@ const struct dpll_params dpll_ddr_400 = { > > void am33xx_spl_board_init(void) > { > - /* the pengwyn board uses the TPS650250 PMIC without I2C */ > - /* interface and will output the following fixed voltages: */ > - /* DCDC1=3V3 (IO) DCDC2=1V5 (DDR) DCDC3=1V26 (Vmpu) */ > - /* VLDO1=1V8 (IO) VLDO2=1V8(IO) */ > - /* Vcore=1V1 is fixed, generated by TPS62231 */ > + /* The pengwyn board uses the TPS650250 PMIC without I2C > + * interface and will output the following fixed voltages: > + * DCDC1=3V3 (IO) DCDC2=1V5 (DDR) DCDC3=1V26 (Vmpu) > + * VLDO1=1V8 (IO) VLDO2=1V8(IO) > + * Vcore=1V1 is fixed, generated by TPS62231 */ Not quite right, and please squash this patch into the first one, in the next posting. Thanks.
Dear Lothar Felten, In message <1391009943-8028-3-git-send-email-lothar.felten@gmail.com> you wrote: > Signed-off-by: Lothar Felten <lothar.felten@gmail.com> > --- > board/silica/pengwyn/board.c | 10 +++++----- > include/configs/pengwyn.h | 6 ++---- > 2 files changed, 7 insertions(+), 9 deletions(-) > > diff --git a/board/silica/pengwyn/board.c b/board/silica/pengwyn/board.c > index d5dbd3b..97d7de4 100644 > --- a/board/silica/pengwyn/board.c > +++ b/board/silica/pengwyn/board.c > @@ -77,11 +77,11 @@ const struct dpll_params dpll_ddr_400 = { > > void am33xx_spl_board_init(void) > { > - /* the pengwyn board uses the TPS650250 PMIC without I2C */ > - /* interface and will output the following fixed voltages: */ > - /* DCDC1=3V3 (IO) DCDC2=1V5 (DDR) DCDC3=1V26 (Vmpu) */ > - /* VLDO1=1V8 (IO) VLDO2=1V8(IO) */ > - /* Vcore=1V1 is fixed, generated by TPS62231 */ > + /* The pengwyn board uses the TPS650250 PMIC without I2C > + * interface and will output the following fixed voltages: > + * DCDC1=3V3 (IO) DCDC2=1V5 (DDR) DCDC3=1V26 (Vmpu) > + * VLDO1=1V8 (IO) VLDO2=1V8(IO) > + * Vcore=1V1 is fixed, generated by TPS62231 */ This is still wrong. Please see the example I gave in my previous message, and/or read the Linux CodingStyle document. Also, it does not make sense to first knowingly add bad code and then fix it in a later patch of the same seirs - please squash your patches. Best regards, Wolfgang Denk
diff --git a/board/silica/pengwyn/board.c b/board/silica/pengwyn/board.c index d5dbd3b..97d7de4 100644 --- a/board/silica/pengwyn/board.c +++ b/board/silica/pengwyn/board.c @@ -77,11 +77,11 @@ const struct dpll_params dpll_ddr_400 = { void am33xx_spl_board_init(void) { - /* the pengwyn board uses the TPS650250 PMIC without I2C */ - /* interface and will output the following fixed voltages: */ - /* DCDC1=3V3 (IO) DCDC2=1V5 (DDR) DCDC3=1V26 (Vmpu) */ - /* VLDO1=1V8 (IO) VLDO2=1V8(IO) */ - /* Vcore=1V1 is fixed, generated by TPS62231 */ + /* The pengwyn board uses the TPS650250 PMIC without I2C + * interface and will output the following fixed voltages: + * DCDC1=3V3 (IO) DCDC2=1V5 (DDR) DCDC3=1V26 (Vmpu) + * VLDO1=1V8 (IO) VLDO2=1V8(IO) + * Vcore=1V1 is fixed, generated by TPS62231 */ /* Get the frequency */ dpll_mpu_opp100.m = am335x_get_efuse_mpu_max_freq(cdev); diff --git a/include/configs/pengwyn.h b/include/configs/pengwyn.h index 7a41151..f35cee6 100644 --- a/include/configs/pengwyn.h +++ b/include/configs/pengwyn.h @@ -19,10 +19,10 @@ /* Clock Defines */ #define V_OSCK 24000000 -#define V_SCLK (V_OSCK) +#define V_SCLK V_OSCK /* set env size */ -#define CONFIG_ENV_SIZE (0x4000) +#define CONFIG_ENV_SIZE 0x4000 #ifdef CONFIG_NAND #define NANDARGS \ @@ -179,8 +179,6 @@ #define CONFIG_SPL_POWER_SUPPORT #define CONFIG_SPL_YMODEM_SUPPORT - - /* General network SPL, both CPSW and USB gadget RNDIS */ #define CONFIG_SPL_NET_SUPPORT #define CONFIG_SPL_ENV_SUPPORT
Signed-off-by: Lothar Felten <lothar.felten@gmail.com> --- board/silica/pengwyn/board.c | 10 +++++----- include/configs/pengwyn.h | 6 ++---- 2 files changed, 7 insertions(+), 9 deletions(-)