| Message ID | 1390838309-11672-1-git-send-email-holger.brunck@keymile.com |
|---|---|
| State | Accepted |
| Delegated to: | Albert ARIBAUD |
| Headers | show |
Hi Holger, For the whole series: shouldn't the keymile boards maintainer be CC:ed? On Mon, 27 Jan 2014 16:58:22 +0100, Holger Brunck <holger.brunck@keymile.com> wrote: > CONFIG_BOOTCOUNT_LIMIT is used on all boards from this board series. So > remove this unneeded define. What if a new board/config does not want to use a bootcount limit? > Signed-off-by: Holger Brunck <holger.brunck@keymile.com> > --- > board/keymile/km_arm/km_arm.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/board/keymile/km_arm/km_arm.c b/board/keymile/km_arm/km_arm.c > index 5620737..946cbed 100644 > --- a/board/keymile/km_arm/km_arm.c > +++ b/board/keymile/km_arm/km_arm.c > @@ -164,7 +164,6 @@ static int initialize_unit_leds(void) > return 0; > } > > -#if defined(CONFIG_BOOTCOUNT_LIMIT) > static void set_bootcount_addr(void) > { > uchar buf[32]; > @@ -173,7 +172,6 @@ static void set_bootcount_addr(void) > sprintf((char *)buf, "0x%x", bootcountaddr); > setenv("bootcountaddr", (char *)buf); > } > -#endif > > int misc_init_r(void) > { > @@ -210,9 +208,7 @@ int misc_init_r(void) > > initialize_unit_leds(); > set_km_env(); > -#if defined(CONFIG_BOOTCOUNT_LIMIT) > set_bootcount_addr(); > -#endif > return 0; > } > Amicalement,
Hi Albert, On 02/13/2014 01:06 PM, Albert ARIBAUD wrote: > For the whole series: shouldn't the keymile boards maintainer be CC:ed? > > On Mon, 27 Jan 2014 16:58:22 +0100, Holger Brunck > <holger.brunck@keymile.com> wrote: > >> CONFIG_BOOTCOUNT_LIMIT is used on all boards from this board series. So >> remove this unneeded define. > > What if a new board/config does not want to use a bootcount limit? > all keymile boards use this and I don't see a usecase now and in the future that a board don't need it, thats why I decided to remove this here. IMHO it makes the code more readable to make only configurable what really needs to be configurable. Best regards Holger
Hi Holger, On Thu, 13 Feb 2014 13:10:51 +0100, Holger Brunck <holger.brunck@keymile.com> wrote: > Hi Albert, > > On 02/13/2014 01:06 PM, Albert ARIBAUD wrote: > > For the whole series: shouldn't the keymile boards maintainer be CC:ed? > > > > On Mon, 27 Jan 2014 16:58:22 +0100, Holger Brunck > > <holger.brunck@keymile.com> wrote: > > > >> CONFIG_BOOTCOUNT_LIMIT is used on all boards from this board series. So > >> remove this unneeded define. > > > > What if a new board/config does not want to use a bootcount limit? > > > > all keymile boards use this and I don't see a usecase now and in the future that > a board don't need it, thats why I decided to remove this here. IMHO it makes > the code more readable to make only configurable what really needs to be > configurable. Alright. And what about the keymile boards maintainer? > Best regards > Holger Amicalement,
Hi Albert, On 02/13/2014 01:14 PM, Albert ARIBAUD wrote: > On Thu, 13 Feb 2014 13:10:51 +0100, Holger Brunck >>> >>> What if a new board/config does not want to use a bootcount limit? >>> >> >> all keymile boards use this and I don't see a usecase now and in the future that >> a board don't need it, thats why I decided to remove this here. IMHO it makes >> the code more readable to make only configurable what really needs to be >> configurable. > > Alright. And what about the keymile boards maintainer? > ah I see I missed to set Valentin on CC for this patch serie. Ok I add him for this discussion. @Valentin: Could you Ack this Patch serie or say if something is missing Regards Holger
On 02/13/2014 01:19 PM, Holger Brunck wrote: > Hi Albert, > > On 02/13/2014 01:14 PM, Albert ARIBAUD wrote: >> On Thu, 13 Feb 2014 13:10:51 +0100, Holger Brunck >>>> >>>> What if a new board/config does not want to use a bootcount limit? >>>> >>> >>> all keymile boards use this and I don't see a usecase now and in the future that >>> a board don't need it, thats why I decided to remove this here. IMHO it makes >>> the code more readable to make only configurable what really needs to be >>> configurable. >> >> Alright. And what about the keymile boards maintainer? >> > > ah I see I missed to set Valentin on CC for this patch serie. Ok I add him for > this discussion. > > @Valentin: Could you Ack this Patch serie or say if something is missing > I have actually reviewed this series when it was applied in our interanl branch and tested them on most of our kirkwood boards. So for the whole series: Acked-by: Valentin Longchamp <valentin.longchamp@keymile.com>
diff --git a/board/keymile/km_arm/km_arm.c b/board/keymile/km_arm/km_arm.c index 5620737..946cbed 100644 --- a/board/keymile/km_arm/km_arm.c +++ b/board/keymile/km_arm/km_arm.c @@ -164,7 +164,6 @@ static int initialize_unit_leds(void) return 0; } -#if defined(CONFIG_BOOTCOUNT_LIMIT) static void set_bootcount_addr(void) { uchar buf[32]; @@ -173,7 +172,6 @@ static void set_bootcount_addr(void) sprintf((char *)buf, "0x%x", bootcountaddr); setenv("bootcountaddr", (char *)buf); } -#endif int misc_init_r(void) { @@ -210,9 +208,7 @@ int misc_init_r(void) initialize_unit_leds(); set_km_env(); -#if defined(CONFIG_BOOTCOUNT_LIMIT) set_bootcount_addr(); -#endif return 0; }
CONFIG_BOOTCOUNT_LIMIT is used on all boards from this board series. So remove this unneeded define. Signed-off-by: Holger Brunck <holger.brunck@keymile.com> --- board/keymile/km_arm/km_arm.c | 4 ---- 1 file changed, 4 deletions(-)