| Message ID | 1386667342-24464-1-git-send-email-claudiu.manoil@freescale.com |
|---|---|
| State | Accepted |
| Delegated to: | York Sun |
| Headers | show |
On 12/10/2013 01:22 AM, Claudiu Manoil wrote: > Add the __iomem address space marker for the tsec pointers > to struct tsec_mii_mng memory mapped register regions. > This solves the sparse warnings for mixig normal pointers with > __iomem pointers for tsec. > > p1_p2_rdb_pc.c:373:24: warning: incorrect type in assignment (different > address spaces) > p1_p2_rdb_pc.c:373:24: expected struct tsec_mii_mng [noderef] > <asn:2>*regs > p1_p2_rdb_pc.c:373:24: got struct tsec_mii_mng *<noident> > > Use TSEC_GET_MDIO_REGS_BASE() for the remaining mdio 'regs' > initializations to remove the __iomem warnings and for consistency. > > Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com> > --- Applied to u-boot-mpc85xx/master. Thanks. York
diff --git a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c b/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c index 966abb2..5f3d6fd 100644 --- a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c +++ b/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c @@ -1,5 +1,5 @@ /* - * Copyright 2010-2011 Freescale Semiconductor, Inc. + * Copyright 2010-2011, 2013 Freescale Semiconductor, Inc. * * SPDX-License-Identifier: GPL-2.0+ */ @@ -354,7 +354,7 @@ int board_eth_init(bd_t *bis) puts("No address specified for VSC7385 microcode.\n"); #endif - mdio_info.regs = (struct tsec_mii_mng *)CONFIG_SYS_MDIO_BASE_ADDR; + mdio_info.regs = TSEC_GET_MDIO_REGS_BASE(1); mdio_info.name = DEFAULT_MII_NAME; fsl_pq_mdio_init(bis, &mdio_info);
Add the __iomem address space marker for the tsec pointers to struct tsec_mii_mng memory mapped register regions. This solves the sparse warnings for mixig normal pointers with __iomem pointers for tsec. p1_p2_rdb_pc.c:373:24: warning: incorrect type in assignment (different address spaces) p1_p2_rdb_pc.c:373:24: expected struct tsec_mii_mng [noderef] <asn:2>*regs p1_p2_rdb_pc.c:373:24: got struct tsec_mii_mng *<noident> Use TSEC_GET_MDIO_REGS_BASE() for the remaining mdio 'regs' initializations to remove the __iomem warnings and for consistency. Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com> --- board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)