diff mbox

[U-Boot,1/4] mx51evk: Fix pmic_init() argument

Message ID 1384986366-14003-1-git-send-email-festevam@gmail.com
State Accepted
Delegated to: Stefano Babic
Headers show

Commit Message

Fabio Estevam Nov. 20, 2013, 10:26 p.m. UTC
From: Fabio Estevam <fabio.estevam@freescale.com>

On mx51evk board the PMIC is connected via SPI interface, so it does not make
sense to pass I2C_PMIC into the pmic_init() interface.

Pass the SPI bus number via CONFIG_FSL_PMIC_BUS option instead.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/freescale/mx51evk/mx51evk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefano Babic Nov. 21, 2013, 3:14 p.m. UTC | #1
On 20/11/2013 23:26, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> On mx51evk board the PMIC is connected via SPI interface, so it does not make
> sense to pass I2C_PMIC into the pmic_init() interface.
> 
> Pass the SPI bus number via CONFIG_FSL_PMIC_BUS option instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/freescale/mx51evk/mx51evk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/freescale/mx51evk/mx51evk.c b/board/freescale/mx51evk/mx51evk.c
> index d01465e..9b43c84 100644
> --- a/board/freescale/mx51evk/mx51evk.c
> +++ b/board/freescale/mx51evk/mx51evk.c
> @@ -174,7 +174,7 @@ static void power_init(void)
>  	struct pmic *p;
>  	int ret;
>  
> -	ret = pmic_init(I2C_PMIC);
> +	ret = pmic_init(CONFIG_FSL_PMIC_BUS);
>  	if (ret)
>  		return;
>  
> 

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
Stefano Babic Nov. 27, 2013, 8:42 a.m. UTC | #2
On 20/11/2013 23:26, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> On mx51evk board the PMIC is connected via SPI interface, so it does not make
> sense to pass I2C_PMIC into the pmic_init() interface.
> 
> Pass the SPI bus number via CONFIG_FSL_PMIC_BUS option instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/board/freescale/mx51evk/mx51evk.c b/board/freescale/mx51evk/mx51evk.c
index d01465e..9b43c84 100644
--- a/board/freescale/mx51evk/mx51evk.c
+++ b/board/freescale/mx51evk/mx51evk.c
@@ -174,7 +174,7 @@  static void power_init(void)
 	struct pmic *p;
 	int ret;
 
-	ret = pmic_init(I2C_PMIC);
+	ret = pmic_init(CONFIG_FSL_PMIC_BUS);
 	if (ret)
 		return;