Message ID | 1350495207-3474-2-git-send-email-festevam@gmail.com |
---|---|
State | Awaiting Upstream |
Delegated to: | Stefano Babic |
Headers | show |
>-----Original Message----- >From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] >On Behalf Of Fabio Estevam >Sent: Thursday, October 18, 2012 1:33 AM >To: sbabic@denx.de >Cc: Estevam Fabio-R49496; u-boot@lists.denx.de >Subject: [U-Boot] [PATCH 2/2] mx6qarm2: Enable DCACHE and >CONFIG_MMC_BOUNCE_BUFFER > >From: Fabio Estevam <fabio.estevam@freescale.com> > >Data cache and CONFIG_MMC_BOUNCE_BUFFER can be safely enabled now. Why we need enable CONFIG_MMC_BOUNCE_BUFFER? > >Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> >--- > include/configs/mx6qarm2.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/include/configs/mx6qarm2.h b/include/configs/mx6qarm2.h index >965bea3..b425fed 100644 >--- a/include/configs/mx6qarm2.h >+++ b/include/configs/mx6qarm2.h >@@ -50,6 +50,7 @@ > #define CONFIG_MMC > #define CONFIG_CMD_MMC > #define CONFIG_GENERIC_MMC >+#define CONFIG_MMC_BOUNCE_BUFFER > #define CONFIG_CMD_FAT > #define CONFIG_DOS_PARTITION > >@@ -164,6 +165,4 @@ > #define CONFIG_OF_LIBFDT > #define CONFIG_CMD_BOOTZ > >-#define CONFIG_SYS_DCACHE_OFF >- > #endif /* __CONFIG_H */ >-- >1.7.9.5 > >_______________________________________________ >U-Boot mailing list >U-Boot@lists.denx.de >http://lists.denx.de/mailman/listinfo/u-boot
Hi Jason,
On Wed, Oct 17, 2012 at 11:29 PM, Liu Hui-R64343 <r64343@freescale.com> wrote:
> Why we need enable CONFIG_MMC_BOUNCE_BUFFER?
I learned the following from Marek:
"you can't flush cache over unaligned addresses
so .. to make DMA work, we use the bounce buffer
so the address is cache aligned"
Regards,
Fabio Estevam
Am 17/10/2012 19:33, schrieb Fabio Estevam: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Data cache and CONFIG_MMC_BOUNCE_BUFFER can be safely enabled now. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic
diff --git a/include/configs/mx6qarm2.h b/include/configs/mx6qarm2.h index 965bea3..b425fed 100644 --- a/include/configs/mx6qarm2.h +++ b/include/configs/mx6qarm2.h @@ -50,6 +50,7 @@ #define CONFIG_MMC #define CONFIG_CMD_MMC #define CONFIG_GENERIC_MMC +#define CONFIG_MMC_BOUNCE_BUFFER #define CONFIG_CMD_FAT #define CONFIG_DOS_PARTITION @@ -164,6 +165,4 @@ #define CONFIG_OF_LIBFDT #define CONFIG_CMD_BOOTZ -#define CONFIG_SYS_DCACHE_OFF - #endif /* __CONFIG_H */