diff mbox

[U-Boot] kirkwood_spi: add dummy spi_init()

Message ID 1317939834-19777-1-git-send-email-michael@walle.cc
State Accepted
Commit efa4e43a40fae556c7af24292dda5e6500b9ca24
Headers show

Commit Message

Michael Walle Oct. 6, 2011, 10:23 p.m. UTC
The spi_init() function is missing. Add it.

Signed-off-by: Michael Walle <michael@walle.cc>
---
 drivers/spi/kirkwood_spi.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Comments

Mike Frysinger Oct. 7, 2011, 5:24 p.m. UTC | #1
Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
Michael Walle Oct. 16, 2011, 6:32 p.m. UTC | #2
Am Freitag 07 Oktober 2011, 00:23:54 schrieb Michael Walle:
> The spi_init() function is missing. Add it.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  drivers/spi/kirkwood_spi.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
> index a1c3070..8c35d5e 100644
> --- a/drivers/spi/kirkwood_spi.c
> +++ b/drivers/spi/kirkwood_spi.c
> @@ -106,6 +106,10 @@ int spi_cs_is_valid(unsigned int bus, unsigned int cs)
>  }
>  #endif
> 
> +void spi_init(void)
> +{
> +}
> +
>  void spi_cs_activate(struct spi_slave *slave)
>  {
>  	writel(readl(&spireg->ctrl) | KWSPI_IRQUNMASK, &spireg->ctrl);

Hi Wolfgang,
could you commit this small patch? (acked by mike)
Wolfgang Denk Oct. 16, 2011, 8:25 p.m. UTC | #3
Dear Michael Walle,

In message <201110162032.02236.michael@walle.cc> you wrote:
>
> > The spi_init() function is missing. Add it.
> > 
> > Signed-off-by: Michael Walle <michael@walle.cc>
...
> could you commit this small patch? (acked by mike)

No, I cannot.  This is kirkwood related and thus has to go through the
Marvell custodian.

You had him on Cc: ?

Best regards,

Wolfgang Denk
Michael Walle Oct. 16, 2011, 8:42 p.m. UTC | #4
Hi Wolfgang,

Am Sonntag 16 Oktober 2011, 22:25:11 schrieb Wolfgang Denk:
> In message <201110162032.02236.michael@walle.cc> you wrote:
> > > The spi_init() function is missing. Add it.
> > > 
> > > Signed-off-by: Michael Walle <michael@walle.cc>
> 
> ...
> 
> > could you commit this small patch? (acked by mike)
> 
> No, I cannot.  This is kirkwood related and thus has to go through the
> Marvell custodian.
oh sorry :)

> You had him on Cc: ?
No, but now.

@prafulla: please commit this patch.
Prafulla Wadaskar Oct. 17, 2011, 10:22 a.m. UTC | #5
> -----Original Message-----
> From: Michael Walle [mailto:michael@walle.cc]
> Sent: Monday, October 17, 2011 2:13 AM
> To: Wolfgang Denk
> Cc: u-boot@lists.denx.de; Prafulla Wadaskar
> Subject: Re: [PATCH] kirkwood_spi: add dummy spi_init()
> 
> Hi Wolfgang,
> 
> Am Sonntag 16 Oktober 2011, 22:25:11 schrieb Wolfgang Denk:
> > In message <201110162032.02236.michael@walle.cc> you wrote:
> > > > The spi_init() function is missing. Add it.
> > > >
> > > > Signed-off-by: Michael Walle <michael@walle.cc>
> >
> > ...
> >
> > > could you commit this small patch? (acked by mike)
> >
> > No, I cannot.  This is kirkwood related and thus has to go through the
> > Marvell custodian.
> oh sorry :)
> 
> > You had him on Cc: ?
> No, but now.
> 
> @prafulla: please commit this patch.

Sure, I will review and do it by tomorrow

Regards..
Prafulla . .

> 
> --
> Michael
Prafulla Wadaskar Oct. 18, 2011, 11:09 a.m. UTC | #6
> -----Original Message-----
> From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de]
> On Behalf Of Michael Walle
> Sent: Friday, October 07, 2011 3:54 AM
> To: u-boot@lists.denx.de
> Subject: [U-Boot] [PATCH] kirkwood_spi: add dummy spi_init()
> 
> The spi_init() function is missing. Add it.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  drivers/spi/kirkwood_spi.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
> index a1c3070..8c35d5e 100644
> --- a/drivers/spi/kirkwood_spi.c
> +++ b/drivers/spi/kirkwood_spi.c
> @@ -106,6 +106,10 @@ int spi_cs_is_valid(unsigned int bus, unsigned int
> cs)
>  }
>  #endif
> 
> +void spi_init(void)
> +{
> +}
> +
>  void spi_cs_activate(struct spi_slave *slave)
>  {
>  	writel(readl(&spireg->ctrl) | KWSPI_IRQUNMASK, &spireg->ctrl);
> --
> 1.7.2.5

Applied to u-boot-marvell.git master branch

Regards..
Prafulla . .
diff mbox

Patch

diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
index a1c3070..8c35d5e 100644
--- a/drivers/spi/kirkwood_spi.c
+++ b/drivers/spi/kirkwood_spi.c
@@ -106,6 +106,10 @@  int spi_cs_is_valid(unsigned int bus, unsigned int cs)
 }
 #endif
 
+void spi_init(void)
+{
+}
+
 void spi_cs_activate(struct spi_slave *slave)
 {
 	writel(readl(&spireg->ctrl) | KWSPI_IRQUNMASK, &spireg->ctrl);