diff mbox

[U-Boot] OMAP3: beagle: Fix build warning in beagle.c

Message ID 1316692402-24125-1-git-send-email-dirk.behme@gmail.com
State Accepted
Commit 513e6fd3eb98b74a71e2d83149f98c4e6fc3ce64
Headers show

Commit Message

Dirk Behme Sept. 22, 2011, 11:53 a.m. UTC
From: Dirk Behme <dirk.behme@googlemail.com>

Fix build warning

beagle.c:532: warning: initialization from incompatible pointer type

Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
CC: Jason Kridner <jkridner@beagleboard.org>
CC: Koen Kooi <koen@dominion.thruhere.net>
CC: Joel A Fernandes <agnel.joel@gmail.com>
Cc: Greg Turner <gregturner@ti.com>
CC: Sandeep Paulraj <s-paulraj@ti.com>

---
Note: This seems to be introduced with the commit

"BeagleBoard: Added userbutton command"

http://git.denx.de/?p=u-boot.git;a=commit;h=f835ea7158025818d69384a7ebd8c3de0f10a9f7

 board/ti/beagle/beagle.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jason Kridner Sept. 22, 2011, 12:41 p.m. UTC | #1
On Thu, Sep 22, 2011 at 7:53 AM, Dirk Behme <dirk.behme@googlemail.com> wrote:
> From: Dirk Behme <dirk.behme@googlemail.com>
>
> Fix build warning
>
> beagle.c:532: warning: initialization from incompatible pointer type
>
> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
> CC: Jason Kridner <jkridner@beagleboard.org>

Acked-by: Jason Kridner <jkridner@beagleboard.org>

> CC: Koen Kooi <koen@dominion.thruhere.net>
> CC: Joel A Fernandes <agnel.joel@gmail.com>
> Cc: Greg Turner <gregturner@ti.com>
> CC: Sandeep Paulraj <s-paulraj@ti.com>
>
> ---
> Note: This seems to be introduced with the commit
>
> "BeagleBoard: Added userbutton command"
>
> http://git.denx.de/?p=u-boot.git;a=commit;h=f835ea7158025818d69384a7ebd8c3de0f10a9f7
>
>  board/ti/beagle/beagle.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: u-boot.git/board/ti/beagle/beagle.c
> ===================================================================
> --- u-boot.git.orig/board/ti/beagle/beagle.c
> +++ u-boot.git/board/ti/beagle/beagle.c
> @@ -486,7 +486,7 @@ int ehci_hcd_init(void)
>  * Returns -   1 if button is held down
>  *             0 if button is not held down
>  */
> -int do_userbutton (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
> +int do_userbutton(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  {
>        int     button = 0;
>        int     gpio;
>
Albert ARIBAUD Sept. 22, 2011, 4:02 p.m. UTC | #2
Hi Dirk,

Le 22/09/2011 13:53, Dirk Behme a écrit :
> From: Dirk Behme<dirk.behme@googlemail.com>
>
> Fix build warning
>
> beagle.c:532: warning: initialization from incompatible pointer type
>
> Signed-off-by: Dirk Behme<dirk.behme@googlemail.com>
> CC: Jason Kridner<jkridner@beagleboard.org>
> CC: Koen Kooi<koen@dominion.thruhere.net>
> CC: Joel A Fernandes<agnel.joel@gmail.com>
> Cc: Greg Turner<gregturner@ti.com>
> CC: Sandeep Paulraj<s-paulraj@ti.com>
>
> ---

Applied to u-boot-arm/master, thanks!

Amicalement,
diff mbox

Patch

Index: u-boot.git/board/ti/beagle/beagle.c
===================================================================
--- u-boot.git.orig/board/ti/beagle/beagle.c
+++ u-boot.git/board/ti/beagle/beagle.c
@@ -486,7 +486,7 @@  int ehci_hcd_init(void)
  * Returns - 	1 if button is held down
  *		0 if button is not held down
  */
-int do_userbutton (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+int do_userbutton(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
 	int     button = 0;
 	int	gpio;