| Message ID | 1303790229-9332-1-git-send-email-macpaul@andestech.com |
|---|---|
| State | Rejected |
| Headers | show |
Dear Macpaul Lin, In message <1303790229-9332-1-git-send-email-macpaul@andestech.com> you wrote: > Replace usb root support from 2 to 5. > Some board has more then 2 usb slots hubs on the board. > > Signed-off-by: Macpaul Lin <macpaul@andestech.com> > --- > drivers/usb/host/ehci.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h > index 945ab64..c097d3d 100644 > --- a/drivers/usb/host/ehci.h > +++ b/drivers/usb/host/ehci.h > @@ -23,7 +23,7 @@ > #define USB_EHCI_H > > #if !defined(CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS) > -#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 2 > +#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 5 > #endif I think only very few systems will really need this. Why cannot you just #define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS in your board config file(s) then? Best regards, Wolfgang Denk
Hi Wolfgang, 2011/4/26 Wolfgang Denk <wd@denx.de>: > Dear Macpaul Lin, > >> #if !defined(CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS) >> -#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 2 >> +#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 5 >> #endif > > I think only very few systems will really need this. Why cannot you > just #define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS in your board config > file(s) then? > > Best regards, > > Wolfgang Denk I think 2 kinds of devices like thinclient and usb sharing hub device will require it. Okay, as your suggestion, I will do it in board config. Thanks.
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h index 945ab64..c097d3d 100644 --- a/drivers/usb/host/ehci.h +++ b/drivers/usb/host/ehci.h @@ -23,7 +23,7 @@ #define USB_EHCI_H #if !defined(CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS) -#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 2 +#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 5 #endif /* (shifted) direction/type/recipient from the USB 2.0 spec, table 9.2 */
Replace usb root support from 2 to 5. Some board has more then 2 usb slots hubs on the board. Signed-off-by: Macpaul Lin <macpaul@andestech.com> --- drivers/usb/host/ehci.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)