mbox series

[v3,0/8] mmc: zynqmp_sdhci: Add support for Tap delay

Message ID cover.1603712577.git.michal.simek@xilinx.com
Headers show
Series mmc: zynqmp_sdhci: Add support for Tap delay | expand

Message

Michal Simek Oct. 26, 2020, 11:42 a.m. UTC 
Hi,

this patchset adding support for Tap delay programming for ZynqMP and
Versal.
Based on mainline discussion also DT properties have been introduced which
are documented here.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/devicetree/bindings/mmc/mmc-controller.yaml?h=v5.7-rc6&id=fec81c5bca2499b4a263667860018c2ce47f4f51
The patchset is using these DT properties which are optional.
Default values are also listed.

The patchset is based on:
https://lists.denx.de/pipermail/u-boot/2020-May/410326.html

Also new code is adding checking for SOCs which are not needed at that time
when patch is applied (For example "mmc: zynq_sdhci: Read clock phase
delays from dt" and IS_ENABLED(CONFIG_ARCH_ZYNQMP)...
But I kept it there for more cleaner patches built on the top.

Thanks,
Michal


Changes in v3:
 - replace host->version by SDHCI_GET_VERSION(host) reported by Jaehoon
 - replace host->version by SDHCI_GET_VERSION(host) reported by Jaehoon

Changes in v2:
 - Timing macro's are common to all mmc drivers, hence remove zynq_sdhci
   from subject and description.
 - Add common function to set tapdelays based on the values read from DT
 - Remove tapdelay settings based on speed

Ashok Reddy Soma (6):
  Revert "mmc: zynq: parse dt when probing"
  mmc: Define timing macro's
  mmc: zynq_sdhci: Set tapdelays based on clk phase delays
  mmc: zynq_sdhci: Add clock phase delays for Versal
  mmc: zynq_sdhci: Extend UHS timings till hs200
  mmc: zynq_sdhci: Add common function to set input/output tapdelays

Michal Simek (2):
  mmc: zynq_sdhci: Move macro to the top
  mmc: zynq_sdhci: Read clock phase delays from dt

 board/xilinx/zynqmp/tap_delays.c | 199 +++------------
 drivers/mmc/sdhci.c              |   3 +-
 drivers/mmc/zynq_sdhci.c         | 406 +++++++++++++++++++++++++++++--
 include/mmc.h                    |  13 +
 include/sdhci.h                  |   1 +
 include/zynqmp_tap_delay.h       |   5 +-
 6 files changed, 434 insertions(+), 193 deletions(-)

Comments

Michal Simek Oct. 29, 2020, 7:57 a.m. UTC | #1 
po 26. 10. 2020 v 12:43 odesílatel Michal Simek
<michal.simek@xilinx.com> napsal:
>
> Hi,
>
> this patchset adding support for Tap delay programming for ZynqMP and
> Versal.
> Based on mainline discussion also DT properties have been introduced which
> are documented here.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/devicetree/bindings/mmc/mmc-controller.yaml?h=v5.7-rc6&id=fec81c5bca2499b4a263667860018c2ce47f4f51
> The patchset is using these DT properties which are optional.
> Default values are also listed.
>
> The patchset is based on:
> https://lists.denx.de/pipermail/u-boot/2020-May/410326.html
>
> Also new code is adding checking for SOCs which are not needed at that time
> when patch is applied (For example "mmc: zynq_sdhci: Read clock phase
> delays from dt" and IS_ENABLED(CONFIG_ARCH_ZYNQMP)...
> But I kept it there for more cleaner patches built on the top.
>
> Thanks,
> Michal
>
>
> Changes in v3:
>  - replace host->version by SDHCI_GET_VERSION(host) reported by Jaehoon
>  - replace host->version by SDHCI_GET_VERSION(host) reported by Jaehoon
>
> Changes in v2:
>  - Timing macro's are common to all mmc drivers, hence remove zynq_sdhci
>    from subject and description.
>  - Add common function to set tapdelays based on the values read from DT
>  - Remove tapdelay settings based on speed
>
> Ashok Reddy Soma (6):
>   Revert "mmc: zynq: parse dt when probing"
>   mmc: Define timing macro's
>   mmc: zynq_sdhci: Set tapdelays based on clk phase delays
>   mmc: zynq_sdhci: Add clock phase delays for Versal
>   mmc: zynq_sdhci: Extend UHS timings till hs200
>   mmc: zynq_sdhci: Add common function to set input/output tapdelays
>
> Michal Simek (2):
>   mmc: zynq_sdhci: Move macro to the top
>   mmc: zynq_sdhci: Read clock phase delays from dt
>
>  board/xilinx/zynqmp/tap_delays.c | 199 +++------------
>  drivers/mmc/sdhci.c              |   3 +-
>  drivers/mmc/zynq_sdhci.c         | 406 +++++++++++++++++++++++++++++--
>  include/mmc.h                    |  13 +
>  include/sdhci.h                  |   1 +
>  include/zynqmp_tap_delay.h       |   5 +-
>  6 files changed, 434 insertions(+), 193 deletions(-)
>
> --
> 2.28.0
>

The whole series is acked.
Applied to my tree.

Thanks,
Michal