| Message ID | 20240528095941.872693-1-ghidoliemanuele@gmail.com |
|---|---|
| Headers | show |
| Series | board: toradex: Add new Verdin and Aquila SKUs | expand |
Hi Emanuele, On Tue, May 28, 2024 at 7:00 AM Emanuele Ghidoli <ghidoliemanuele@gmail.com> wrote: > > From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com> > > Hi, > This series adds support for 0090 PID4 Verdin iMX8M Mini Quad 4GB WB ET SKU. > It also adds two new SKUs config block support: 0088 Aquila AM69 Octa 32GB WB IT and 0089 Verdin iMX95 Hexa 16GB WB IT. > > Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com> > > Emanuele Ghidoli (5): > board: toradex: verdin-imx8mm: add 4 GB lpddr4 memory support > board: toradex: verdin-imx8mm: increase maximum addressable ram to 4GB > toradex: tdx-cfg-block: add aquila am69 sku 0088 pid4 > toradex: tdx-cfg-block: add verdin imx95 sku 0089 pid4 > toradex: tdx-cfg-block: add verdin i.mx8m mini 0090 pid4 It would be better to split the series in two: one for the TI-SoC boards and another one for the NXP-SoC boards.
Hello Fabio, On Tue, May 28, 2024 at 09:31:47AM -0300, Fabio Estevam wrote: > Hi Emanuele, > > On Tue, May 28, 2024 at 7:00 AM Emanuele Ghidoli > <ghidoliemanuele@gmail.com> wrote: > > From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com> > > This series adds support for 0090 PID4 Verdin iMX8M Mini Quad 4GB WB > > ET SKU. It also adds two new SKUs config block support: 0088 Aquila > > AM69 Octa 32GB WB IT and 0089 Verdin iMX95 Hexa 16GB WB IT. > > > > Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com> > > > > Emanuele Ghidoli (5): > > board: toradex: verdin-imx8mm: add 4 GB lpddr4 memory support > > board: toradex: verdin-imx8mm: increase maximum addressable ram to 4GB > > toradex: tdx-cfg-block: add aquila am69 sku 0088 pid4 > > toradex: tdx-cfg-block: add verdin imx95 sku 0089 pid4 > > toradex: tdx-cfg-block: add verdin i.mx8m mini 0090 pid4 > > It would be better to split the series in two: one for the TI-SoC > boards and another one for the NXP-SoC boards. I disagree on doing this on this specific series. The reason is that the changes on the tdx-cfg-block are depending one on each other and they have nothing nxp nor ti specific, they are toradex specific. If I misunderstood your request, how would you do it? Patches 1,2,4 and 5 are for Toradex NXP board variant, patch 3 is for a Toradex TI board, patches 4 and 5 depend on patch 3. Francesco
Hi Francesco, On Tue, May 28, 2024 at 9:39 AM Francesco Dolcini <francesco@dolcini.it> wrote: > I disagree on doing this on this specific series. The reason is that the > changes on the tdx-cfg-block are depending one on each other and they > have nothing nxp nor ti specific, they are toradex specific. > > If I misunderstood your request, how would you do it? > Patches 1,2,4 and 5 are for Toradex NXP board variant, patch 3 is for a > Toradex TI board, patches 4 and 5 depend on patch 3. Thanks for the clarification. I will assign this series to me in patchwork then.
On Tue, May 28, 2024 at 7:00 AM Emanuele Ghidoli <ghidoliemanuele@gmail.com> wrote: > > From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com> > > Hi, > This series adds support for 0090 PID4 Verdin iMX8M Mini Quad 4GB WB ET SKU. > It also adds two new SKUs config block support: 0088 Aquila AM69 Octa 32GB WB IT and 0089 Verdin iMX95 Hexa 16GB WB IT. Applied all to u-boot-imx/next, thanks.