mbox series

[0/4] rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399

Message ID 20240210063252.1065611-1-wens@kernel.org
Headers show
Series rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399 | expand

Message

Chen-Yu Tsai Feb. 10, 2024, 6:32 a.m. UTC
From: Chen-Yu Tsai <wens@csie.org>

Hi folks,

This series enables ROCKCHIP_EFUSE and MISC_INIT_R by default for RK3328
and RK3399 so that the cpuid is read from the efuse and used to generate
a serial number and MAC addresses for all boards.

This stacks on top of the recent defconfig update series [1] from Jonas.

[1] https://lore.kernel.org/u-boot/20240207000301.3270722-1-jonas@kwiboo.se/


Chen-Yu Tsai (4):
  rockchip: rk3328: Read cpuid and generate MAC address from efuse
  rockchip: rk3399: Read cpuid and generate MAC address from efuse
  rockchip: rk3328: regenerate defconfigs
  rockchip: rk3399: regenerate defconfigs

 arch/arm/mach-rockchip/Kconfig                | 4 ++++
 configs/chromebook_bob_defconfig              | 2 --
 configs/chromebook_kevin_defconfig            | 2 --
 configs/evb-rk3328_defconfig                  | 2 --
 configs/firefly-rk3399_defconfig              | 2 --
 configs/nanopi-r2c-plus-rk3328_defconfig      | 2 --
 configs/nanopi-r2c-rk3328_defconfig           | 2 --
 configs/nanopi-r2s-rk3328_defconfig           | 2 --
 configs/nanopi-r4s-rk3399_defconfig           | 2 --
 configs/orangepi-r1-plus-lts-rk3328_defconfig | 2 --
 configs/orangepi-r1-plus-rk3328_defconfig     | 2 --
 configs/pinebook-pro-rk3399_defconfig         | 2 --
 configs/pinephone-pro-rk3399_defconfig        | 2 --
 configs/puma-rk3399_defconfig                 | 2 --
 configs/roc-cc-rk3328_defconfig               | 2 --
 configs/roc-pc-mezzanine-rk3399_defconfig     | 2 --
 configs/roc-pc-rk3399_defconfig               | 2 --
 configs/rock-4c-plus-rk3399_defconfig         | 3 ---
 configs/rock-4se-rk3399_defconfig             | 3 ---
 configs/rock-pi-4-rk3399_defconfig            | 3 ---
 configs/rock-pi-4c-rk3399_defconfig           | 3 ---
 configs/rock-pi-e-rk3328_defconfig            | 2 --
 configs/rock-pi-n10-rk3399pro_defconfig       | 1 -
 configs/rock64-rk3328_defconfig               | 2 --
 configs/rock960-rk3399_defconfig              | 1 -
 configs/rockpro64-rk3399_defconfig            | 2 --
 26 files changed, 4 insertions(+), 52 deletions(-)

Comments

Christopher Obbard Feb. 10, 2024, 9:06 a.m. UTC | #1
Hi Chen-Yu,

For the entire series:

Reviewed-by: Christopher Obbard <chris.obbard@collabora.com>

On 10 February 2024 06:32:46 GMT, Chen-Yu Tsai <wens@kernel.org> wrote:
>From: Chen-Yu Tsai <wens@csie.org>
>
>Hi folks,
>
>This series enables ROCKCHIP_EFUSE and MISC_INIT_R by default for RK3328
>and RK3399 so that the cpuid is read from the efuse and used to generate
>a serial number and MAC addresses for all boards.
>
>This stacks on top of the recent defconfig update series [1] from Jonas.
>
>[1] https://lore.kernel.org/u-boot/20240207000301.3270722-1-jonas@kwiboo.se/
>
>
>Chen-Yu Tsai (4):
>  rockchip: rk3328: Read cpuid and generate MAC address from efuse
>  rockchip: rk3399: Read cpuid and generate MAC address from efuse
>  rockchip: rk3328: regenerate defconfigs
>  rockchip: rk3399: regenerate defconfigs
>
> arch/arm/mach-rockchip/Kconfig                | 4 ++++
> configs/chromebook_bob_defconfig              | 2 --
> configs/chromebook_kevin_defconfig            | 2 --
> configs/evb-rk3328_defconfig                  | 2 --
> configs/firefly-rk3399_defconfig              | 2 --
> configs/nanopi-r2c-plus-rk3328_defconfig      | 2 --
> configs/nanopi-r2c-rk3328_defconfig           | 2 --
> configs/nanopi-r2s-rk3328_defconfig           | 2 --
> configs/nanopi-r4s-rk3399_defconfig           | 2 --
> configs/orangepi-r1-plus-lts-rk3328_defconfig | 2 --
> configs/orangepi-r1-plus-rk3328_defconfig     | 2 --
> configs/pinebook-pro-rk3399_defconfig         | 2 --
> configs/pinephone-pro-rk3399_defconfig        | 2 --
> configs/puma-rk3399_defconfig                 | 2 --
> configs/roc-cc-rk3328_defconfig               | 2 --
> configs/roc-pc-mezzanine-rk3399_defconfig     | 2 --
> configs/roc-pc-rk3399_defconfig               | 2 --
> configs/rock-4c-plus-rk3399_defconfig         | 3 ---
> configs/rock-4se-rk3399_defconfig             | 3 ---
> configs/rock-pi-4-rk3399_defconfig            | 3 ---
> configs/rock-pi-4c-rk3399_defconfig           | 3 ---
> configs/rock-pi-e-rk3328_defconfig            | 2 --
> configs/rock-pi-n10-rk3399pro_defconfig       | 1 -
> configs/rock64-rk3328_defconfig               | 2 --
> configs/rock960-rk3399_defconfig              | 1 -
> configs/rockpro64-rk3399_defconfig            | 2 --
> 26 files changed, 4 insertions(+), 52 deletions(-)
>
>-- 
>2.39.2
>
Dragan Simic Feb. 10, 2024, 4:37 p.m. UTC | #2
On 2024-02-10 07:32, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@csie.org>
> 
> This series enables ROCKCHIP_EFUSE and MISC_INIT_R by default for 
> RK3328
> and RK3399 so that the cpuid is read from the efuse and used to 
> generate
> a serial number and MAC addresses for all boards.
> 
> This stacks on top of the recent defconfig update series [1] from 
> Jonas.

The entire series is looking good to me!

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

> [1] 
> https://lore.kernel.org/u-boot/20240207000301.3270722-1-jonas@kwiboo.se/
> 
> Chen-Yu Tsai (4):
>   rockchip: rk3328: Read cpuid and generate MAC address from efuse
>   rockchip: rk3399: Read cpuid and generate MAC address from efuse
>   rockchip: rk3328: regenerate defconfigs
>   rockchip: rk3399: regenerate defconfigs
> 
>  arch/arm/mach-rockchip/Kconfig                | 4 ++++
>  configs/chromebook_bob_defconfig              | 2 --
>  configs/chromebook_kevin_defconfig            | 2 --
>  configs/evb-rk3328_defconfig                  | 2 --
>  configs/firefly-rk3399_defconfig              | 2 --
>  configs/nanopi-r2c-plus-rk3328_defconfig      | 2 --
>  configs/nanopi-r2c-rk3328_defconfig           | 2 --
>  configs/nanopi-r2s-rk3328_defconfig           | 2 --
>  configs/nanopi-r4s-rk3399_defconfig           | 2 --
>  configs/orangepi-r1-plus-lts-rk3328_defconfig | 2 --
>  configs/orangepi-r1-plus-rk3328_defconfig     | 2 --
>  configs/pinebook-pro-rk3399_defconfig         | 2 --
>  configs/pinephone-pro-rk3399_defconfig        | 2 --
>  configs/puma-rk3399_defconfig                 | 2 --
>  configs/roc-cc-rk3328_defconfig               | 2 --
>  configs/roc-pc-mezzanine-rk3399_defconfig     | 2 --
>  configs/roc-pc-rk3399_defconfig               | 2 --
>  configs/rock-4c-plus-rk3399_defconfig         | 3 ---
>  configs/rock-4se-rk3399_defconfig             | 3 ---
>  configs/rock-pi-4-rk3399_defconfig            | 3 ---
>  configs/rock-pi-4c-rk3399_defconfig           | 3 ---
>  configs/rock-pi-e-rk3328_defconfig            | 2 --
>  configs/rock-pi-n10-rk3399pro_defconfig       | 1 -
>  configs/rock64-rk3328_defconfig               | 2 --
>  configs/rock960-rk3399_defconfig              | 1 -
>  configs/rockpro64-rk3399_defconfig            | 2 --
>  26 files changed, 4 insertions(+), 52 deletions(-)
Peter Robinson Feb. 12, 2024, 1:57 p.m. UTC | #3
On Sat, 10 Feb 2024 at 06:32, Chen-Yu Tsai <wens@kernel.org> wrote:
>
> From: Chen-Yu Tsai <wens@csie.org>
>
> Hi folks,
>
> This series enables ROCKCHIP_EFUSE and MISC_INIT_R by default for RK3328
> and RK3399 so that the cpuid is read from the efuse and used to generate
> a serial number and MAC addresses for all boards.

For the series:
Reviewed-by: Peter Robinson <pbrobinson@gmail.com>

> This stacks on top of the recent defconfig update series [1] from Jonas.
>
> [1] https://lore.kernel.org/u-boot/20240207000301.3270722-1-jonas@kwiboo.se/
>
>
> Chen-Yu Tsai (4):
>   rockchip: rk3328: Read cpuid and generate MAC address from efuse
>   rockchip: rk3399: Read cpuid and generate MAC address from efuse
>   rockchip: rk3328: regenerate defconfigs
>   rockchip: rk3399: regenerate defconfigs
>
>  arch/arm/mach-rockchip/Kconfig                | 4 ++++
>  configs/chromebook_bob_defconfig              | 2 --
>  configs/chromebook_kevin_defconfig            | 2 --
>  configs/evb-rk3328_defconfig                  | 2 --
>  configs/firefly-rk3399_defconfig              | 2 --
>  configs/nanopi-r2c-plus-rk3328_defconfig      | 2 --
>  configs/nanopi-r2c-rk3328_defconfig           | 2 --
>  configs/nanopi-r2s-rk3328_defconfig           | 2 --
>  configs/nanopi-r4s-rk3399_defconfig           | 2 --
>  configs/orangepi-r1-plus-lts-rk3328_defconfig | 2 --
>  configs/orangepi-r1-plus-rk3328_defconfig     | 2 --
>  configs/pinebook-pro-rk3399_defconfig         | 2 --
>  configs/pinephone-pro-rk3399_defconfig        | 2 --
>  configs/puma-rk3399_defconfig                 | 2 --
>  configs/roc-cc-rk3328_defconfig               | 2 --
>  configs/roc-pc-mezzanine-rk3399_defconfig     | 2 --
>  configs/roc-pc-rk3399_defconfig               | 2 --
>  configs/rock-4c-plus-rk3399_defconfig         | 3 ---
>  configs/rock-4se-rk3399_defconfig             | 3 ---
>  configs/rock-pi-4-rk3399_defconfig            | 3 ---
>  configs/rock-pi-4c-rk3399_defconfig           | 3 ---
>  configs/rock-pi-e-rk3328_defconfig            | 2 --
>  configs/rock-pi-n10-rk3399pro_defconfig       | 1 -
>  configs/rock64-rk3328_defconfig               | 2 --
>  configs/rock960-rk3399_defconfig              | 1 -
>  configs/rockpro64-rk3399_defconfig            | 2 --
>  26 files changed, 4 insertions(+), 52 deletions(-)
>
> --
> 2.39.2
>
Chen-Yu Tsai Feb. 12, 2024, 2:05 p.m. UTC | #4
On Mon, Feb 12, 2024 at 9:57 PM Peter Robinson <pbrobinson@gmail.com> wrote:
>
> On Sat, 10 Feb 2024 at 06:32, Chen-Yu Tsai <wens@kernel.org> wrote:
> >
> > From: Chen-Yu Tsai <wens@csie.org>
> >
> > Hi folks,
> >
> > This series enables ROCKCHIP_EFUSE and MISC_INIT_R by default for RK3328
> > and RK3399 so that the cpuid is read from the efuse and used to generate
> > a serial number and MAC addresses for all boards.
>
> For the series:
> Reviewed-by: Peter Robinson <pbrobinson@gmail.com>

Thanks. I just sent out v2. Could you reply there as well?