mbox series

[0/2] USB fixes: Add missing timeout, ignore YubiKeys

Message ID 20231029-usb-fixes-2-v1-0-9f793aa20fe4@marcan.st
Headers show
Series USB fixes: Add missing timeout, ignore YubiKeys | expand

Message

Hector Martin Oct. 29, 2023, 7:09 a.m. UTC 
This mini series fixes one bug, but in the process makes YubiKeys work,
which then regresses people who have one *and* a USB keyboard, since we
only support a single keyboard device.

Therefore patch #1 makes U-Boot ignore YubiKeys, so #2 does not
regress things.

Signed-off-by: Hector Martin <marcan@marcan.st>
---
Hector Martin (2):
      usb: kbd: Ignore Yubikeys
      usb: hub: Add missing reset recovery delay

 common/usb_hub.c |  7 +++++++
 common/usb_kbd.c | 19 +++++++++++++++++++
 2 files changed, 26 insertions(+)
---
base-commit: 8ad1c9c26f7740806a162818b790d4a72f515b7e
change-id: 20231029-usb-fixes-2-976486d1603c

Best regards,

Comments

Neal Gompa Oct. 29, 2023, 2:34 p.m. UTC | #1 
On Sun, Oct 29, 2023 at 3:09 AM Hector Martin <marcan@marcan.st> wrote:
>
> This mini series fixes one bug, but in the process makes YubiKeys work,
> which then regresses people who have one *and* a USB keyboard, since we
> only support a single keyboard device.
>
> Therefore patch #1 makes U-Boot ignore YubiKeys, so #2 does not
> regress things.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
> Hector Martin (2):
>       usb: kbd: Ignore Yubikeys
>       usb: hub: Add missing reset recovery delay
>
>  common/usb_hub.c |  7 +++++++
>  common/usb_kbd.c | 19 +++++++++++++++++++
>  2 files changed, 26 insertions(+)
> ---
> base-commit: 8ad1c9c26f7740806a162818b790d4a72f515b7e
> change-id: 20231029-usb-fixes-2-976486d1603c
>

Series LGTM.

Reviewed-by: Neal Gompa <neal@gompa.dev>