| Message ID | 20230612205444.363727-1-marcel@ziswiler.com |
|---|---|
| Headers | show |
| Series | board: toradex: add verdin am62 support | expand |
Hello! Just a quick look into this patch and I see that it contains lot of dead code hidden in '#if 0'. Could you cleanup it?
Hi Pali On Mon, 2023-06-12 at 23:01 +0200, Pali Rohár wrote: > Hello! Just a quick look into this patch and I see that it contains lot > of dead code hidden in '#if 0'. Could you cleanup it? I assume you mean those few as can be found in our device trees. This is due to them device trees coming straight from upstream Linux [1], however, the base TI K3 SoC dtsi have not been synchronised recently. Once that is done (e.g. as partially done by [2]) those '#if 0' may simply be removed again. [1] https://lore.kernel.org/all/20230601131332.26877-1-francesco@dolcini.it/ [2] https://lore.kernel.org/all/20230406185542.1179073-4-sjoerd@collabora.com/ Cheers Marcel
From: Marcel Ziswiler <marcel.ziswiler@toradex.com> This series adds initial support for the Toradex Verdin AM62 SoM [1]. The first commit adds resp. PID4 to the ConfigBlock, the second one fixes an early clocking issue confirmed to be a weird bug in TI's scripting. And last but not least support for the Toradex Verdin AM62 is added. Please note that this series is based on Emanuele's recent work on get_ram_size() [2]. [1] https://www.toradex.com/computer-on-modules/verdin-arm-family/ti-am62 [2] https://lore.kernel.org/all/20230530133327.178278-1-francesco@dolcini.it Changes in v2: - Add Bryan's reviewed-by tag. Thanks! - Use 1.2 GHz rather than 1.25 GHz A53 clock as on the EVM/SK. - Also add power-domain 166 as on the EVM/SK. - Get rid of main_bcdma and main_pktdma as not required in R5 SPL. - Get rid of all bootph-pre-ram in Ethernet and SDHC1 aka SD card related pinctrls as not required in any SPL. - Enable CONFIG_TI_SECURE_DEVICE by default as Non-HS devices will continue to boot due to runtime device type detection. - Disable FAT and SPI support as not required in R5 SPL. - Also enable CONFIG_SPL_MMC_HS200_SUPPORT in R5 SPL. - Enable CONFIG_LEGACY_IMAGE_FORMAT to allow sourcing unsigned script images e.g. like our current boot scripts. - Increase CONFIG_SYS_BOOTM_LEN to 64 MB to allow booting bigger compressed images as e.g. in the Toradex Easy Installer case. - Change memory configurations to operate at temperatures of up to 95 degrees celsius. - Increase CONFIG_SYS_MAXARGS from default 16 to 64. - Enable CONFIG_CMD_REMOTEPROC, CONFIG_SPL_DM_GPIO_LOOKUP_LABEL and CONFIG_SPL_I2C_EEPROM. - For R5 SPL increase CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN to 0x140000, enable CONFIG_SPL_I2C, CONFIG_DM_I2C and CONFIG_SYS_I2C_OMAP24XX and savedefconfig got rid of CONFIG_SPL_FIT_IMAGE_POST_PROCESS. Marcel Ziswiler (3): toradex: tdx-cfg-block: add 0069 verdin am62 quad 1gb wb it arm: mach-k3: am62: fix 2nd mux option of clkout0 board: toradex: add verdin am62 support arch/arm/dts/Makefile | 3 + arch/arm/dts/k3-am62-verdin-dev.dtsi | 248 ++ arch/arm/dts/k3-am62-verdin-wifi.dtsi | 39 + arch/arm/dts/k3-am62-verdin.dtsi | 1411 +++++++++++ .../dts/k3-am625-verdin-lpddr4-1600MTs.dtsi | 2190 +++++++++++++++++ arch/arm/dts/k3-am625-verdin-r5.dts | 115 + .../dts/k3-am625-verdin-wifi-dev-u-boot.dtsi | 215 ++ arch/arm/dts/k3-am625-verdin-wifi-dev.dts | 22 + arch/arm/mach-k3/Kconfig | 1 + arch/arm/mach-k3/am62x/clk-data.c | 5 +- board/toradex/common/tdx-cfg-block.c | 1 + board/toradex/common/tdx-cfg-block.h | 1 + board/toradex/verdin-am62/Kconfig | 80 + board/toradex/verdin-am62/MAINTAINERS | 16 + board/toradex/verdin-am62/Makefile | 6 + board/toradex/verdin-am62/verdin-am62.c | 117 + configs/verdin-am62_a53_defconfig | 184 ++ configs/verdin-am62_r5_defconfig | 111 + doc/board/toradex/verdin-am62.rst | 167 ++ include/configs/verdin-am62.h | 54 + 20 files changed, 4984 insertions(+), 2 deletions(-) create mode 100644 arch/arm/dts/k3-am62-verdin-dev.dtsi create mode 100644 arch/arm/dts/k3-am62-verdin-wifi.dtsi create mode 100644 arch/arm/dts/k3-am62-verdin.dtsi create mode 100644 arch/arm/dts/k3-am625-verdin-lpddr4-1600MTs.dtsi create mode 100644 arch/arm/dts/k3-am625-verdin-r5.dts create mode 100644 arch/arm/dts/k3-am625-verdin-wifi-dev-u-boot.dtsi create mode 100644 arch/arm/dts/k3-am625-verdin-wifi-dev.dts create mode 100644 board/toradex/verdin-am62/Kconfig create mode 100644 board/toradex/verdin-am62/MAINTAINERS create mode 100644 board/toradex/verdin-am62/Makefile create mode 100644 board/toradex/verdin-am62/verdin-am62.c create mode 100644 configs/verdin-am62_a53_defconfig create mode 100644 configs/verdin-am62_r5_defconfig create mode 100644 doc/board/toradex/verdin-am62.rst create mode 100644 include/configs/verdin-am62.h