| Message ID | 20230502185817.374951-1-william.zhang@broadcom.com |
|---|---|
| Headers | show |
| Series | spi: bcm63xx-hsspi: driver and doc updates | expand |
Hi Jagan and Tom, Any chance to get this patch series into the u-boot? I haven't heard any feedback and comments but they are largely based on patch series for linux that was accepted in kernel stable release 6.3 and verified on Broadcom reference boards. Thanks, William On 05/02/2023 11:58 AM, William Zhang wrote: > This patch series is the u-boot port from the recently accepted kernel > Broadcom HSSPI driver patch series here [1]. It includes the > accumulative updates and fixes for the driver from Broadcom. It also > added a new driver for the updated SPI controller found in the new > BCMBCA SoC. The device tree document is converted to yaml format and > updated accordingly. > > [1]: https://lore.kernel.org/all/20230207065826.285013-1-william.zhang@broadcom.com/ > > Changes in v2: > - Add Álvaro Fernández Rojas as another maintainer > > William Zhang (9): > dt-bindings: spi: Add bcm63xx-hsspi controller support > ARM: dts: broadcom: bcmbca: Add spi controller node > arm64: dts: broadcom: bcmbca: Add spi controller node > spi: bcm63xx-hsspi: Enable SPI drivers by default > spi: bcm63xx-hsspi: Add new compatible string support > spi: bcm63xx-hsspi: Fix multi-bit mode setting > spi: bcm63xx-hsspi: Add prepend mode support > spi: bcmbca-hsspi: Add driver for newer HSSPI controller > MAINTAINERS: Add Broadcom Broadband SoC HS SPI drivers > > MAINTAINERS | 9 + > arch/arm/Kconfig | 2 + > arch/arm/dts/bcm47622.dtsi | 18 + > arch/arm/dts/bcm4908.dtsi | 17 + > arch/arm/dts/bcm4912.dtsi | 20 + > arch/arm/dts/bcm63138.dtsi | 18 + > arch/arm/dts/bcm63146.dtsi | 19 + > arch/arm/dts/bcm63148.dtsi | 18 + > arch/arm/dts/bcm63158.dtsi | 15 +- > arch/arm/dts/bcm63178.dtsi | 19 + > arch/arm/dts/bcm6756.dtsi | 19 + > arch/arm/dts/bcm6813.dtsi | 20 + > arch/arm/dts/bcm6846.dtsi | 18 + > arch/arm/dts/bcm6855.dtsi | 27 +- > arch/arm/dts/bcm6856.dtsi | 23 +- > arch/arm/dts/bcm6858.dtsi | 23 +- > arch/arm/dts/bcm6878.dtsi | 19 + > arch/arm/dts/bcm947622.dts | 4 + > arch/arm/dts/bcm94908.dts | 4 + > arch/arm/dts/bcm94912.dts | 4 + > arch/arm/dts/bcm963138.dts | 4 + > arch/arm/dts/bcm963146.dts | 4 + > arch/arm/dts/bcm963148.dts | 4 + > arch/arm/dts/bcm963158.dts | 4 + > arch/arm/dts/bcm963178.dts | 4 + > arch/arm/dts/bcm96756.dts | 4 + > arch/arm/dts/bcm96813.dts | 4 + > arch/arm/dts/bcm96846.dts | 4 + > arch/arm/dts/bcm96855.dts | 4 + > arch/arm/dts/bcm96856.dts | 4 + > arch/arm/dts/bcm96858.dts | 4 + > arch/arm/dts/bcm96878.dts | 4 + > arch/arm/mach-bcmbca/Kconfig | 26 ++ > .../spi/brcm,bcm63xx-hsspi.yaml | 134 ++++++ > drivers/spi/Kconfig | 13 +- > drivers/spi/Makefile | 1 + > drivers/spi/bcm63xx_hsspi.c | 277 +++++++++++- > drivers/spi/bcmbca_hsspi.c | 414 ++++++++++++++++++ > 38 files changed, 1160 insertions(+), 69 deletions(-) > create mode 100644 doc/device-tree-bindings/spi/brcm,bcm63xx-hsspi.yaml > create mode 100644 drivers/spi/bcmbca_hsspi.c >
On Wed, May 3, 2023 at 12:29 AM William Zhang <william.zhang@broadcom.com> wrote: > > This patch series is the u-boot port from the recently accepted kernel > Broadcom HSSPI driver patch series here [1]. It includes the > accumulative updates and fixes for the driver from Broadcom. It also > added a new driver for the updated SPI controller found in the new > BCMBCA SoC. The device tree document is converted to yaml format and > updated accordingly. > > [1]: https://lore.kernel.org/all/20230207065826.285013-1-william.zhang@broadcom.com/ > > Changes in v2: > - Add Álvaro Fernández Rojas as another maintainer > > William Zhang (9): > dt-bindings: spi: Add bcm63xx-hsspi controller support > ARM: dts: broadcom: bcmbca: Add spi controller node > arm64: dts: broadcom: bcmbca: Add spi controller node > spi: bcm63xx-hsspi: Enable SPI drivers by default > spi: bcm63xx-hsspi: Add new compatible string support > spi: bcm63xx-hsspi: Fix multi-bit mode setting This will fix for the upcoming release. > spi: bcm63xx-hsspi: Add prepend mode support > spi: bcmbca-hsspi: Add driver for newer HSSPI controller > MAINTAINERS: Add Broadcom Broadband SoC HS SPI drivers Patches send the patches related to SPI as separate series. Also please note that for arch patches, I have moved to tom since I'm unable to find the proper delate for bcmbca. Thanks, Jagan.
Hi Jagan, On 06/01/2023 11:01 PM, Jagan Teki wrote: > On Wed, May 3, 2023 at 12:29 AM William Zhang > <william.zhang@broadcom.com> wrote: >> >> This patch series is the u-boot port from the recently accepted kernel >> Broadcom HSSPI driver patch series here [1]. It includes the >> accumulative updates and fixes for the driver from Broadcom. It also >> added a new driver for the updated SPI controller found in the new >> BCMBCA SoC. The device tree document is converted to yaml format and >> updated accordingly. >> >> [1]: https://lore.kernel.org/all/20230207065826.285013-1-william.zhang@broadcom.com/ >> >> Changes in v2: >> - Add Álvaro Fernández Rojas as another maintainer >> >> William Zhang (9): >> dt-bindings: spi: Add bcm63xx-hsspi controller support >> ARM: dts: broadcom: bcmbca: Add spi controller node >> arm64: dts: broadcom: bcmbca: Add spi controller node >> spi: bcm63xx-hsspi: Enable SPI drivers by default >> spi: bcm63xx-hsspi: Add new compatible string support >> spi: bcm63xx-hsspi: Fix multi-bit mode setting > > This will fix for the upcoming release. > >> spi: bcm63xx-hsspi: Add prepend mode support >> spi: bcmbca-hsspi: Add driver for newer HSSPI controller >> MAINTAINERS: Add Broadcom Broadband SoC HS SPI drivers > > Patches send the patches related to SPI as separate series. > > Also please note that for arch patches, I have moved to tom since I'm > unable to find the proper delate for bcmbca. > Thanks Jagan for the reviews. I will send out two patches series with updates based on the reviews: one for SPI driver changes and another for arch/dts/doc changes > Thanks, > Jagan. >
Hi Jagan, On 06/02/2023 11:56 AM, William Zhang wrote: > Hi Jagan, > > On 06/01/2023 11:01 PM, Jagan Teki wrote: >> On Wed, May 3, 2023 at 12:29 AM William Zhang >> <william.zhang@broadcom.com> wrote: >>> >>> This patch series is the u-boot port from the recently accepted kernel >>> Broadcom HSSPI driver patch series here [1]. It includes the >>> accumulative updates and fixes for the driver from Broadcom. It also >>> added a new driver for the updated SPI controller found in the new >>> BCMBCA SoC. The device tree document is converted to yaml format and >>> updated accordingly. >>> >>> [1]: >>> https://lore.kernel.org/all/20230207065826.285013-1-william.zhang@broadcom.com/ >>> >>> >>> Changes in v2: >>> - Add Álvaro Fernández Rojas as another maintainer >>> >>> William Zhang (9): >>> dt-bindings: spi: Add bcm63xx-hsspi controller support >>> ARM: dts: broadcom: bcmbca: Add spi controller node >>> arm64: dts: broadcom: bcmbca: Add spi controller node >>> spi: bcm63xx-hsspi: Enable SPI drivers by default >>> spi: bcm63xx-hsspi: Add new compatible string support >>> spi: bcm63xx-hsspi: Fix multi-bit mode setting >> >> This will fix for the upcoming release. >> >>> spi: bcm63xx-hsspi: Add prepend mode support >>> spi: bcmbca-hsspi: Add driver for newer HSSPI controller >>> MAINTAINERS: Add Broadcom Broadband SoC HS SPI drivers >> >> Patches send the patches related to SPI as separate series. >> >> Also please note that for arch patches, I have moved to tom since I'm >> unable to find the proper delate for bcmbca. >> > Thanks Jagan for the reviews. I will send out two patches series with > updates based on the reviews: one for SPI driver changes and another for > arch/dts/doc changes > There is one issue in separating the patches to SPI only changes and arch/dts changes. The new BCMBCA HSSPI driver depends on a new config HAVE_SPI_CS_CTRL that is added to arch/arm/mach-bcmbca/Kconfig in the arch change patch series. So you will get build error on generating the .config and have to pick that change to avoid that issue. Will that be okay? >> Thanks, >> Jagan. >>
On Tue, Jun 06, 2023 at 01:19:47PM -0700, William Zhang wrote: > Hi Jagan, > > On 06/02/2023 11:56 AM, William Zhang wrote: > > Hi Jagan, > > > > On 06/01/2023 11:01 PM, Jagan Teki wrote: > > > On Wed, May 3, 2023 at 12:29 AM William Zhang > > > <william.zhang@broadcom.com> wrote: > > > > > > > > This patch series is the u-boot port from the recently accepted kernel > > > > Broadcom HSSPI driver patch series here [1]. It includes the > > > > accumulative updates and fixes for the driver from Broadcom. It also > > > > added a new driver for the updated SPI controller found in the new > > > > BCMBCA SoC. The device tree document is converted to yaml format and > > > > updated accordingly. > > > > > > > > [1]: https://lore.kernel.org/all/20230207065826.285013-1-william.zhang@broadcom.com/ > > > > > > > > > > > > Changes in v2: > > > > - Add Álvaro Fernández Rojas as another maintainer > > > > > > > > William Zhang (9): > > > > dt-bindings: spi: Add bcm63xx-hsspi controller support > > > > ARM: dts: broadcom: bcmbca: Add spi controller node > > > > arm64: dts: broadcom: bcmbca: Add spi controller node > > > > spi: bcm63xx-hsspi: Enable SPI drivers by default > > > > spi: bcm63xx-hsspi: Add new compatible string support > > > > spi: bcm63xx-hsspi: Fix multi-bit mode setting > > > > > > This will fix for the upcoming release. > > > > > > > spi: bcm63xx-hsspi: Add prepend mode support > > > > spi: bcmbca-hsspi: Add driver for newer HSSPI controller > > > > MAINTAINERS: Add Broadcom Broadband SoC HS SPI drivers > > > > > > Patches send the patches related to SPI as separate series. > > > > > > Also please note that for arch patches, I have moved to tom since I'm > > > unable to find the proper delate for bcmbca. > > > > > Thanks Jagan for the reviews. I will send out two patches series with > > updates based on the reviews: one for SPI driver changes and another for > > arch/dts/doc changes > > > There is one issue in separating the patches to SPI only changes and > arch/dts changes. The new BCMBCA HSSPI driver depends on a new config > HAVE_SPI_CS_CTRL that is added to arch/arm/mach-bcmbca/Kconfig > in the arch change patch series. So you will get build error on generating > the .config and have to pick that change to avoid that issue. Will that be > okay? Frankly I'd rather the whole series just come in via Jagan's tree, or if he's uncomfortable with that, I'll take the whole series if he's fine with the SPI side. We don't need to worry about which sub-tree is used so long as maintainers are happy with the contents, in U-Boot, imho.
Hi Tom, On 06/07/2023 01:05 PM, Tom Rini wrote: > On Tue, Jun 06, 2023 at 01:19:47PM -0700, William Zhang wrote: >> Hi Jagan, >> >> On 06/02/2023 11:56 AM, William Zhang wrote: >>> Hi Jagan, >>> >>> On 06/01/2023 11:01 PM, Jagan Teki wrote: >>>> On Wed, May 3, 2023 at 12:29 AM William Zhang >>>> <william.zhang@broadcom.com> wrote: >>>>> >>>>> This patch series is the u-boot port from the recently accepted kernel >>>>> Broadcom HSSPI driver patch series here [1]. It includes the >>>>> accumulative updates and fixes for the driver from Broadcom. It also >>>>> added a new driver for the updated SPI controller found in the new >>>>> BCMBCA SoC. The device tree document is converted to yaml format and >>>>> updated accordingly. >>>>> >>>>> [1]: https://lore.kernel.org/all/20230207065826.285013-1-william.zhang@broadcom.com/ >>>>> >>>>> >>>>> Changes in v2: >>>>> - Add Álvaro Fernández Rojas as another maintainer >>>>> >>>>> William Zhang (9): >>>>> dt-bindings: spi: Add bcm63xx-hsspi controller support >>>>> ARM: dts: broadcom: bcmbca: Add spi controller node >>>>> arm64: dts: broadcom: bcmbca: Add spi controller node >>>>> spi: bcm63xx-hsspi: Enable SPI drivers by default >>>>> spi: bcm63xx-hsspi: Add new compatible string support >>>>> spi: bcm63xx-hsspi: Fix multi-bit mode setting >>>> >>>> This will fix for the upcoming release. >>>> >>>>> spi: bcm63xx-hsspi: Add prepend mode support >>>>> spi: bcmbca-hsspi: Add driver for newer HSSPI controller >>>>> MAINTAINERS: Add Broadcom Broadband SoC HS SPI drivers >>>> >>>> Patches send the patches related to SPI as separate series. >>>> >>>> Also please note that for arch patches, I have moved to tom since I'm >>>> unable to find the proper delate for bcmbca. >>>> >>> Thanks Jagan for the reviews. I will send out two patches series with >>> updates based on the reviews: one for SPI driver changes and another for >>> arch/dts/doc changes >>> >> There is one issue in separating the patches to SPI only changes and >> arch/dts changes. The new BCMBCA HSSPI driver depends on a new config >> HAVE_SPI_CS_CTRL that is added to arch/arm/mach-bcmbca/Kconfig >> in the arch change patch series. So you will get build error on generating >> the .config and have to pick that change to avoid that issue. Will that be >> okay? > > Frankly I'd rather the whole series just come in via Jagan's tree, or if > he's uncomfortable with that, I'll take the whole series if he's fine > with the SPI side. We don't need to worry about which sub-tree is used > so long as maintainers are happy with the contents, in U-Boot, imho. > Sounds good and thanks Tom! Let me send out the v3 of the whole series some time late today.