mbox series

[00/14] video: Drop old CFB code

Message ID 20220123140415.3091482-1-sjg@chromium.org
Headers show
Series video: Drop old CFB code | expand

Message

Simon Glass Jan. 23, 2022, 2:04 p.m. UTC
There is still quite a bit of cruft in the video subsystem. Mainly this is
users of the now-removed CONFIG_VIDEO, cfb_console and CONFIG_LCD.

This series removes most of the first two. The exception is videomodes.c
and its header, since these are used by sunxi. It looks like the code
could be removed, but I did not attempt it.

This is left for the sunxi maintainer.

The LCD clean-up can come later. Once done, we can rename CONFIG_DM_VIDEO
to CONFIG_VIDEO, thus completing the migration.


Simon Glass (14):
  video: Drop cfg_console
  video: nokia_rx51: Drop obsolete video code
  video: siemens: Drop unused video code
  video: nexell: Drop unused and invalid code
  video: Drop video_fb header
  video: Drop CONFIG_VIDEO_BMP_LOGO
  video: Drop references to CONFIG_VIDEO et al
  video: Clean up the uclass header
  video: Drop da8xx-fb
  video: fsl: colibri_vf: Drop FSL DCU driver
  video: Drop FSL DIU driver
  video: mxs: Drop old video code
  video: Convert CONFIG_VIDEO_BCM2835 to Kconfig
  video: Drop formike driver

 README                                        |   18 -
 arch/arm/cpu/armv7/ls102xa/soc.c              |    4 -
 arch/arm/include/asm/arch-ls102xa/config.h    |    1 -
 arch/arm/include/asm/mach-imx/mx5_video.h     |    5 -
 .../mach-nexell/include/mach/display_dev.h    |    7 +-
 board/aristainetos/aristainetos.c             |    1 -
 board/freescale/common/Makefile               |    4 -
 board/freescale/common/dcu_sii9022a.c         |  248 ---
 board/freescale/common/dcu_sii9022a.h         |   12 -
 board/freescale/common/diu_ch7301.c           |  217 --
 board/freescale/common/diu_ch7301.h           |   12 -
 board/freescale/ls1021aiot/Makefile           |    1 -
 board/freescale/ls1021aiot/dcu.c              |   48 -
 board/freescale/ls1021aqds/Makefile           |    1 -
 board/freescale/ls1021aqds/dcu.c              |  110 -
 board/freescale/ls1021atwr/Makefile           |    1 -
 board/freescale/ls1021atwr/dcu.c              |   48 -
 board/freescale/mx51evk/Makefile              |    1 -
 board/freescale/mx53loco/Makefile             |    1 -
 board/freescale/t104xrdb/Makefile             |    1 -
 board/freescale/t104xrdb/diu.c                |   84 -
 board/kosagi/novena/novena_spl.c              |   23 -
 board/nokia/rx51/rx51.c                       |   19 -
 board/siemens/common/board.c                  |    3 -
 board/siemens/common/factoryset.c             |    7 -
 board/siemens/common/factoryset.h             |    3 -
 board/siemens/pxm2/board.c                    |  189 --
 board/siemens/rut/board.c                     |  247 ---
 board/socrates/socrates.c                     |    1 -
 board/toradex/colibri_vf/Makefile             |    1 -
 board/toradex/colibri_vf/colibri_vf.c         |   62 -
 board/toradex/colibri_vf/dcu.c                |   38 -
 cmd/Kconfig                                   |    2 +-
 cmd/bdinfo.c                                  |    2 +-
 cmd/bmp.c                                     |    4 +-
 cmd/cls.c                                     |    2 -
 common/fdt_support.c                          |    2 +-
 common/stdio.c                                |    4 +-
 configs/colibri_vf_defconfig                  |    1 -
 configs/nokia_rx51_defconfig                  |    3 -
 configs/rpi_0_w_defconfig                     |    1 +
 configs/rpi_2_defconfig                       |    1 +
 configs/rpi_3_32b_defconfig                   |    1 +
 configs/rpi_3_b_plus_defconfig                |    1 +
 configs/rpi_3_defconfig                       |    1 +
 configs/rpi_4_32b_defconfig                   |    1 +
 configs/rpi_4_defconfig                       |    1 +
 configs/rpi_arm64_defconfig                   |    1 +
 configs/rpi_defconfig                         |    1 +
 doc/usage/bootmenu.rst                        |    5 -
 drivers/pci/pci_rom.c                         |    1 -
 drivers/video/Kconfig                         |  129 +-
 drivers/video/Makefile                        |    5 -
 drivers/video/cfb_console.c                   | 1865 -----------------
 drivers/video/da8xx-fb.c                      | 1048 ---------
 drivers/video/da8xx-fb.h                      |  115 -
 drivers/video/formike.c                       |  513 -----
 drivers/video/fsl_dcu_fb.c                    |  549 -----
 drivers/video/fsl_diu_fb.c                    |  416 ----
 drivers/video/imx/mxc_ipuv3_fb.c              |    1 -
 drivers/video/mxsfb.c                         |   90 -
 drivers/video/nexell_display.c                |   18 +-
 drivers/video/omap3_dss.c                     |   29 -
 drivers/video/sunxi/sunxi_display.c           |    1 -
 include/asm-generic/global_data.h             |    2 +-
 include/configs/T102xRDB.h                    |   13 -
 include/configs/T104xRDB.h                    |   20 -
 include/configs/apalis_imx6.h                 |    1 -
 include/configs/aristainetos2.h               |    1 -
 include/configs/cm_fx6.h                      |    2 -
 include/configs/colibri-imx6ull.h             |    1 -
 include/configs/colibri_imx6.h                |    1 -
 include/configs/colibri_imx7.h                |    4 -
 include/configs/colibri_vf.h                  |    8 -
 include/configs/embestmx6boards.h             |    1 -
 include/configs/gw_ventana.h                  |    1 -
 include/configs/imx6-engicam.h                |    2 -
 include/configs/imxrt1050-evk.h               |    2 -
 include/configs/ls1021aqds.h                  |   12 -
 include/configs/ls1021atwr.h                  |   15 -
 include/configs/mx6cuboxi.h                   |    1 -
 include/configs/mx6sabre_common.h             |    1 -
 include/configs/mx6sxsabresd.h                |    1 -
 include/configs/mx6ul_14x14_evk.h             |    1 -
 include/configs/mx7dsabresd.h                 |    4 -
 include/configs/nokia_rx51.h                  |   11 -
 include/configs/opos6uldev.h                  |    1 -
 include/configs/pico-imx6.h                   |    1 -
 include/configs/pico-imx6ul.h                 |    1 -
 include/configs/pico-imx7d.h                  |    4 -
 include/configs/pxm2.h                        |    8 -
 include/configs/rpi.h                         |    1 -
 include/configs/rut.h                         |   10 -
 include/configs/wandboard.h                   |    1 -
 include/fsl_dcu_fb.h                          |   22 -
 include/fsl_diu_fb.h                          |   14 -
 include/video.h                               |   84 +-
 include/video_fb.h                            |   91 -
 lib/efi_loader/Kconfig                        |    1 -
 scripts/config_whitelist.txt                  |   10 -
 100 files changed, 33 insertions(+), 6553 deletions(-)
 delete mode 100644 board/freescale/common/dcu_sii9022a.c
 delete mode 100644 board/freescale/common/dcu_sii9022a.h
 delete mode 100644 board/freescale/common/diu_ch7301.c
 delete mode 100644 board/freescale/common/diu_ch7301.h
 delete mode 100644 board/freescale/ls1021aiot/dcu.c
 delete mode 100644 board/freescale/ls1021aqds/dcu.c
 delete mode 100644 board/freescale/ls1021atwr/dcu.c
 delete mode 100644 board/freescale/t104xrdb/diu.c
 delete mode 100644 board/toradex/colibri_vf/dcu.c
 delete mode 100644 drivers/video/cfb_console.c
 delete mode 100644 drivers/video/da8xx-fb.c
 delete mode 100644 drivers/video/da8xx-fb.h
 delete mode 100644 drivers/video/formike.c
 delete mode 100644 drivers/video/fsl_dcu_fb.c
 delete mode 100644 drivers/video/fsl_diu_fb.c
 delete mode 100644 include/fsl_dcu_fb.h
 delete mode 100644 include/fsl_diu_fb.h
 delete mode 100644 include/video_fb.h

Comments

Simon Glass March 24, 2022, 7:54 p.m. UTC | #1
Hi Anatolij,

On Sun, 23 Jan 2022 at 07:04, Simon Glass <sjg@chromium.org> wrote:
>
> There is still quite a bit of cruft in the video subsystem. Mainly this is
> users of the now-removed CONFIG_VIDEO, cfb_console and CONFIG_LCD.
>
> This series removes most of the first two. The exception is videomodes.c
> and its header, since these are used by sunxi. It looks like the code
> could be removed, but I did not attempt it.
>
> This is left for the sunxi maintainer.
>
> The LCD clean-up can come later. Once done, we can rename CONFIG_DM_VIDEO
> to CONFIG_VIDEO, thus completing the migration.
>
>
> Simon Glass (14):
>   video: Drop cfg_console
>   video: nokia_rx51: Drop obsolete video code
>   video: siemens: Drop unused video code
>   video: nexell: Drop unused and invalid code
>   video: Drop video_fb header
>   video: Drop CONFIG_VIDEO_BMP_LOGO
>   video: Drop references to CONFIG_VIDEO et al
>   video: Clean up the uclass header
>   video: Drop da8xx-fb
>   video: fsl: colibri_vf: Drop FSL DCU driver
>   video: Drop FSL DIU driver
>   video: mxs: Drop old video code
>   video: Convert CONFIG_VIDEO_BCM2835 to Kconfig
>   video: Drop formike driver
>
>  README                                        |   18 -
>  arch/arm/cpu/armv7/ls102xa/soc.c              |    4 -
>  arch/arm/include/asm/arch-ls102xa/config.h    |    1 -
>  arch/arm/include/asm/mach-imx/mx5_video.h     |    5 -
>  .../mach-nexell/include/mach/display_dev.h    |    7 +-
>  board/aristainetos/aristainetos.c             |    1 -
>  board/freescale/common/Makefile               |    4 -
>  board/freescale/common/dcu_sii9022a.c         |  248 ---
>  board/freescale/common/dcu_sii9022a.h         |   12 -
>  board/freescale/common/diu_ch7301.c           |  217 --
>  board/freescale/common/diu_ch7301.h           |   12 -
>  board/freescale/ls1021aiot/Makefile           |    1 -
>  board/freescale/ls1021aiot/dcu.c              |   48 -
>  board/freescale/ls1021aqds/Makefile           |    1 -
>  board/freescale/ls1021aqds/dcu.c              |  110 -
>  board/freescale/ls1021atwr/Makefile           |    1 -
>  board/freescale/ls1021atwr/dcu.c              |   48 -
>  board/freescale/mx51evk/Makefile              |    1 -
>  board/freescale/mx53loco/Makefile             |    1 -
>  board/freescale/t104xrdb/Makefile             |    1 -
>  board/freescale/t104xrdb/diu.c                |   84 -
>  board/kosagi/novena/novena_spl.c              |   23 -
>  board/nokia/rx51/rx51.c                       |   19 -
>  board/siemens/common/board.c                  |    3 -
>  board/siemens/common/factoryset.c             |    7 -
>  board/siemens/common/factoryset.h             |    3 -
>  board/siemens/pxm2/board.c                    |  189 --
>  board/siemens/rut/board.c                     |  247 ---
>  board/socrates/socrates.c                     |    1 -
>  board/toradex/colibri_vf/Makefile             |    1 -
>  board/toradex/colibri_vf/colibri_vf.c         |   62 -
>  board/toradex/colibri_vf/dcu.c                |   38 -
>  cmd/Kconfig                                   |    2 +-
>  cmd/bdinfo.c                                  |    2 +-
>  cmd/bmp.c                                     |    4 +-
>  cmd/cls.c                                     |    2 -
>  common/fdt_support.c                          |    2 +-
>  common/stdio.c                                |    4 +-
>  configs/colibri_vf_defconfig                  |    1 -
>  configs/nokia_rx51_defconfig                  |    3 -
>  configs/rpi_0_w_defconfig                     |    1 +
>  configs/rpi_2_defconfig                       |    1 +
>  configs/rpi_3_32b_defconfig                   |    1 +
>  configs/rpi_3_b_plus_defconfig                |    1 +
>  configs/rpi_3_defconfig                       |    1 +
>  configs/rpi_4_32b_defconfig                   |    1 +
>  configs/rpi_4_defconfig                       |    1 +
>  configs/rpi_arm64_defconfig                   |    1 +
>  configs/rpi_defconfig                         |    1 +
>  doc/usage/bootmenu.rst                        |    5 -
>  drivers/pci/pci_rom.c                         |    1 -
>  drivers/video/Kconfig                         |  129 +-
>  drivers/video/Makefile                        |    5 -
>  drivers/video/cfb_console.c                   | 1865 -----------------
>  drivers/video/da8xx-fb.c                      | 1048 ---------
>  drivers/video/da8xx-fb.h                      |  115 -
>  drivers/video/formike.c                       |  513 -----
>  drivers/video/fsl_dcu_fb.c                    |  549 -----
>  drivers/video/fsl_diu_fb.c                    |  416 ----
>  drivers/video/imx/mxc_ipuv3_fb.c              |    1 -
>  drivers/video/mxsfb.c                         |   90 -
>  drivers/video/nexell_display.c                |   18 +-
>  drivers/video/omap3_dss.c                     |   29 -
>  drivers/video/sunxi/sunxi_display.c           |    1 -
>  include/asm-generic/global_data.h             |    2 +-
>  include/configs/T102xRDB.h                    |   13 -
>  include/configs/T104xRDB.h                    |   20 -
>  include/configs/apalis_imx6.h                 |    1 -
>  include/configs/aristainetos2.h               |    1 -
>  include/configs/cm_fx6.h                      |    2 -
>  include/configs/colibri-imx6ull.h             |    1 -
>  include/configs/colibri_imx6.h                |    1 -
>  include/configs/colibri_imx7.h                |    4 -
>  include/configs/colibri_vf.h                  |    8 -
>  include/configs/embestmx6boards.h             |    1 -
>  include/configs/gw_ventana.h                  |    1 -
>  include/configs/imx6-engicam.h                |    2 -
>  include/configs/imxrt1050-evk.h               |    2 -
>  include/configs/ls1021aqds.h                  |   12 -
>  include/configs/ls1021atwr.h                  |   15 -
>  include/configs/mx6cuboxi.h                   |    1 -
>  include/configs/mx6sabre_common.h             |    1 -
>  include/configs/mx6sxsabresd.h                |    1 -
>  include/configs/mx6ul_14x14_evk.h             |    1 -
>  include/configs/mx7dsabresd.h                 |    4 -
>  include/configs/nokia_rx51.h                  |   11 -
>  include/configs/opos6uldev.h                  |    1 -
>  include/configs/pico-imx6.h                   |    1 -
>  include/configs/pico-imx6ul.h                 |    1 -
>  include/configs/pico-imx7d.h                  |    4 -
>  include/configs/pxm2.h                        |    8 -
>  include/configs/rpi.h                         |    1 -
>  include/configs/rut.h                         |   10 -
>  include/configs/wandboard.h                   |    1 -
>  include/fsl_dcu_fb.h                          |   22 -
>  include/fsl_diu_fb.h                          |   14 -
>  include/video.h                               |   84 +-
>  include/video_fb.h                            |   91 -
>  lib/efi_loader/Kconfig                        |    1 -
>  scripts/config_whitelist.txt                  |   10 -
>  100 files changed, 33 insertions(+), 6553 deletions(-)
>  delete mode 100644 board/freescale/common/dcu_sii9022a.c
>  delete mode 100644 board/freescale/common/dcu_sii9022a.h
>  delete mode 100644 board/freescale/common/diu_ch7301.c
>  delete mode 100644 board/freescale/common/diu_ch7301.h
>  delete mode 100644 board/freescale/ls1021aiot/dcu.c
>  delete mode 100644 board/freescale/ls1021aqds/dcu.c
>  delete mode 100644 board/freescale/ls1021atwr/dcu.c
>  delete mode 100644 board/freescale/t104xrdb/diu.c
>  delete mode 100644 board/toradex/colibri_vf/dcu.c
>  delete mode 100644 drivers/video/cfb_console.c
>  delete mode 100644 drivers/video/da8xx-fb.c
>  delete mode 100644 drivers/video/da8xx-fb.h
>  delete mode 100644 drivers/video/formike.c
>  delete mode 100644 drivers/video/fsl_dcu_fb.c
>  delete mode 100644 drivers/video/fsl_diu_fb.c
>  delete mode 100644 include/fsl_dcu_fb.h
>  delete mode 100644 include/fsl_diu_fb.h
>  delete mode 100644 include/video_fb.h
>
> --
> 2.35.0.rc0.227.g00780c9af4-goog
>

Is there any word on this series, please?

Regards,
Simon
Pali Rohár March 24, 2022, 7:56 p.m. UTC | #2
On Thursday 24 March 2022 13:54:22 Simon Glass wrote:
> Hi Anatolij,
> 
> On Sun, 23 Jan 2022 at 07:04, Simon Glass <sjg@chromium.org> wrote:
> >
> > There is still quite a bit of cruft in the video subsystem. Mainly this is
> > users of the now-removed CONFIG_VIDEO, cfb_console and CONFIG_LCD.
> >
> > This series removes most of the first two. The exception is videomodes.c
> > and its header, since these are used by sunxi. It looks like the code
> > could be removed, but I did not attempt it.
> >
> > This is left for the sunxi maintainer.
> >
> > The LCD clean-up can come later. Once done, we can rename CONFIG_DM_VIDEO
> > to CONFIG_VIDEO, thus completing the migration.
> >
> >
> > Simon Glass (14):
> >   video: Drop cfg_console
> >   video: nokia_rx51: Drop obsolete video code
...
> 
> Is there any word on this series, please?

Nokia board code does not use this cfb_console anymore... Or it is still
affected?
Simon Glass March 24, 2022, 8:05 p.m. UTC | #3
Hi Pali,

On Thu, 24 Mar 2022 at 13:56, Pali Rohár <pali@kernel.org> wrote:
>
> On Thursday 24 March 2022 13:54:22 Simon Glass wrote:
> > Hi Anatolij,
> >
> > On Sun, 23 Jan 2022 at 07:04, Simon Glass <sjg@chromium.org> wrote:
> > >
> > > There is still quite a bit of cruft in the video subsystem. Mainly this is
> > > users of the now-removed CONFIG_VIDEO, cfb_console and CONFIG_LCD.
> > >
> > > This series removes most of the first two. The exception is videomodes.c
> > > and its header, since these are used by sunxi. It looks like the code
> > > could be removed, but I did not attempt it.
> > >
> > > This is left for the sunxi maintainer.
> > >
> > > The LCD clean-up can come later. Once done, we can rename CONFIG_DM_VIDEO
> > > to CONFIG_VIDEO, thus completing the migration.
> > >
> > >
> > > Simon Glass (14):
> > >   video: Drop cfg_console
> > >   video: nokia_rx51: Drop obsolete video code
> ...
> >
> > Is there any word on this series, please?
>
> Nokia board code does not use this cfb_console anymore... Or it is still
> affected?

It should not be affected. Maybe this patch can be dropped?

Regards,
Simon
Anatolij Gustschin March 24, 2022, 10:16 p.m. UTC | #4
Hi Simon,

On Thu, 24 Mar 2022 13:54:22 -0600
Simon Glass sjg@chromium.org wrote:
...
> 
> Is there any word on this series, please?

last week I've rebased and applied this series to next (PATCH 02/14
dropped) and will submit a pull request when Tom merges last -rc
into his next branch. Otherwise there will be a build error due to
missing Nokia RX-51 related changes. Thanks!

--
Anatolij
Simon Glass March 24, 2022, 10:41 p.m. UTC | #5
Hi Anatloij,

On Fri, 25 Mar 2022 at 11:16, Anatolij Gustschin <agust@denx.de> wrote:
>
> Hi Simon,
>
> On Thu, 24 Mar 2022 13:54:22 -0600
> Simon Glass sjg@chromium.org wrote:
> ...
> >
> > Is there any word on this series, please?
>
> last week I've rebased and applied this series to next (PATCH 02/14
> dropped) and will submit a pull request when Tom merges last -rc
> into his next branch. Otherwise there will be a build error due to
> missing Nokia RX-51 related changes. Thanks!

That's great, thank you! I was thinking of doing the same thing for
LCD. What do you think?

Regards,
Simon
Anatolij Gustschin March 28, 2022, 7:50 a.m. UTC | #6
Hi Simon,

On Fri, 25 Mar 2022 11:41:54 +1300
Simon Glass sjg@chromium.org wrote:

> Hi Anatloij,
> 
> On Fri, 25 Mar 2022 at 11:16, Anatolij Gustschin <agust@denx.de> wrote:
> >
> > Hi Simon,
> >
> > On Thu, 24 Mar 2022 13:54:22 -0600
> > Simon Glass sjg@chromium.org wrote:
> > ...  
> > >
> > > Is there any word on this series, please?  
> >
> > last week I've rebased and applied this series to next (PATCH 02/14
> > dropped) and will submit a pull request when Tom merges last -rc
> > into his next branch. Otherwise there will be a build error due to
> > missing Nokia RX-51 related changes. Thanks!  
> 
> That's great, thank you! I was thinking of doing the same thing for
> LCD. What do you think?

Yes, removing CONFIG_LCD code would be good. I hope we can do
frame buffer support by DM_VIDEO for boards still using LCD.

--
Anatolij
Anatolij Gustschin March 29, 2022, 6:37 a.m. UTC | #7
On Sun, 23 Jan 2022 07:04:01 -0700
Simon Glass sjg@chromium.org wrote:
...
> Simon Glass (14):
>   video: Drop cfg_console
>   video: nokia_rx51: Drop obsolete video code
>   video: siemens: Drop unused video code
>   video: nexell: Drop unused and invalid code
>   video: Drop video_fb header
>   video: Drop CONFIG_VIDEO_BMP_LOGO
>   video: Drop references to CONFIG_VIDEO et al
>   video: Clean up the uclass header
>   video: Drop da8xx-fb
>   video: fsl: colibri_vf: Drop FSL DCU driver
>   video: Drop FSL DIU driver
>   video: mxs: Drop old video code
>   video: Convert CONFIG_VIDEO_BCM2835 to Kconfig
>   video: Drop formike driver

Re-based and applied to u-boot-video/next, thanks!

--
Anatolij