mbox series

[v3,0/3] Add SPL build support for RK3568

Message ID 20211026024221.5208-1-nico.cheng@rock-chips.com
Headers show
Series Add SPL build support for RK3568 | expand

Message

nico.cheng@rock-chips.com Oct. 26, 2021, 2:42 a.m. UTC
This series adds support for the rk3568 SOC, SPL load next-stage image from
eMMC will be supported after this series of patches.

Changes in v3:
Replace configuration parameters of SGRF_SOC_CON4 with macro
definitions.

Changes in v2:
We use the rk_clrreg function instead of the writel to set eMMC sdmmc0 to
secure.
Modify comments to make them more explicit.

Nico Cheng (3):
  rockchip: Kconfig: Enable SPL support for rk3568
  arm: dts: rockchip: rk3568: Enable sdhci and sdmmc0 node
  rockchip: rk3568: add arch_cpu_init()

 arch/arm/dts/rk3568-u-boot.dtsi        | 17 ++++++++++++++++
 arch/arm/mach-rockchip/Kconfig         |  2 ++
 arch/arm/mach-rockchip/rk3568/rk3568.c | 27 +++++++++++++++++++++++---
 configs/evb-rk3568_defconfig           | 25 +++++++++++++++++++++++-
 include/configs/rk3568_common.h        |  4 ++++
 5 files changed, 71 insertions(+), 4 deletions(-)

Comments

Peter Robinson Oct. 26, 2021, 8:09 a.m. UTC | #1
Hi Nico,

Is this expected to work with Arm Trusted Firmware or some other TF?

Could we have some docs/details for how to test this?

Peter

> This series adds support for the rk3568 SOC, SPL load next-stage image from
> eMMC will be supported after this series of patches.
>
> Changes in v3:
> Replace configuration parameters of SGRF_SOC_CON4 with macro
> definitions.
>
> Changes in v2:
> We use the rk_clrreg function instead of the writel to set eMMC sdmmc0 to
> secure.
> Modify comments to make them more explicit.
>
> Nico Cheng (3):
>   rockchip: Kconfig: Enable SPL support for rk3568
>   arm: dts: rockchip: rk3568: Enable sdhci and sdmmc0 node
>   rockchip: rk3568: add arch_cpu_init()
>
>  arch/arm/dts/rk3568-u-boot.dtsi        | 17 ++++++++++++++++
>  arch/arm/mach-rockchip/Kconfig         |  2 ++
>  arch/arm/mach-rockchip/rk3568/rk3568.c | 27 +++++++++++++++++++++++---
>  configs/evb-rk3568_defconfig           | 25 +++++++++++++++++++++++-
>  include/configs/rk3568_common.h        |  4 ++++
>  5 files changed, 71 insertions(+), 4 deletions(-)
>
> --
> 2.17.1
>
>
>
nico.cheng@rock-chips.com Oct. 26, 2021, 11:24 a.m. UTC | #2
Hi Peter,

The scripts that package the ATF and other components are subject to further updates to the patch, which is not currently available in the submitted patch.

Nico

--------------



nico.cheng@rock-chips.com



>Hi Nico,



>



>Is this expected to work with Arm Trusted Firmware or some other TF?



>



>Could we have some docs/details for how to test this?



>



>Peter



>



>> This series adds support for the rk3568 SOC, SPL load next-stage image from



>> eMMC will be supported after this series of patches.



>>



>> Changes in v3:



>> Replace configuration parameters of SGRF_SOC_CON4 with macro



>> definitions.



>>



>> Changes in v2:



>> We use the rk_clrreg function instead of the writel to set eMMC sdmmc0 to



>> secure.



>> Modify comments to make them more explicit.



>>



>> Nico Cheng (3):



>>   rockchip: Kconfig: Enable SPL support for rk3568



>>   arm: dts: rockchip: rk3568: Enable sdhci and sdmmc0 node



>>   rockchip: rk3568: add arch_cpu_init()



>>



>>  arch/arm/dts/rk3568-u-boot.dtsi        | 17 ++++++++++++++++



>>  arch/arm/mach-rockchip/Kconfig         |  2 ++



>>  arch/arm/mach-rockchip/rk3568/rk3568.c | 27 +++++++++++++++++++++++---



>>  configs/evb-rk3568_defconfig           | 25 +++++++++++++++++++++++-



>>  include/configs/rk3568_common.h        |  4 ++++



>>  5 files changed, 71 insertions(+), 4 deletions(-)



>>



>> --



>> 2.17.1



>>



>>



>>



>



>
Kever Yang Oct. 26, 2021, 1:20 p.m. UTC | #3
Hi Peter,

     This add SPL support for RK3568, and the ATF support is a function 
support int the ATF in rockchip platform, so if this chip works, them it 
will of course support ATF like other rockchip SoCs.

Thanks,

- Kever

On 2021/10/26 下午4:09, Peter Robinson wrote:
> Hi Nico,
>
> Is this expected to work with Arm Trusted Firmware or some other TF?
>
> Could we have some docs/details for how to test this?
>
> Peter
>
>> This series adds support for the rk3568 SOC, SPL load next-stage image from
>> eMMC will be supported after this series of patches.
>>
>> Changes in v3:
>> Replace configuration parameters of SGRF_SOC_CON4 with macro
>> definitions.
>>
>> Changes in v2:
>> We use the rk_clrreg function instead of the writel to set eMMC sdmmc0 to
>> secure.
>> Modify comments to make them more explicit.
>>
>> Nico Cheng (3):
>>    rockchip: Kconfig: Enable SPL support for rk3568
>>    arm: dts: rockchip: rk3568: Enable sdhci and sdmmc0 node
>>    rockchip: rk3568: add arch_cpu_init()
>>
>>   arch/arm/dts/rk3568-u-boot.dtsi        | 17 ++++++++++++++++
>>   arch/arm/mach-rockchip/Kconfig         |  2 ++
>>   arch/arm/mach-rockchip/rk3568/rk3568.c | 27 +++++++++++++++++++++++---
>>   configs/evb-rk3568_defconfig           | 25 +++++++++++++++++++++++-
>>   include/configs/rk3568_common.h        |  4 ++++
>>   5 files changed, 71 insertions(+), 4 deletions(-)
>>
>> --
>> 2.17.1
>>
>>
>>
>