mbox series

[U-Boot,v2,0/5] Add initial support for Pine64 Rock64 board

Message ID 20190519121020.13866-1-matwey.kornilov@gmail.com
Headers show
Series Add initial support for Pine64 Rock64 board | expand

Message

Matwey V. Kornilov May 19, 2019, 12:10 p.m. UTC
This series adds initial basic support for Pine64 Rock64 board.

The ROCK64 is a credit card size SBC based on Rockchip RK3328 Quad-Core ARM Cortex A53.

This series allow building u-boot SPL and u-boot.itb for Rock64 board.
Unfortunately, proprietary TPL is stil required for deploy:

./tools/mkimage -n rk3328 -T rksd -d ./rkbin/bin/rk33/rk3328_ddr_333MHz_v1.14.bin idbloader.img
cat ./spl/u-boot-spl.bin >> idbloader.img
dd if=idbloader.img of=/dev/sdcard seek=64 conv=notrunc
dd if=u-boot.itb of=/dev/sdcard seek=16384 conv=notrunc

The series has been tested with ATF v1.6.

Some patches in the series are taken from https://github.com/rockchip-linux/u-boot
Credits are given in each patch separately.

Changes since v1:
  - reword messages for commit 2,4,5
  - set SPL_REVERVE_IRAM to 0x40000
  - add spl-boot-order to rk3328-rock64-u-boot.dtsi

Kever Yang (3):
  rockchip: rk3328: add SPL board file support
  rockchip: rk3328: add SPL support
  rockchip: Kconfig: enable SPL support for rk3328

Matwey V. Kornilov (2):
  rockchip: dts: rk3328: add rk3328-rock64.dts
  rockchip: rk3328: add rock64-rk3328_defconfig

 arch/arm/dts/Makefile                     |   3 +-
 arch/arm/dts/rk3328-rock64-u-boot.dtsi    |  34 ++++
 arch/arm/dts/rk3328-rock64.dts            | 294 ++++++++++++++++++++++++++++++
 arch/arm/mach-rockchip/Kconfig            |   7 +
 arch/arm/mach-rockchip/Makefile           |   1 +
 arch/arm/mach-rockchip/rk3328-board-spl.c |  59 ++++++
 configs/rock64-rk3328_defconfig           |  91 +++++++++
 include/configs/rk3328_common.h           |   4 +
 8 files changed, 492 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/rk3328-rock64-u-boot.dtsi
 create mode 100644 arch/arm/dts/rk3328-rock64.dts
 create mode 100644 arch/arm/mach-rockchip/rk3328-board-spl.c
 create mode 100644 configs/rock64-rk3328_defconfig

Comments

Kever Yang May 30, 2019, 1:23 a.m. UTC | #1
Hi Matwey,

    Recommend to use patman(tools/patman) to send to patch set,

so that it's easy to add change log for each version on each patch,

and don't forget to add review tag if you didn't change anything fot

the patch, eg. review tag from Simon on patch 3.


Thanks,
- Kever
On 05/19/2019 08:10 PM, Matwey V. Kornilov wrote:
> This series adds initial basic support for Pine64 Rock64 board.
>
> The ROCK64 is a credit card size SBC based on Rockchip RK3328 Quad-Core ARM Cortex A53.
>
> This series allow building u-boot SPL and u-boot.itb for Rock64 board.
> Unfortunately, proprietary TPL is stil required for deploy:
>
> ./tools/mkimage -n rk3328 -T rksd -d ./rkbin/bin/rk33/rk3328_ddr_333MHz_v1.14.bin idbloader.img
> cat ./spl/u-boot-spl.bin >> idbloader.img
> dd if=idbloader.img of=/dev/sdcard seek=64 conv=notrunc
> dd if=u-boot.itb of=/dev/sdcard seek=16384 conv=notrunc
>
> The series has been tested with ATF v1.6.
>
> Some patches in the series are taken from https://github.com/rockchip-linux/u-boot
> Credits are given in each patch separately.
>
> Changes since v1:
>   - reword messages for commit 2,4,5
>   - set SPL_REVERVE_IRAM to 0x40000
>   - add spl-boot-order to rk3328-rock64-u-boot.dtsi
>
> Kever Yang (3):
>   rockchip: rk3328: add SPL board file support
>   rockchip: rk3328: add SPL support
>   rockchip: Kconfig: enable SPL support for rk3328
>
> Matwey V. Kornilov (2):
>   rockchip: dts: rk3328: add rk3328-rock64.dts
>   rockchip: rk3328: add rock64-rk3328_defconfig
>
>  arch/arm/dts/Makefile                     |   3 +-
>  arch/arm/dts/rk3328-rock64-u-boot.dtsi    |  34 ++++
>  arch/arm/dts/rk3328-rock64.dts            | 294 ++++++++++++++++++++++++++++++
>  arch/arm/mach-rockchip/Kconfig            |   7 +
>  arch/arm/mach-rockchip/Makefile           |   1 +
>  arch/arm/mach-rockchip/rk3328-board-spl.c |  59 ++++++
>  configs/rock64-rk3328_defconfig           |  91 +++++++++
>  include/configs/rk3328_common.h           |   4 +
>  8 files changed, 492 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/dts/rk3328-rock64-u-boot.dtsi
>  create mode 100644 arch/arm/dts/rk3328-rock64.dts
>  create mode 100644 arch/arm/mach-rockchip/rk3328-board-spl.c
>  create mode 100644 configs/rock64-rk3328_defconfig
>
Kever Yang May 31, 2019, 12:37 a.m. UTC | #2
Hi Matwey,

    This patch set broken the spl build for evb-rk3328, see:

https://travis-ci.org/keveryang/u-boot/jobs/539154859


    Please try buildman/buildman rockchip or pass the Travis build for
U-Boot for your patches.

Thanks,
- Kever
On 05/19/2019 08:10 PM, Matwey V. Kornilov wrote:
> This series adds initial basic support for Pine64 Rock64 board.
>
> The ROCK64 is a credit card size SBC based on Rockchip RK3328 Quad-Core ARM Cortex A53.
>
> This series allow building u-boot SPL and u-boot.itb for Rock64 board.
> Unfortunately, proprietary TPL is stil required for deploy:
>
> ./tools/mkimage -n rk3328 -T rksd -d ./rkbin/bin/rk33/rk3328_ddr_333MHz_v1.14.bin idbloader.img
> cat ./spl/u-boot-spl.bin >> idbloader.img
> dd if=idbloader.img of=/dev/sdcard seek=64 conv=notrunc
> dd if=u-boot.itb of=/dev/sdcard seek=16384 conv=notrunc
>
> The series has been tested with ATF v1.6.
>
> Some patches in the series are taken from https://github.com/rockchip-linux/u-boot
> Credits are given in each patch separately.
>
> Changes since v1:
>   - reword messages for commit 2,4,5
>   - set SPL_REVERVE_IRAM to 0x40000
>   - add spl-boot-order to rk3328-rock64-u-boot.dtsi
>
> Kever Yang (3):
>   rockchip: rk3328: add SPL board file support
>   rockchip: rk3328: add SPL support
>   rockchip: Kconfig: enable SPL support for rk3328
>
> Matwey V. Kornilov (2):
>   rockchip: dts: rk3328: add rk3328-rock64.dts
>   rockchip: rk3328: add rock64-rk3328_defconfig
>
>  arch/arm/dts/Makefile                     |   3 +-
>  arch/arm/dts/rk3328-rock64-u-boot.dtsi    |  34 ++++
>  arch/arm/dts/rk3328-rock64.dts            | 294 ++++++++++++++++++++++++++++++
>  arch/arm/mach-rockchip/Kconfig            |   7 +
>  arch/arm/mach-rockchip/Makefile           |   1 +
>  arch/arm/mach-rockchip/rk3328-board-spl.c |  59 ++++++
>  configs/rock64-rk3328_defconfig           |  91 +++++++++
>  include/configs/rk3328_common.h           |   4 +
>  8 files changed, 492 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/dts/rk3328-rock64-u-boot.dtsi
>  create mode 100644 arch/arm/dts/rk3328-rock64.dts
>  create mode 100644 arch/arm/mach-rockchip/rk3328-board-spl.c
>  create mode 100644 configs/rock64-rk3328_defconfig
>