[U-Boot,v2,0/2] Add 'bcb' command to read/modify/writeAndroid BCB

The motivation behind the 'bcb' command is largely explained
in the second patch. The other patch performs polishing of
https://patchwork.ozlabs.org/patch/1099689/, which is a hard
prerequisite for this series.

v2:
 - [Heinrich Schuchardt] Implement sub-commands via U_BOOT_CMD_MKENT.
 - Polished the code. Ensured no warnings returned by sparse, smatch,
   `cppcheck --force --enable=all --inconclusive`, make W=1.
 - Tested on R-Car-H3-ES20 ULCB-KF.

v1:
 - https://patchwork.ozlabs.org/cover/1080393/

Eugeniu Rosca (2):
  include: android_bootloader_message.h: Minimize the diff to AOSP
  cmd: Add 'bcb' command to read/modify/write BCB fields

 cmd/Kconfig                          |  17 ++
 cmd/Makefile                         |   1 +
 cmd/bcb.c                            | 330 +++++++++++++++++++++++++++
 include/android_bootloader_message.h | 126 +++++-----
 4 files changed, 416 insertions(+), 58 deletions(-)
 create mode 100644 cmd/bcb.c

Hi All,

cc: Stephen, Jeremy

FWIW/jFYI, the patchwork frontend appears to mangle/skip spaces
in the patch subjects. Examples:
 - https://patchwork.ozlabs.org/cover/1101106/
 - https://patchwork.ozlabs.org/patch/1101108/
 - https://patchwork.ozlabs.org/patch/1101107/

The same patches look fine on https://marc.info:
 - https://marc.info/?l=u-boot&m=155810440206070&w=2
 - https://marc.info/?l=u-boot&m=155810448306089&w=2
 - https://marc.info/?l=u-boot&m=155810444306080&w=2

On Fri, 2019-05-17 at 17:24 +0200, Eugeniu Rosca wrote:
> Hi All,
> 
> cc: Stephen, Jeremy
> 
> FWIW/jFYI, the patchwork frontend appears to mangle/skip spaces
> in the patch subjects. Examples:
>  - https://patchwork.ozlabs.org/cover/1101106/
>  - https://patchwork.ozlabs.org/patch/1101108/
>  - https://patchwork.ozlabs.org/patch/1101107/
> 
> The same patches look fine on https://marc.info:
>  - https://marc.info/?l=u-boot&m=155810440206070&w=2
>  - https://marc.info/?l=u-boot&m=155810448306089&w=2
>  - https://marc.info/?l=u-boot&m=155810444306080&w=2
> 

http://patchwork.ozlabs.org/patch/1099264/

We're just waiting for ozlabs to apply that patch.

Stephen

Superseded by https://patchwork.ozlabs.org/cover/1104242/
("[U-Boot,v3,0/3] Add 'bcb' command to read/modify/write Android BCB")

Hello Stephen,

On Fri, May 17, 2019 at 05:28:25PM +0200, Eugeniu Rosca wrote:
> On Fri, May 17, 2019 at 04:26:23PM +0100, Stephen Finucane wrote:
> [..]
> > http://patchwork.ozlabs.org/patch/1099264/
> > 
> > We're just waiting for ozlabs to apply that patch.
> > 
> > Stephen
> 
> Thanks!

jFYI/FWIW, a recent patch series no longer suffers from this problem:
https://patchwork.ozlabs.org/cover/1104242/
("[U-Boot,v3,0/3] Add 'bcb' command to read/modify/write Android BCB")

However, the old series still exhibits the issue, as if the old series
is rendered by the old patchwork version:
https://patchwork.ozlabs.org/cover/1101106/
("[U-Boot,v2,0/2] Add 'bcb' command to read/modify/write Android BCB")

Hi Eugeniu,

> jFYI/FWIW, a recent patch series no longer suffers from this problem:
> https://patchwork.ozlabs.org/cover/1104242/
> ("[U-Boot,v3,0/3] Add 'bcb' command to read/modify/write Android BCB")

OK, super. I'd applied the fix for that issue on patchwork.ozlabs.org 
last week.

> However, the old series still exhibits the issue, as if the old series
> is rendered by the old patchwork version:
> https://patchwork.ozlabs.org/cover/1101106/
> ("[U-Boot,v2,0/2] Add 'bcb' command to read/modify/write Android BCB")

The issue was with the parser. Since the patch was parsed before the fix 
was applied, it'll remain like that.

Cheers,


Jeremy

Hi Jeremy,

On Sat, May 25, 2019 at 07:37:06AM +0800, Jeremy Kerr wrote:
> Hi Eugeniu,
> 
> >jFYI/FWIW, a recent patch series no longer suffers from this problem:
> >https://patchwork.ozlabs.org/cover/1104242/
> >("[U-Boot,v3,0/3] Add 'bcb' command to read/modify/write Android BCB")
> 
> OK, super. I'd applied the fix for that issue on patchwork.ozlabs.org last
> week.

Awesome. Thanks!

> >However, the old series still exhibits the issue, as if the old series
> >is rendered by the old patchwork version:
> >https://patchwork.ozlabs.org/cover/1101106/
> >("[U-Boot,v2,0/2] Add 'bcb' command to read/modify/write Android BCB")
> 
> The issue was with the parser. Since the patch was parsed before the fix was
> applied, it'll remain like that.

Good to know :)