| Message ID | 20180720071401.12952-1-jagan@amarulasolutions.com |
|---|---|
| Headers | show |
| Series | musb-new: Improve shutdown code | expand |
On 07/20/2018 09:13 AM, Jagan Teki wrote: > This is v2 for previous series[1], by excluding sunxi phy changes. > > One patch mark it as 'RFC' about "including UCLASS_USB_DEV_GENERIC > into shutdown caller" so expecting some inputs on the same > > [1] https://patchwork.ozlabs.org/cover/941588/ > > Jagan Teki (6): > usb: musb-new: Fix improper musb host pointer > usb: musb-new: sunxi: Allocate struct phy in private > dm: usb: Add UCLASS_USB_DEV_GENERIC shutdown > musb-new: sunxi: Access ahb_reset0_cfg via ccm offset > usb: musb-new: sunxi: Add proper musb exit support > usb: musb-new: Call musb_platform_exit from musb_stop > > board/compulab/cm_t3517/cm_t3517.c | 4 +- > drivers/usb/host/usb-uclass.c | 43 ++++++++++++ > drivers/usb/musb-new/musb_core.c | 1 + > drivers/usb/musb-new/musb_uboot.c | 12 ++-- > drivers/usb/musb-new/pic32.c | 6 +- > drivers/usb/musb-new/sunxi.c | 107 ++++++++++++++++++----------- > include/linux/usb/musb.h | 4 +- > 7 files changed, 123 insertions(+), 54 deletions(-) > +CC Vasily, I want his AB/TB on this. Please keep him CCed on those USB patches.
On Fri, Jul 20, 2018 at 3:13 PM, Jagan Teki <jagan@amarulasolutions.com> wrote: > This is v2 for previous series[1], by excluding sunxi phy changes. > > One patch mark it as 'RFC' about "including UCLASS_USB_DEV_GENERIC > into shutdown caller" so expecting some inputs on the same > > [1] https://patchwork.ozlabs.org/cover/941588/ > > Jagan Teki (6): > usb: musb-new: Fix improper musb host pointer > usb: musb-new: sunxi: Allocate struct phy in private > dm: usb: Add UCLASS_USB_DEV_GENERIC shutdown > musb-new: sunxi: Access ahb_reset0_cfg via ccm offset > usb: musb-new: sunxi: Add proper musb exit support > usb: musb-new: Call musb_platform_exit from musb_stop > > board/compulab/cm_t3517/cm_t3517.c | 4 +- > drivers/usb/host/usb-uclass.c | 43 ++++++++++++ > drivers/usb/musb-new/musb_core.c | 1 + > drivers/usb/musb-new/musb_uboot.c | 12 ++-- > drivers/usb/musb-new/pic32.c | 6 +- > drivers/usb/musb-new/sunxi.c | 107 ++++++++++++++++++----------- > include/linux/usb/musb.h | 4 +- > 7 files changed, 123 insertions(+), 54 deletions(-) > > -- > 2.17.1 > Tested-by: Chen-Yu Tsai <wens@csie.org> on A33-OlinuXino. This fixes the abort when starting the boot sequence.
On Mon, Aug 13, 2018 at 4:33 PM, Chen-Yu Tsai <wens@csie.org> wrote: > On Fri, Jul 20, 2018 at 3:13 PM, Jagan Teki <jagan@amarulasolutions.com> wrote: >> This is v2 for previous series[1], by excluding sunxi phy changes. >> >> One patch mark it as 'RFC' about "including UCLASS_USB_DEV_GENERIC >> into shutdown caller" so expecting some inputs on the same >> >> [1] https://patchwork.ozlabs.org/cover/941588/ >> >> Jagan Teki (6): >> usb: musb-new: Fix improper musb host pointer >> usb: musb-new: sunxi: Allocate struct phy in private >> dm: usb: Add UCLASS_USB_DEV_GENERIC shutdown >> musb-new: sunxi: Access ahb_reset0_cfg via ccm offset >> usb: musb-new: sunxi: Add proper musb exit support >> usb: musb-new: Call musb_platform_exit from musb_stop >> >> board/compulab/cm_t3517/cm_t3517.c | 4 +- >> drivers/usb/host/usb-uclass.c | 43 ++++++++++++ >> drivers/usb/musb-new/musb_core.c | 1 + >> drivers/usb/musb-new/musb_uboot.c | 12 ++-- >> drivers/usb/musb-new/pic32.c | 6 +- >> drivers/usb/musb-new/sunxi.c | 107 ++++++++++++++++++----------- >> include/linux/usb/musb.h | 4 +- >> 7 files changed, 123 insertions(+), 54 deletions(-) >> >> -- >> 2.17.1 >> > > Tested-by: Chen-Yu Tsai <wens@csie.org> > > on A33-OlinuXino. This fixes the abort when starting the boot sequence. Does it fixes w/o 3/6? because it an RFC and still in discussion
On Fri, Jul 20, 2018 at 12:43 PM, Jagan Teki <jagan@amarulasolutions.com> wrote: > This is v2 for previous series[1], by excluding sunxi phy changes. > > One patch mark it as 'RFC' about "including UCLASS_USB_DEV_GENERIC > into shutdown caller" so expecting some inputs on the same > > [1] https://patchwork.ozlabs.org/cover/941588/ > > Jagan Teki (6): > usb: musb-new: Fix improper musb host pointer > usb: musb-new: sunxi: Allocate struct phy in private > dm: usb: Add UCLASS_USB_DEV_GENERIC shutdown > musb-new: sunxi: Access ahb_reset0_cfg via ccm offset > usb: musb-new: sunxi: Add proper musb exit support > usb: musb-new: Call musb_platform_exit from musb_stop I'm planning to apply by excluding RFC patch, let me know if anyone has any inputs. Jagan.
On Tue, Aug 21, 2018 at 9:04 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > On Fri, Jul 20, 2018 at 12:43 PM, Jagan Teki <jagan@amarulasolutions.com> wrote: > > This is v2 for previous series[1], by excluding sunxi phy changes. > > > > One patch mark it as 'RFC' about "including UCLASS_USB_DEV_GENERIC > > into shutdown caller" so expecting some inputs on the same > > > > [1] https://patchwork.ozlabs.org/cover/941588/ > > > > Jagan Teki (6): > > usb: musb-new: Fix improper musb host pointer > > usb: musb-new: sunxi: Allocate struct phy in private > > dm: usb: Add UCLASS_USB_DEV_GENERIC shutdown > > musb-new: sunxi: Access ahb_reset0_cfg via ccm offset > > usb: musb-new: sunxi: Add proper musb exit support > > usb: musb-new: Call musb_platform_exit from musb_stop > > I'm planning to apply by excluding RFC patch, let me know if anyone > has any inputs. Boots cleanly without the RFC patch on the Bananapi M2 Magic, with musb-new built in both host and gadget mode. Curiously, both modes can be enabled at the same time in Kconfig, but host mode takes precedence in the actual operation. ChenYu
On Wed, Aug 22, 2018 at 8:11 AM, Chen-Yu Tsai <wens@csie.org> wrote: > On Tue, Aug 21, 2018 at 9:04 PM Jagan Teki <jagan@amarulasolutions.com> wrote: >> >> On Fri, Jul 20, 2018 at 12:43 PM, Jagan Teki <jagan@amarulasolutions.com> wrote: >> > This is v2 for previous series[1], by excluding sunxi phy changes. >> > >> > One patch mark it as 'RFC' about "including UCLASS_USB_DEV_GENERIC >> > into shutdown caller" so expecting some inputs on the same >> > >> > [1] https://patchwork.ozlabs.org/cover/941588/ >> > >> > Jagan Teki (6): >> > usb: musb-new: Fix improper musb host pointer >> > usb: musb-new: sunxi: Allocate struct phy in private >> > dm: usb: Add UCLASS_USB_DEV_GENERIC shutdown >> > musb-new: sunxi: Access ahb_reset0_cfg via ccm offset >> > usb: musb-new: sunxi: Add proper musb exit support >> > usb: musb-new: Call musb_platform_exit from musb_stop >> >> I'm planning to apply by excluding RFC patch, let me know if anyone >> has any inputs. > > Boots cleanly without the RFC patch on the Bananapi M2 Magic, > with musb-new built in both host and gadget mode. Thanks. Collected Tested-by and Applied to u-boot-sunxi/master > > Curiously, both modes can be enabled at the same time in Kconfig, > but host mode takes precedence in the actual operation. Look like Yes. I think we can grab dr_mode to set respective mode.