diff mbox series

[v2,1/1] docs/system/riscv: document acpi parameter of virt machine

Message ID 20231220193436.25909-1-heinrich.schuchardt@canonical.com
State New
Headers show
Series [v2,1/1] docs/system/riscv: document acpi parameter of virt machine | expand

Commit Message

Heinrich Schuchardt Dec. 20, 2023, 7:34 p.m. UTC 
Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI
table generation. Add it to the documentation.

Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
v2:
	mention that acpi=on is the default
---
 docs/system/riscv/virt.rst | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Daniel Henrique Barboza Dec. 20, 2023, 7:39 p.m. UTC | #1 
On 12/20/23 16:34, Heinrich Schuchardt wrote:
> Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI
> table generation. Add it to the documentation.
> 
> Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---

Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>

> v2:
> 	mention that acpi=on is the default
> ---
>   docs/system/riscv/virt.rst | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/docs/system/riscv/virt.rst b/docs/system/riscv/virt.rst
> index f5fa7b8b29..9a06f95a34 100644
> --- a/docs/system/riscv/virt.rst
> +++ b/docs/system/riscv/virt.rst
> @@ -95,6 +95,11 @@ The following machine-specific options are supported:
>     SiFive CLINT. When not specified, this option is assumed to be "off".
>     This option is restricted to the TCG accelerator.
>   
> +- acpi=[on|off|auto]
> +
> +  When this option is "on" (which is the default), ACPI tables are generated and
> +  exposed as firmware tables etc/acpi/rsdp and etc/acpi/tables.
> +
>   - aia=[none|aplic|aplic-imsic]
>   
>     This option allows selecting interrupt controller defined by the AIA
Sunil V L Dec. 21, 2023, 3:18 a.m. UTC | #2 
On Wed, Dec 20, 2023 at 08:34:36PM +0100, Heinrich Schuchardt wrote:
> Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI
> table generation. Add it to the documentation.
> 
> Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> v2:
> 	mention that acpi=on is the default
> ---
>  docs/system/riscv/virt.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

Thanks!
Sunil
Alistair Francis Jan. 4, 2024, 6:14 a.m. UTC | #3 
On Thu, Dec 21, 2023 at 6:03 AM Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI
> table generation. Add it to the documentation.
>
> Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
> v2:
>         mention that acpi=on is the default
> ---
>  docs/system/riscv/virt.rst | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/docs/system/riscv/virt.rst b/docs/system/riscv/virt.rst
> index f5fa7b8b29..9a06f95a34 100644
> --- a/docs/system/riscv/virt.rst
> +++ b/docs/system/riscv/virt.rst
> @@ -95,6 +95,11 @@ The following machine-specific options are supported:
>    SiFive CLINT. When not specified, this option is assumed to be "off".
>    This option is restricted to the TCG accelerator.
>
> +- acpi=[on|off|auto]
> +
> +  When this option is "on" (which is the default), ACPI tables are generated and
> +  exposed as firmware tables etc/acpi/rsdp and etc/acpi/tables.
> +
>  - aia=[none|aplic|aplic-imsic]
>
>    This option allows selecting interrupt controller defined by the AIA
> --
> 2.40.1
>
>
Alistair Francis Jan. 4, 2024, 6:15 a.m. UTC | #4 
On Thu, Dec 21, 2023 at 6:03 AM Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI
> table generation. Add it to the documentation.
>
> Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Thanks!

Applied to riscv-to-apply.next

Alistair

> ---
> v2:
>         mention that acpi=on is the default
> ---
>  docs/system/riscv/virt.rst | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/docs/system/riscv/virt.rst b/docs/system/riscv/virt.rst
> index f5fa7b8b29..9a06f95a34 100644
> --- a/docs/system/riscv/virt.rst
> +++ b/docs/system/riscv/virt.rst
> @@ -95,6 +95,11 @@ The following machine-specific options are supported:
>    SiFive CLINT. When not specified, this option is assumed to be "off".
>    This option is restricted to the TCG accelerator.
>
> +- acpi=[on|off|auto]
> +
> +  When this option is "on" (which is the default), ACPI tables are generated and
> +  exposed as firmware tables etc/acpi/rsdp and etc/acpi/tables.
> +
>  - aia=[none|aplic|aplic-imsic]
>
>    This option allows selecting interrupt controller defined by the AIA
> --
> 2.40.1
>
>
diff mbox series

Patch

diff --git a/docs/system/riscv/virt.rst b/docs/system/riscv/virt.rst
index f5fa7b8b29..9a06f95a34 100644
--- a/docs/system/riscv/virt.rst
+++ b/docs/system/riscv/virt.rst
@@ -95,6 +95,11 @@  The following machine-specific options are supported:
   SiFive CLINT. When not specified, this option is assumed to be "off".
   This option is restricted to the TCG accelerator.
 
+- acpi=[on|off|auto]
+
+  When this option is "on" (which is the default), ACPI tables are generated and
+  exposed as firmware tables etc/acpi/rsdp and etc/acpi/tables.
+
 - aia=[none|aplic|aplic-imsic]
 
   This option allows selecting interrupt controller defined by the AIA