| Message ID | 20220707163720.1421716-10-berrange@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | tests: introduce a tree-wide code style checking facility | expand |
On Thu, Jul 07, 2022 at 05:37:20PM +0100, Daniel P. Berrangé wrote: > Since the qemu/osdep.h file must be included as the very first header > in all C source files, there is no reason to include it in .h or .c.in .c.inc > files. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/style.yml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/style.yml b/tests/style.yml > index 6d91ac6115..d2a0299a33 100644 > --- a/tests/style.yml > +++ b/tests/style.yml > @@ -143,3 +143,8 @@ osdep_h_in_source: > - tests/uefi-test-tools/.* > - tests/unit/test-rcu-(simpleq|slist|tailq)\.c > - tools/ebpf/rss.bpf.c > + > +osdep_h_in_header: > + files: \.(h|c\.inc)$ > + prohibit: '#include "qemu/osdep\.h"' > + message: only C source files may include qemu/osdep.h Should we also have a rule that rejects <qemu/osdep.h> in all files (our only spelling should be with "", not <>)?
diff --git a/tests/style.yml b/tests/style.yml index 6d91ac6115..d2a0299a33 100644 --- a/tests/style.yml +++ b/tests/style.yml @@ -143,3 +143,8 @@ osdep_h_in_source: - tests/uefi-test-tools/.* - tests/unit/test-rcu-(simpleq|slist|tailq)\.c - tools/ebpf/rss.bpf.c + +osdep_h_in_header: + files: \.(h|c\.inc)$ + prohibit: '#include "qemu/osdep\.h"' + message: only C source files may include qemu/osdep.h
Since the qemu/osdep.h file must be included as the very first header in all C source files, there is no reason to include it in .h or .c.in files. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- tests/style.yml | 5 +++++ 1 file changed, 5 insertions(+)