From patchwork Thu Jul 7 16:37:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= X-Patchwork-Id: 1653701 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KKq4wcdX; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Lf2Ld5r66z9s07 for ; Fri, 8 Jul 2022 02:44:25 +1000 (AEST) Received: from localhost ([::1]:49422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9Uc3-0005li-KR for incoming@patchwork.ozlabs.org; Thu, 07 Jul 2022 12:44:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9UVy-0008Su-DJ for qemu-devel@nongnu.org; Thu, 07 Jul 2022 12:38:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:31466) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9UVr-0006pc-VP for qemu-devel@nongnu.org; Thu, 07 Jul 2022 12:38:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657211878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YpO3X2dhWNMDcL2RL5PGtLi0467hFdMwo9K3xsRLDsY=; b=KKq4wcdXs34+zUbFMQibXlXXmcn5DpiJiv5lppvVFIWK0M+VBfrlUbVXJQiaZzFSEKZt4h IWUwCVizAERuatdMi/LkBLpLfK33ICKD8vGJw9hrjGZjZL4Z6mEFRGy3Z289DI+1FVddrL zQqq2aXZ/QnSZzfmNhOFvk9evR/+KVc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-453-cV5p6PgdPICvyQhtJgEryQ-1; Thu, 07 Jul 2022 12:37:55 -0400 X-MC-Unique: cV5p6PgdPICvyQhtJgEryQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 795D4833A0D; Thu, 7 Jul 2022 16:37:38 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F9EF40315C; Thu, 7 Jul 2022 16:37:37 +0000 (UTC) From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Eric Blake , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Thomas Huth , Peter Maydell , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= Subject: [PATCH v3 9/9] tests/style: check qemu/osdep.h is NOT included in all .h/.c.inc files Date: Thu, 7 Jul 2022 17:37:20 +0100 Message-Id: <20220707163720.1421716-10-berrange@redhat.com> In-Reply-To: <20220707163720.1421716-1-berrange@redhat.com> References: <20220707163720.1421716-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Since the qemu/osdep.h file must be included as the very first header in all C source files, there is no reason to include it in .h or .c.in files. Signed-off-by: Daniel P. Berrangé --- tests/style.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/style.yml b/tests/style.yml index 6d91ac6115..d2a0299a33 100644 --- a/tests/style.yml +++ b/tests/style.yml @@ -143,3 +143,8 @@ osdep_h_in_source: - tests/uefi-test-tools/.* - tests/unit/test-rcu-(simpleq|slist|tailq)\.c - tools/ebpf/rss.bpf.c + +osdep_h_in_header: + files: \.(h|c\.inc)$ + prohibit: '#include "qemu/osdep\.h"' + message: only C source files may include qemu/osdep.h