| Message ID | 20190624222844.26584-8-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | hw/pci-host: Clean the GT64120 north bridge | expand |
On Jun 25, 2019 12:44 AM, "Philippe Mathieu-Daudé" <f4bug@amsat.org> wrote: > > One byte is missing, use an aligned size. > > (qemu) info mtree > memory-region: pci0-mem > 0000000000000000-00000000fffffffe (prio 0, i/o): pci0-mem > ^ > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com> I agree with this change, but do we have similar situations in QEMU code elsewhere? > hw/mips/gt64xxx_pci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c > index 815ef0711d..2fa313f498 100644 > --- a/hw/mips/gt64xxx_pci.c > +++ b/hw/mips/gt64xxx_pci.c > @@ -23,6 +23,7 @@ > */ > > #include "qemu/osdep.h" > +#include "qemu/units.h" > #include "qemu/log.h" > #include "hw/hw.h" > #include "hw/mips/mips.h" > @@ -1201,7 +1202,7 @@ PCIBus *gt64120_register(qemu_irq *pic) > dev = qdev_create(NULL, TYPE_GT64120_PCI_HOST_BRIDGE); > d = GT64120_PCI_HOST_BRIDGE(dev); > phb = PCI_HOST_BRIDGE(dev); > - memory_region_init(&d->pci0_mem, OBJECT(dev), "pci0-mem", UINT32_MAX); > + memory_region_init(&d->pci0_mem, OBJECT(dev), "pci0-mem", 4 * GiB); > address_space_init(&d->pci0_mem_as, &d->pci0_mem, "pci0-mem"); > phb->bus = pci_register_root_bus(dev, "pci", > gt64120_pci_set_irq, gt64120_pci_map_irq, > -- > 2.19.1 > >
On 6/25/19 2:43 AM, Aleksandar Markovic wrote: > > On Jun 25, 2019 12:44 AM, "Philippe Mathieu-Daudé" <f4bug@amsat.org > <mailto:f4bug@amsat.org>> wrote: >> >> One byte is missing, use an aligned size. >> >> (qemu) info mtree >> memory-region: pci0-mem >> 0000000000000000-00000000fffffffe (prio 0, i/o): pci0-mem >> ^ >> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org > <mailto:f4bug@amsat.org>> >> --- > > Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com > <mailto:amarkovic@wavecomp.com>> Thanks! > I agree with this change, but do we have similar situations in QEMU code > elsewhere? Good reflex :) We have the Jazz boards: address-space: rc4030-dma 0000000000000000-00000000fffffffe (prio 0, i/o): rc4030.dma address-space: dp8393x 0000000000000000-00000000fffffffe (prio 0, i/o): rc4030.dma >> hw/mips/gt64xxx_pci.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c >> index 815ef0711d..2fa313f498 100644 >> --- a/hw/mips/gt64xxx_pci.c >> +++ b/hw/mips/gt64xxx_pci.c >> @@ -23,6 +23,7 @@ >> */ >> >> #include "qemu/osdep.h" >> +#include "qemu/units.h" >> #include "qemu/log.h" >> #include "hw/hw.h" >> #include "hw/mips/mips.h" >> @@ -1201,7 +1202,7 @@ PCIBus *gt64120_register(qemu_irq *pic) >> dev = qdev_create(NULL, TYPE_GT64120_PCI_HOST_BRIDGE); >> d = GT64120_PCI_HOST_BRIDGE(dev); >> phb = PCI_HOST_BRIDGE(dev); >> - memory_region_init(&d->pci0_mem, OBJECT(dev), "pci0-mem", > UINT32_MAX); >> + memory_region_init(&d->pci0_mem, OBJECT(dev), "pci0-mem", 4 * GiB); >> address_space_init(&d->pci0_mem_as, &d->pci0_mem, "pci0-mem"); >> phb->bus = pci_register_root_bus(dev, "pci", >> gt64120_pci_set_irq, > gt64120_pci_map_irq, >> -- >> 2.19.1 >> >> >
diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c index 815ef0711d..2fa313f498 100644 --- a/hw/mips/gt64xxx_pci.c +++ b/hw/mips/gt64xxx_pci.c @@ -23,6 +23,7 @@ */ #include "qemu/osdep.h" +#include "qemu/units.h" #include "qemu/log.h" #include "hw/hw.h" #include "hw/mips/mips.h" @@ -1201,7 +1202,7 @@ PCIBus *gt64120_register(qemu_irq *pic) dev = qdev_create(NULL, TYPE_GT64120_PCI_HOST_BRIDGE); d = GT64120_PCI_HOST_BRIDGE(dev); phb = PCI_HOST_BRIDGE(dev); - memory_region_init(&d->pci0_mem, OBJECT(dev), "pci0-mem", UINT32_MAX); + memory_region_init(&d->pci0_mem, OBJECT(dev), "pci0-mem", 4 * GiB); address_space_init(&d->pci0_mem_as, &d->pci0_mem, "pci0-mem"); phb->bus = pci_register_root_bus(dev, "pci", gt64120_pci_set_irq, gt64120_pci_map_irq,
One byte is missing, use an aligned size. (qemu) info mtree memory-region: pci0-mem 0000000000000000-00000000fffffffe (prio 0, i/o): pci0-mem ^ Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/mips/gt64xxx_pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)