Message ID | 20190319124803.13826-19-palmer@sifive.com |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="NAWCCyAe"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44NtgV54WWz9s70 for <incoming@patchwork.ozlabs.org>; Wed, 20 Mar 2019 00:09:42 +1100 (AEDT) Received: from localhost ([127.0.0.1]:57124 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>) id 1h6EUu-0007WM-Cn for incoming@patchwork.ozlabs.org; Tue, 19 Mar 2019 09:09:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <palmer@sifive.com>) id 1h6ETr-00078U-1u for qemu-devel@nongnu.org; Tue, 19 Mar 2019 09:08:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <palmer@sifive.com>) id 1h6EGo-0005Ux-4p for qemu-devel@nongnu.org; Tue, 19 Mar 2019 08:55:06 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]:43927) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <palmer@sifive.com>) id 1h6EGn-0005Un-Qw for qemu-devel@nongnu.org; Tue, 19 Mar 2019 08:55:06 -0400 Received: by mail-pg1-x52d.google.com with SMTP id l11so13771272pgq.10 for <qemu-devel@nongnu.org>; Tue, 19 Mar 2019 05:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding:cc:from:to; bh=1SyDM/qdCRzCh+lWvsUL7MN72la+HsLqQuB53k1Hdyg=; b=NAWCCyAe/IdX+dP98ANB1jmV7ooHKAjJwAecUEFlN6ADPgK3IX+NGxl9BS6NyDN3pT zvzd8Cl7riORZ7OXtkLL41PUzgONIuZ8quJUA3RZbgzSyGdvhE72ALuQoSbL7+3bPZt6 E/yvhoeJUY8hcC0LZmXFja5gFERyKq9MYMfUiyrjVJBifXEyIZQWQ6LrOj6pDuK2p1y1 /QfvwoWKqNU/ldwS3mwReE0O1DRwYgRHFudsa6aV0jGwz0gAj6HT4+vUhG0DZyQTnJuD QCvaD4sEm9aLcPlHWu5gHO+PsTly53QojT4bcpVH2zLkBzdbfrP47K4YvlES8JUisl/0 zo9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:cc:from:to; bh=1SyDM/qdCRzCh+lWvsUL7MN72la+HsLqQuB53k1Hdyg=; b=jLG4EMplfNNSwciSOsp0qbEjPTtZnzihQC3yINZnS059MGc/+2wTM0DP40BI92NS2f u9LCQt9t6Tfcur5Bra60biiGfEI8qxujilztzEvzKSoYxPW/qDM0g4x2rEH+Z/KOtUcn epacVCDCFQ5sv5l+3gFnCRhYFKpqTWKvFy3FvrDL6II7k3Tvgugsa5JKumeQX4PrfIWS SxzlLOH5pTUqyngFO0OSo7aTBcsvonEvAJblkVK5JZz93McSclPz53/IZUT6xSNkLl4b 9g+iNBO94VmTOS3kJ3jDsqIfFhBh2oUDEZw15hUlijg5RdJX9cxdXVNZdN22o/I7I9tU afGA== X-Gm-Message-State: APjAAAUbV+hKPb294WRUjIUEI0iOf2y5b4rsIq7Ffys+v6+YFUAYAOXS hyovhINdM/2gzloC2YrUgaG06w== X-Google-Smtp-Source: APXvYqxo1rJUcXqBv2T4il4+8LrruGaf7qN1Z0LIh3IHHYruJKyDLBH2L9ejuPiORV4ETLEfiRSq0w== X-Received: by 2002:a63:ff0f:: with SMTP id k15mr2156159pgi.301.1553000105014; Tue, 19 Mar 2019 05:55:05 -0700 (PDT) Received: from localhost (2001-b011-7001-1cad-363a-ebbe-dac8-3f4c.dynamic-ip6.hinet.net. [2001:b011:7001:1cad:363a:ebbe:dac8:3f4c]) by smtp.gmail.com with ESMTPSA id c130sm22896821pfb.145.2019.03.19.05.55.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Mar 2019 05:55:04 -0700 (PDT) Date: Tue, 19 Mar 2019 05:48:02 -0700 Message-Id: <20190319124803.13826-19-palmer@sifive.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190319124803.13826-1-palmer@sifive.com> References: <20190319124803.13826-1-palmer@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Palmer Dabbelt <palmer@sifive.com> To: Peter Maydell <peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52d Subject: [Qemu-devel] [PULL 18/19] riscv: sifive_uart: Generate TX interrupt X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: Bin Meng <bmeng.cn@gmail.com>, qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Palmer Dabbelt <palmer@sifive.com> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> |
Series |
[PULL,01/19] RISC-V: Add 32-bit gdb xml files.
|
expand
|
diff --git a/hw/riscv/sifive_uart.c b/hw/riscv/sifive_uart.c index 456a3d3697c2..3b3f94f51ddf 100644 --- a/hw/riscv/sifive_uart.c +++ b/hw/riscv/sifive_uart.c @@ -51,7 +51,8 @@ static uint64_t uart_ip(SiFiveUARTState *s) static void update_irq(SiFiveUARTState *s) { int cond = 0; - if ((s->ie & SIFIVE_UART_IE_RXWM) && s->rx_fifo_len) { + if ((s->ie & SIFIVE_UART_IE_TXWM) || + ((s->ie & SIFIVE_UART_IE_RXWM) && s->rx_fifo_len)) { cond = 1; } if (cond) { @@ -108,6 +109,7 @@ uart_write(void *opaque, hwaddr addr, switch (addr) { case SIFIVE_UART_TXFIFO: qemu_chr_fe_write(&s->chr, &ch, 1); + update_irq(s); return; case SIFIVE_UART_IE: s->ie = val64;