| Message ID | 20181227063419.12981-24-yang.zhong@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | Support Kconfig in QEMU | expand |
On 2018-12-27 07:34, Yang Zhong wrote: > Only keep same boards definitions as i386-softmmu.mak in > x86_64-softmmu.mak. > > Signed-off-by: Yang Zhong <yang.zhong@intel.com> > --- > default-configs/x86_64-softmmu.mak | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak > index 64b2ee2960..0c69c2930c 100644 > --- a/default-configs/x86_64-softmmu.mak > +++ b/default-configs/x86_64-softmmu.mak > @@ -1,3 +1,7 @@ > # Default configuration for x86_64-softmmu > > -include i386-softmmu.mak > +# Boards: > +# > +CONFIG_ISAPC=y > +CONFIG_I440FX=y > +CONFIG_Q35=y Not sure whether this patch is really necessary since the two configs are currently really the same. Anyway, in case you want to keep the patch: Reviewed-by: Thomas Huth <thuth@redhat.com>
On Thu, 27 Dec 2018 at 06:35, Yang Zhong <yang.zhong@intel.com> wrote: > > Only keep same boards definitions as i386-softmmu.mak in > x86_64-softmmu.mak. > > Signed-off-by: Yang Zhong <yang.zhong@intel.com> > --- > default-configs/x86_64-softmmu.mak | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak > index 64b2ee2960..0c69c2930c 100644 > --- a/default-configs/x86_64-softmmu.mak > +++ b/default-configs/x86_64-softmmu.mak > @@ -1,3 +1,7 @@ > # Default configuration for x86_64-softmmu > > -include i386-softmmu.mak > +# Boards: > +# > +CONFIG_ISAPC=y > +CONFIG_I440FX=y > +CONFIG_Q35=y Could you explain the rationale for doing this? Now any new i386 board has to be added in two places, doesn't it? thanks -- PMM
On Fri, Jan 04, 2019 at 08:58:09PM +0100, Thomas Huth wrote: > On 2018-12-27 07:34, Yang Zhong wrote: > > Only keep same boards definitions as i386-softmmu.mak in > > x86_64-softmmu.mak. > > > > Signed-off-by: Yang Zhong <yang.zhong@intel.com> > > --- > > default-configs/x86_64-softmmu.mak | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak > > index 64b2ee2960..0c69c2930c 100644 > > --- a/default-configs/x86_64-softmmu.mak > > +++ b/default-configs/x86_64-softmmu.mak > > @@ -1,3 +1,7 @@ > > # Default configuration for x86_64-softmmu > > > > -include i386-softmmu.mak > > +# Boards: > > +# > > +CONFIG_ISAPC=y > > +CONFIG_I440FX=y > > +CONFIG_Q35=y > > Not sure whether this patch is really necessary since the two configs > are currently really the same. Anyway, in case you want to keep the patch: > Thanks for comments, yes, it seems this patch is not useful, i will remove this patch in next version. Regards, Yang > Reviewed-by: Thomas Huth <thuth@redhat.com>
On Sat, Jan 05, 2019 at 03:32:13PM +0000, Peter Maydell wrote: > On Thu, 27 Dec 2018 at 06:35, Yang Zhong <yang.zhong@intel.com> wrote: > > > > Only keep same boards definitions as i386-softmmu.mak in > > x86_64-softmmu.mak. > > > > Signed-off-by: Yang Zhong <yang.zhong@intel.com> > > --- > > default-configs/x86_64-softmmu.mak | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak > > index 64b2ee2960..0c69c2930c 100644 > > --- a/default-configs/x86_64-softmmu.mak > > +++ b/default-configs/x86_64-softmmu.mak > > @@ -1,3 +1,7 @@ > > # Default configuration for x86_64-softmmu > > > > -include i386-softmmu.mak > > +# Boards: > > +# > > +CONFIG_ISAPC=y > > +CONFIG_I440FX=y > > +CONFIG_Q35=y > > Could you explain the rationale for doing this? Now > any new i386 board has to be added in two places, > doesn't it? > > thanks > -- PMM Thanks Peter, you are right, i will remove this patch in next version, thanks! Regards, Yang
diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak index 64b2ee2960..0c69c2930c 100644 --- a/default-configs/x86_64-softmmu.mak +++ b/default-configs/x86_64-softmmu.mak @@ -1,3 +1,7 @@ # Default configuration for x86_64-softmmu -include i386-softmmu.mak +# Boards: +# +CONFIG_ISAPC=y +CONFIG_I440FX=y +CONFIG_Q35=y
Only keep same boards definitions as i386-softmmu.mak in x86_64-softmmu.mak. Signed-off-by: Yang Zhong <yang.zhong@intel.com> --- default-configs/x86_64-softmmu.mak | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)