| Message ID | 20171005105157.10831-1-dgilbert@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 05/10/2017 12:51, Dr. David Alan Gilbert (git) wrote: > From: Markus Armbruster <armbru@redhat.com> > > Screwed up in commit da76ee7. Let me introduce you to these two aliases: whatis = "show -s --pretty='tformat:%h (\"%s\", %cd)' --date=short" pwhatis = "show -s --pretty='tformat:%h, \"%s\", %cd' --date=short" $ git whatis da76ee7 da76ee76f7 ("hmp-commands-info: move info_cmds content out of monitor.c", 2015-09-16) pwhatis is more appropriate if you are including the commit at the end of a parenthetical remark, like ... (see commit message for 53ec73e, "block: Use bdrv_drain to replace uncessary bdrv_drain_all", 2015-07-07). Paolo > Signed-off-by: Markus Armbruster <armbru@redhat.com> > Message-Id: <20171002134538.23332-2-armbru@redhat.com> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > ---
* Paolo Bonzini (pbonzini@redhat.com) wrote: > On 05/10/2017 12:51, Dr. David Alan Gilbert (git) wrote: > > From: Markus Armbruster <armbru@redhat.com> > > > > Screwed up in commit da76ee7. > > Let me introduce you to these two aliases: > > whatis = "show -s --pretty='tformat:%h (\"%s\", %cd)' --date=short" > pwhatis = "show -s --pretty='tformat:%h, \"%s\", %cd' --date=short" > > $ git whatis da76ee7 > da76ee76f7 ("hmp-commands-info: move info_cmds content out of monitor.c", 2015-09-16) > > pwhatis is more appropriate if you are including the commit at the end > of a parenthetical remark, like > > ... (see commit message for 53ec73e, "block: Use bdrv_drain to > replace uncessary bdrv_drain_all", 2015-07-07). Ah well, that was just Markus's message; personally I'd uses a Fixes: da76ee7 then we've got a chance of automation. Dave > Paolo > > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > > Message-Id: <20171002134538.23332-2-armbru@redhat.com> > > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > > --- > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
On 5 October 2017 at 11:51, Dr. David Alan Gilbert (git) <dgilbert@redhat.com> wrote: > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > The following changes since commit d147f7e815f97cb477e223586bcb80c316ae10ea: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-10-03 16:27:24 +0100) > > are available in the git repository at: > > git://github.com/dagrh/qemu.git tags/pull-hmp-20171005 > > for you to fetch changes up to 1b591700e6410d1a8f7700a13686a16759977204: > > hmp-commands-info: Change "@findex FOO" to "@findex info FOO" (2017-10-05 10:08:39 +0100) > > ---------------------------------------------------------------- > HMP pull 2017-10-05 > > ---------------------------------------------------------------- Applied, thanks. -- PMM
Paolo Bonzini <pbonzini@redhat.com> writes: > On 05/10/2017 12:51, Dr. David Alan Gilbert (git) wrote: >> From: Markus Armbruster <armbru@redhat.com> >> >> Screwed up in commit da76ee7. > > Let me introduce you to these two aliases: > > whatis = "show -s --pretty='tformat:%h (\"%s\", %cd)' --date=short" > pwhatis = "show -s --pretty='tformat:%h, \"%s\", %cd' --date=short" > > $ git whatis da76ee7 > da76ee76f7 ("hmp-commands-info: move info_cmds content out of monitor.c", 2015-09-16) > > pwhatis is more appropriate if you are including the commit at the end > of a parenthetical remark, like > > ... (see commit message for 53ec73e, "block: Use bdrv_drain to > replace uncessary bdrv_drain_all", 2015-07-07). Heh, nice way to call out my laziness ;) Thanks!
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> The following changes since commit d147f7e815f97cb477e223586bcb80c316ae10ea: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-10-03 16:27:24 +0100) are available in the git repository at: git://github.com/dagrh/qemu.git tags/pull-hmp-20171005 for you to fetch changes up to 1b591700e6410d1a8f7700a13686a16759977204: hmp-commands-info: Change "@findex FOO" to "@findex info FOO" (2017-10-05 10:08:39 +0100) ---------------------------------------------------------------- HMP pull 2017-10-05 ---------------------------------------------------------------- Dr. David Alan Gilbert (2): hmp: Missing handle_errors hmp: Fix unknown command for subtable Markus Armbruster (3): hmp-commands-info: Fix "info rocker-FOO" misspellings hmp-commands-info: Move Texinfo stanzas to conventional place hmp-commands-info: Change "@findex FOO" to "@findex info FOO" hmp-commands-info.hx | 138 +++++++++++++++++++++++++-------------------------- hmp.c | 2 + monitor.c | 7 +-- 3 files changed, 75 insertions(+), 72 deletions(-)