Message ID | 1447879178-5440-1-git-send-email-afaerber@suse.de |
---|---|
State | New |
Headers | show |
On 18 November 2015 at 20:39, Andreas Färber <afaerber@suse.de> wrote: > Hello Peter, > > This is my late QOM (devices) patch queue. Please pull. > > Regards, > Andreas > > Cc: Peter Maydell <peter.maydell@linaro.org> > Cc: Daniel P. Berrange <berrange@redhat.com> > Cc: Pavel Fedin <p.fedin@samsung.com> > > The following changes since commit 74fcbd22d20a2fbc1a47a7b00cce5bf98fd7be5f: > > hw/misc: Add support for ADC controller in Xilinx Zynq 7000 (2015-11-12 21:30:42 +0000) > > are available in the git repository at: > > git://github.com/afaerber/qemu-cpu.git tags/qom-devices-for-peter > > for you to fetch changes up to c5760450796433621ccdc125866a84b892e2d5b6: > > MAINTAINERS: Add check-qom-{interface,proplist} to QOM (2015-11-18 21:13:50 +0100) > > ---------------------------------------------------------------- > QOM infrastructure fixes and device conversions > > * Fix for properties on objects > 4 GiB > * Performance improvements for QOM property handling > * Assertion cleanups > * MAINTAINERS additions Hi. Unfortunately this doesn't build with our minimum supported glib version: /Users/pm215/src/qemu-for-merges/qom/object.c:921:9: warning: implicit declaration of function 'g_hash_table_contains' is invalid in C99 [-Wimplicit-function-declaration] if (g_hash_table_contains(obj->properties, name)) { ^ g_hash_table_contains was only introduced in glib 2.32. thanks -- PMM
On Thu, Nov 19, 2015 at 10:54:15AM +0000, Peter Maydell wrote: > On 18 November 2015 at 20:39, Andreas Färber <afaerber@suse.de> wrote: > > Hello Peter, > > > > This is my late QOM (devices) patch queue. Please pull. > > > > Regards, > > Andreas > > > > Cc: Peter Maydell <peter.maydell@linaro.org> > > Cc: Daniel P. Berrange <berrange@redhat.com> > > Cc: Pavel Fedin <p.fedin@samsung.com> > > > > The following changes since commit 74fcbd22d20a2fbc1a47a7b00cce5bf98fd7be5f: > > > > hw/misc: Add support for ADC controller in Xilinx Zynq 7000 (2015-11-12 21:30:42 +0000) > > > > are available in the git repository at: > > > > git://github.com/afaerber/qemu-cpu.git tags/qom-devices-for-peter > > > > for you to fetch changes up to c5760450796433621ccdc125866a84b892e2d5b6: > > > > MAINTAINERS: Add check-qom-{interface,proplist} to QOM (2015-11-18 21:13:50 +0100) > > > > ---------------------------------------------------------------- > > QOM infrastructure fixes and device conversions > > > > * Fix for properties on objects > 4 GiB > > * Performance improvements for QOM property handling > > * Assertion cleanups > > * MAINTAINERS additions > > Hi. Unfortunately this doesn't build with our minimum supported > glib version: > > /Users/pm215/src/qemu-for-merges/qom/object.c:921:9: warning: implicit > declaration of function 'g_hash_table_contains' is invalid in C99 > [-Wimplicit-function-declaration] > if (g_hash_table_contains(obj->properties, name)) { > ^ > > g_hash_table_contains was only introduced in glib 2.32. Since we never store NULL as a valid value in the hash tble, we can simply replace this with g_hash_table_lookup instead Regards, Daniel