diff mbox

[for-2.3?,6/7] tests/tcg: Prettify run-runcom output

Message ID 1428777292-24628-7-git-send-email-afaerber@suse.de
State New
Headers show

Commit Message

Andreas Färber April 11, 2015, 6:34 p.m. UTC
Executing the binary pi_10.com terminates without a trailing newline.

As it does not seem to be caused by the runcom program and since we
can't easily fix pi_10.com, add an echo after executing it. This places
"make:" output (or that of a target following it) on a new line as expected.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 tests/tcg/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Alex Bennée April 13, 2015, 3:37 p.m. UTC | #1
Andreas Färber <afaerber@suse.de> writes:

> Executing the binary pi_10.com terminates without a trailing newline.
>
> As it does not seem to be caused by the runcom program and since we
> can't easily fix pi_10.com, add an echo after executing it. This places
> "make:" output (or that of a target following it) on a new line as expected.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  tests/tcg/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile
> index db8c510..f853d54 100644
> --- a/tests/tcg/Makefile
> +++ b/tests/tcg/Makefile
> @@ -75,6 +75,7 @@ run-test-mmap: test-mmap
>  
>  run-runcom: runcom
>  	-$(QEMU) ./runcom $(SRC_PATH)/tests/tcg/pi_10.com
> +	@echo

I'm not so sure about this. Shouldn't we be being a lot quieter by
default. At the moment the TCG tests are very noisy with their output
compared to the rest of the tests. On a V=0 run I expect just to see
test name and a PASS/FAIL.

>  
>  run-test_path: test_path
>  	./test_path
Peter Maydell April 13, 2015, 3:38 p.m. UTC | #2
On 13 April 2015 at 16:37, Alex Bennée <alex.bennee@linaro.org> wrote:
> I'm not so sure about this. Shouldn't we be being a lot quieter by
> default. At the moment the TCG tests are very noisy with their output
> compared to the rest of the tests. On a V=0 run I expect just to see
> test name and a PASS/FAIL.

Yes, this test needs to be much quieter about what it's doing.
It also takes about an order of magnitude too long to
execute for a test case.

-- PMM
diff mbox

Patch

diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile
index db8c510..f853d54 100644
--- a/tests/tcg/Makefile
+++ b/tests/tcg/Makefile
@@ -75,6 +75,7 @@  run-test-mmap: test-mmap
 
 run-runcom: runcom
 	-$(QEMU) ./runcom $(SRC_PATH)/tests/tcg/pi_10.com
+	@echo
 
 run-test_path: test_path
 	./test_path