| Message ID | 1428676676-23056-1-git-send-email-afaerber@suse.de |
|---|---|
| State | New |
| Headers | show |
On Sat, Apr 11, 2015 at 12:37 AM, Andreas Färber <afaerber@suse.de> wrote: > The type name for the SoC device, unlike those of its sub-devices, > did not follow the QOM naming conventions. While the usage is internal > only, this is exposed through QMP and HMP, so fix it before release. > > Cc: Alistair Francis <alistair.francis@xilinx.com> > Signed-off-by: Andreas Färber <afaerber@suse.de> Looks good to me. Sorry about this slipping in, thanks for fixing it. Reviewed-by: Alistair Francis <alistair@alistair23.me> Thanks, Alistair > --- > include/hw/arm/stm32f205_soc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/arm/stm32f205_soc.h b/include/hw/arm/stm32f205_soc.h > index 3cda170..0390eff 100644 > --- a/include/hw/arm/stm32f205_soc.h > +++ b/include/hw/arm/stm32f205_soc.h > @@ -29,7 +29,7 @@ > #include "hw/timer/stm32f2xx_timer.h" > #include "hw/char/stm32f2xx_usart.h" > > -#define TYPE_STM32F205_SOC "stm32f205_soc" > +#define TYPE_STM32F205_SOC "stm32f205-soc" > #define STM32F205_SOC(obj) \ > OBJECT_CHECK(STM32F205State, (obj), TYPE_STM32F205_SOC) > > -- > 2.1.4 > >
Am 10.04.2015 um 16:47 schrieb Alistair Francis: > On Sat, Apr 11, 2015 at 12:37 AM, Andreas Färber <afaerber@suse.de> wrote: >> The type name for the SoC device, unlike those of its sub-devices, >> did not follow the QOM naming conventions. While the usage is internal >> only, this is exposed through QMP and HMP, so fix it before release. >> >> Cc: Alistair Francis <alistair.francis@xilinx.com> >> Signed-off-by: Andreas Färber <afaerber@suse.de> > > Looks good to me. Sorry about this slipping in, thanks for fixing it. > > Reviewed-by: Alistair Francis <alistair@alistair23.me> Thanks. BTW a real SoC device would integrate ARMCPU as well - in that case we would need to distinguish -arm-soc and -aarch64-soc, like we do for CPUs. Regards, Andreas
On 10 April 2015 at 15:37, Andreas Färber <afaerber@suse.de> wrote: > The type name for the SoC device, unlike those of its sub-devices, > did not follow the QOM naming conventions. While the usage is internal > only, this is exposed through QMP and HMP, so fix it before release. > > Cc: Alistair Francis <alistair.francis@xilinx.com> > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > include/hw/arm/stm32f205_soc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/arm/stm32f205_soc.h b/include/hw/arm/stm32f205_soc.h > index 3cda170..0390eff 100644 > --- a/include/hw/arm/stm32f205_soc.h > +++ b/include/hw/arm/stm32f205_soc.h > @@ -29,7 +29,7 @@ > #include "hw/timer/stm32f2xx_timer.h" > #include "hw/char/stm32f2xx_usart.h" > > -#define TYPE_STM32F205_SOC "stm32f205_soc" > +#define TYPE_STM32F205_SOC "stm32f205-soc" > #define STM32F205_SOC(obj) \ > OBJECT_CHECK(STM32F205State, (obj), TYPE_STM32F205_SOC) Applied, thanks. -- PMM
diff --git a/include/hw/arm/stm32f205_soc.h b/include/hw/arm/stm32f205_soc.h index 3cda170..0390eff 100644 --- a/include/hw/arm/stm32f205_soc.h +++ b/include/hw/arm/stm32f205_soc.h @@ -29,7 +29,7 @@ #include "hw/timer/stm32f2xx_timer.h" #include "hw/char/stm32f2xx_usart.h" -#define TYPE_STM32F205_SOC "stm32f205_soc" +#define TYPE_STM32F205_SOC "stm32f205-soc" #define STM32F205_SOC(obj) \ OBJECT_CHECK(STM32F205State, (obj), TYPE_STM32F205_SOC)
The type name for the SoC device, unlike those of its sub-devices, did not follow the QOM naming conventions. While the usage is internal only, this is exposed through QMP and HMP, so fix it before release. Cc: Alistair Francis <alistair.francis@xilinx.com> Signed-off-by: Andreas Färber <afaerber@suse.de> --- include/hw/arm/stm32f205_soc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)