| Message ID | 1427944026-8968-1-git-send-email-zhaoshenglong@huawei.com |
|---|---|
| State | New |
| Headers | show |
On 2 April 2015 at 04:07, Shannon Zhao <zhaoshenglong@huawei.com> wrote: > From: Shannon Zhao <shannon.zhao@linaro.org> > > As 4de9a88(hw/arm/virt: Fix memory leak reported by Coverity) > and 6e05a12(arm: fix memory leak) both handle the memory leak > reported by Coverity, this cause qemu corruption due to > double free. > > Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com> > Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org> > --- > hw/arm/virt.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 7d082e2..febff22 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -572,7 +572,6 @@ static void create_flash(const VirtBoardInfo *vbi) > error_report("Could not load ROM image '%s'", bios_name); > exit(1); > } > - g_free(fn); > } > > create_one_flash("virt.flash0", flashbase, flashsize); Oops, yes. vexpress.c has the same double-free too. -- PMM
Am 02.04.2015 um 05:07 schrieb Shannon Zhao: > From: Shannon Zhao <shannon.zhao@linaro.org> > > As 4de9a88(hw/arm/virt: Fix memory leak reported by Coverity) > and 6e05a12(arm: fix memory leak) both handle the memory leak > reported by Coverity, this cause qemu corruption due to > double free. > > Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com> > Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org> > --- > hw/arm/virt.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 7d082e2..febff22 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -572,7 +572,6 @@ static void create_flash(const VirtBoardInfo *vbi) > error_report("Could not load ROM image '%s'", bios_name); > exit(1); > } > - g_free(fn); > } > > create_one_flash("virt.flash0", flashbase, flashsize); Signed-off-by: Stefan Weil <sw@weilnetz.de>
On 2015/4/2 11:07, Shannon Zhao wrote: > From: Shannon Zhao <shannon.zhao@linaro.org> > > As 4de9a88(hw/arm/virt: Fix memory leak reported by Coverity) > and 6e05a12(arm: fix memory leak) both handle the memory leak > reported by Coverity, this cause qemu corruption due to > double free. > > Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com> > Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org> > --- > hw/arm/virt.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 7d082e2..febff22 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -572,7 +572,6 @@ static void create_flash(const VirtBoardInfo *vbi) > error_report("Could not load ROM image '%s'", bios_name); > exit(1); > } > - g_free(fn); > } > > create_one_flash("virt.flash0", flashbase, flashsize); > Reviewed-by: Gonglei <arei.gonglei@huawei.com>
On 2 April 2015 at 04:07, Shannon Zhao <zhaoshenglong@huawei.com> wrote: > From: Shannon Zhao <shannon.zhao@linaro.org> > > As 4de9a88(hw/arm/virt: Fix memory leak reported by Coverity) > and 6e05a12(arm: fix memory leak) both handle the memory leak > reported by Coverity, this cause qemu corruption due to > double free. > > Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com> > Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org> > --- > hw/arm/virt.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Applied to master, thanks. -- PMM
diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 7d082e2..febff22 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -572,7 +572,6 @@ static void create_flash(const VirtBoardInfo *vbi) error_report("Could not load ROM image '%s'", bios_name); exit(1); } - g_free(fn); } create_one_flash("virt.flash0", flashbase, flashsize);