diff mbox

[for-2.0] tests/acpi-test: do not run iasl on big endian machines

Message ID 1395337652-16955-1-git-send-email-marcel.a@redhat.com
State New
Headers show

Commit Message

Marcel Apfelbaum March 20, 2014, 5:47 p.m. UTC
There is an issue with iasl on big endian machines: It
cannot disassemble acpi tables taken from little endian
machines, so we cannot check the expected tables.

Do not run iasl on those machines until this
problem is solved by the acpica community.

Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
---
 tests/acpi-test.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Peter Maydell March 20, 2014, 7 p.m. UTC | #1
On 20 March 2014 17:47, Marcel Apfelbaum <marcel.a@redhat.com> wrote:
> There is an issue with iasl on big endian machines: It
> cannot disassemble acpi tables taken from little endian
> machines, so we cannot check the expected tables.
>
> Do not run iasl on those machines until this
> problem is solved by the acpica community.

Is there an upstream bug report for this? It would be
nice to have a reference somewhere so we can tell if
we can remove the check in future...

thanks
-- PMM
Marcel Apfelbaum March 20, 2014, 7:08 p.m. UTC | #2
On Thu, 2014-03-20 at 19:00 +0000, Peter Maydell wrote:
> On 20 March 2014 17:47, Marcel Apfelbaum <marcel.a@redhat.com> wrote:
> > There is an issue with iasl on big endian machines: It
> > cannot disassemble acpi tables taken from little endian
> > machines, so we cannot check the expected tables.
> >
> > Do not run iasl on those machines until this
> > problem is solved by the acpica community.
> 
> Is there an upstream bug report for this? It would be
> nice to have a reference somewhere so we can tell if
> we can remove the check in future...
Hi Peter,
I opened a bug http://bugs.acpica.org/show_bug.cgi?id=1082 and
started a discussion https://lists.acpica.org/pipermail/devel/2014-March/000637.html

Thanks,
Marcel

> 
> thanks
> -- PMM
>
diff mbox

Patch

diff --git a/tests/acpi-test.c b/tests/acpi-test.c
index 249fe03..af44e47 100644
--- a/tests/acpi-test.c
+++ b/tests/acpi-test.c
@@ -145,8 +145,10 @@  static uint8_t boot_sector[0x7e000] = {
 
 static const char *disk = "tests/acpi-test-disk.raw";
 static const char *data_dir = "tests/acpi-test-data";
+#if G_BYTE_ORDER == G_LITTLE_ENDIAN
 #ifdef CONFIG_IASL
 static const char *iasl = stringify(CONFIG_IASL);
+#endif
 #else
 static const char *iasl;
 #endif