| Message ID | 1380790737-11495-3-git-send-email-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 3 October 2013 17:58, <alex.bennee@linaro.org> wrote: > From: Alex Bennée <alex@bennee.com> > > Currently master is broken as the wanted commit doesn't exist in > qemu's mirror of SeaBIOS. > --- > .gitmodules | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.gitmodules b/.gitmodules > index d7e3f3c..d5d5417 100644 > --- a/.gitmodules > +++ b/.gitmodules > @@ -3,7 +3,7 @@ > url = git://git.qemu.org/vgabios.git/ > [submodule "roms/seabios"] > path = roms/seabios > - url = git://git.qemu.org/seabios.git/ > + url = git://git.seabios.org/seabios.git This is wrong. QEMU's submodules should all point to git.qemu.org. Among other things our release source tarballs pull in the sources and it's a good way to ensure it's all consistent and we definitely have version controlled copies of the sources we release under our control rather than just in an external repo. What should actually happen is that Anthony should fix his workflow to ensure that he doesn't commit patches which update submodules without also updating the qemu.org mirrors of the external repos :-) -- PMM
peter.maydell@linaro.org writes: > On 3 October 2013 17:58, <alex.bennee@linaro.org> wrote: >> From: Alex Bennée <alex@bennee.com> >> >> Currently master is broken as the wanted commit doesn't exist in >> qemu's mirror of SeaBIOS. <snip> > This is wrong. QEMU's submodules should all point to > git.qemu.org. Among other things our release source > tarballs pull in the sources and it's a good way to ensure > it's all consistent and we definitely have version controlled > copies of the sources we release under our control rather > than just in an external repo. Fair enough, I'll drop the patch. > What should actually happen is that Anthony should fix > his workflow to ensure that he doesn't commit patches > which update submodules without also updating the > qemu.org mirrors of the external repos :-) Of course once this is merged it will flag up the problem right away (even sooner if the pull request is a github one ;-)
On Thu, Oct 03, 2013 at 06:06:15PM +0900, Peter Maydell wrote: > On 3 October 2013 17:58, <alex.bennee@linaro.org> wrote: > > From: Alex Bennée <alex@bennee.com> > > > > Currently master is broken as the wanted commit doesn't exist in > > qemu's mirror of SeaBIOS. > > --- > > .gitmodules | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/.gitmodules b/.gitmodules > > index d7e3f3c..d5d5417 100644 > > --- a/.gitmodules > > +++ b/.gitmodules > > @@ -3,7 +3,7 @@ > > url = git://git.qemu.org/vgabios.git/ > > [submodule "roms/seabios"] > > path = roms/seabios > > - url = git://git.qemu.org/seabios.git/ > > + url = git://git.seabios.org/seabios.git > > This is wrong. QEMU's submodules should all point to > git.qemu.org. git.qemu-project.org is the preferred domain name. qemu.org is held by a third party. Last year there was a DNS outage that no core QEMU contributor could resolve because we don't have access to the DNS. Also, if the QEMU website IP address changes there may be a delay updating qemu.org. I will send patches to update the domain name. Stefan
diff --git a/.gitmodules b/.gitmodules index d7e3f3c..d5d5417 100644 --- a/.gitmodules +++ b/.gitmodules @@ -3,7 +3,7 @@ url = git://git.qemu.org/vgabios.git/ [submodule "roms/seabios"] path = roms/seabios - url = git://git.qemu.org/seabios.git/ + url = git://git.seabios.org/seabios.git [submodule "roms/SLOF"] path = roms/SLOF url = git://git.qemu.org/SLOF.git
From: Alex Bennée <alex@bennee.com> Currently master is broken as the wanted commit doesn't exist in qemu's mirror of SeaBIOS. --- .gitmodules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)