| Message ID | 20220802075200.907360-1-bmeng.cn@gmail.com |
|---|---|
| Headers | show |
| Series | Enable unix socket support on Windows | expand |
Hi, On Tue, Aug 2, 2022 at 3:52 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > Support for the unix socket has existed both in BSD and Linux for the > longest time, but not on Windows. Since Windows 10 build 17063 [1], > the native support for the unix socket has come to Windows. Starting > this build, two Win32 processes can use the AF_UNIX address family > over Winsock API to communicate with each other. > > [1] https://devblogs.microsoft.com/commandline/af_unix-comes-to-windows/ > > Changes in v4: > - instead of introducing CONFIG_AF_UNIX, add fallback afunix.h header > in os-win32.h, and compile the AF_UNIX stuff for all Windows hosts > - drop CONFIG_AF_UNIX > - introduce a new helper socket_check_afunix_support() to runtime-check > the availability of AF_UNIX socket, and skip those appropriately > All patches in this series have been reviewed. Would you please queue this? Thanks! Regards, Bin
Hi On Thu, Sep 1, 2022 at 10:13 AM Bin Meng <bmeng.cn@gmail.com> wrote: > > Hi, > > On Tue, Aug 2, 2022 at 3:52 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > > > Support for the unix socket has existed both in BSD and Linux for the > > longest time, but not on Windows. Since Windows 10 build 17063 [1], > > the native support for the unix socket has come to Windows. Starting > > this build, two Win32 processes can use the AF_UNIX address family > > over Winsock API to communicate with each other. > > > > [1] https://devblogs.microsoft.com/commandline/af_unix-comes-to-windows/ > > > > Changes in v4: > > - instead of introducing CONFIG_AF_UNIX, add fallback afunix.h header > > in os-win32.h, and compile the AF_UNIX stuff for all Windows hosts > > - drop CONFIG_AF_UNIX > > - introduce a new helper socket_check_afunix_support() to runtime-check > > the availability of AF_UNIX socket, and skip those appropriately > > > > All patches in this series have been reviewed. Would you please queue > this? Thanks! Yes, I was going to do it. Thanks
Support for the unix socket has existed both in BSD and Linux for the longest time, but not on Windows. Since Windows 10 build 17063 [1], the native support for the unix socket has come to Windows. Starting this build, two Win32 processes can use the AF_UNIX address family over Winsock API to communicate with each other. [1] https://devblogs.microsoft.com/commandline/af_unix-comes-to-windows/ Changes in v4: - instead of introducing CONFIG_AF_UNIX, add fallback afunix.h header in os-win32.h, and compile the AF_UNIX stuff for all Windows hosts - drop CONFIG_AF_UNIX - introduce a new helper socket_check_afunix_support() to runtime-check the availability of AF_UNIX socket, and skip those appropriately Changes in v3: - drop the run-time check afunix_available() Changes in v2: - move #include <afunix.h> to os-win32.h - define WIN_BUILD_AF_UNIX only when CONFIG_WIN32 - drop #include <afunix.h> as it is now already included in osdep.h - new patch: tests/unit: Update test-io-channel-socket.c for Windows Bin Meng (4): util/qemu-sockets: Replace the call to close a socket with closesocket() util/qemu-sockets: Enable unix socket support on Windows chardev/char-socket: Update AF_UNIX for Windows tests/unit: Update test-io-channel-socket.c for Windows meson.build | 3 +++ include/sysemu/os-win32.h | 17 +++++++++++++ tests/unit/socket-helpers.h | 9 +++++++ chardev/char-socket.c | 4 ++-- tests/unit/socket-helpers.c | 16 +++++++++++++ tests/unit/test-io-channel-socket.c | 37 ++++++++++++++++++----------- util/qemu-sockets.c | 29 ++-------------------- 7 files changed, 72 insertions(+), 43 deletions(-)