| Message ID | 20210509151618.2331764-1-f4bug@amsat.org |
|---|---|
| Headers | show |
| Series | accel/tcg: Add tlb_flush interface for a range of pages | expand |
Oops, I forgot to add 'v2' in subject line :/ On Sun, May 9, 2021 at 5:16 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > Hi Richard, > > I tried to make sense of the multiple changes in your patch > https://www.mail-archive.com/qemu-devel@nongnu.org/msg805595.html > by splitting it in multiple trivial changes. At least this way > it is easier to me to follow / review what you did. > > The original patch description was: > > Add tlb_flush interface for a range of pages. > Call these tlb_flush_range_by_mmuidx*. > Rewrite the_flush_page_bits_by_mmuidx* to use the new > functions, passing in TARGET_PAGE_SIZE for length. > > If you find it useful, fill free to take / respin / reorder this > series, improving descriptions. Last patch certainly deserves a > better description ;)
ping? On 5/9/21 5:18 PM, Philippe Mathieu-Daudé wrote: > Oops, I forgot to add 'v2' in subject line :/ > > On Sun, May 9, 2021 at 5:16 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: >> >> Hi Richard, >> >> I tried to make sense of the multiple changes in your patch >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg805595.html >> by splitting it in multiple trivial changes. At least this way >> it is easier to me to follow / review what you did. >> >> The original patch description was: >> >> Add tlb_flush interface for a range of pages. >> Call these tlb_flush_range_by_mmuidx*. >> Rewrite the_flush_page_bits_by_mmuidx* to use the new >> functions, passing in TARGET_PAGE_SIZE for length. >> >> If you find it useful, fill free to take / respin / reorder this >> series, improving descriptions. Last patch certainly deserves a >> better description ;) >
On Tue, 25 May 2021 at 08:56, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > ping? I talked to RTH about this yesterday; I actually have it in my target-arm queue and reviewed. I'm just waiting for Richard to supply some commit messages to fill in the bits you left as placeholders/blank... thanks -- PMM
On 5/25/21 11:55 AM, Peter Maydell wrote: > On Tue, 25 May 2021 at 08:56, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: >> >> ping? > > I talked to RTH about this yesterday; I actually have it in > my target-arm queue and reviewed. I'm just waiting for Richard > to supply some commit messages to fill in the bits you left > as placeholders/blank... Oh I forgot about this in tlb_flush_page_bits_by_mmuidx_async_1(), thanks for being careful. I'll learn from Richard comments then :)
On Sun, 9 May 2021 at 16:20, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > Hi Richard, > > I tried to make sense of the multiple changes in your patch > https://www.mail-archive.com/qemu-devel@nongnu.org/msg805595.html > by splitting it in multiple trivial changes. At least this way > it is easier to me to follow / review what you did. > > The original patch description was: > > Add tlb_flush interface for a range of pages. > Call these tlb_flush_range_by_mmuidx*. > Rewrite the_flush_page_bits_by_mmuidx* to use the new > functions, passing in TARGET_PAGE_SIZE for length. > > If you find it useful, fill free to take / respin / reorder this > series, improving descriptions. Last patch certainly deserves a > better description ;) Thanks very much for splitting this patch up -- it made it a lot easier to review. I've added the commit messages Richard has sent, moved the last patch to earlier in the series, and applied the whole lot to target-arm.next. -- PMM
On 5/25/21 4:32 PM, Peter Maydell wrote: > On Sun, 9 May 2021 at 16:20, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: >> >> Hi Richard, >> >> I tried to make sense of the multiple changes in your patch >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg805595.html >> by splitting it in multiple trivial changes. At least this way >> it is easier to me to follow / review what you did. >> >> The original patch description was: >> >> Add tlb_flush interface for a range of pages. >> Call these tlb_flush_range_by_mmuidx*. >> Rewrite the_flush_page_bits_by_mmuidx* to use the new >> functions, passing in TARGET_PAGE_SIZE for length. >> >> If you find it useful, fill free to take / respin / reorder this >> series, improving descriptions. Last patch certainly deserves a >> better description ;) > > Thanks very much for splitting this patch up -- it made it > a lot easier to review. I've added the commit messages > Richard has sent, moved the last patch to earlier in the > series, and applied the whole lot to target-arm.next. Thank you Peter for doing the extra work, and Richard for filling the commit descriptions. I took note on how Richard documented the commits. Regards, Phil.
Hi Richard, I tried to make sense of the multiple changes in your patch https://www.mail-archive.com/qemu-devel@nongnu.org/msg805595.html by splitting it in multiple trivial changes. At least this way it is easier to me to follow / review what you did. The original patch description was: Add tlb_flush interface for a range of pages. Call these tlb_flush_range_by_mmuidx*. Rewrite the_flush_page_bits_by_mmuidx* to use the new functions, passing in TARGET_PAGE_SIZE for length. If you find it useful, fill free to take / respin / reorder this series, improving descriptions. Last patch certainly deserves a better description ;) Regards, Phil. Richard Henderson (9): accel/tcg: Replace g_new() + memcpy() by g_memdup() accel/tcg: Pass length argument to tlb_flush_range_locked() accel/tlb: Rename TLBFlushPageBitsByMMUIdxData -> TLBFlushRangeData accel/tcg: Add tlb_flush_range_by_mmuidx() accel/tcg: Add tlb_flush_page_bits_by_mmuidx_all_cpus() accel/tlb: Add tlb_flush_range_by_mmuidx_all_cpus_synced() accel/tcg: Rename tlb_flush_page_bits -> range]_by_mmuidx_async_0 accel/tlb: Rename tlb_flush_[page_bits > range]_by_mmuidx_async_[2 > 1] accel/tcg: Remove tlb_flush_page_bits_by_mmuidx_async_1() ??? include/exec/exec-all.h | 44 ++++++++ accel/tcg/cputlb.c | 231 ++++++++++++++++++++-------------------- 2 files changed, 158 insertions(+), 117 deletions(-)