| Message ID | 20190222141024.22217-1-kbastian@mail.uni-paderborn.de |
|---|---|
| Headers | show |
| Series | target/riscv: Convert to decodetree | expand |
On Fri, Feb 22, 2019 at 6:31 AM Bastian Koppelmann <kbastian@mail.uni-paderborn.de> wrote: > > Hi, > > this patchset converts the RISC-V decoder to decodetree in four major steps: > > 1) Convert 32-bit instructions to decodetree [Patch 1-15]: > Many of the gen_* functions are called by the decode functions for 16-bit > and 32-bit functions. If we move translation code from the gen_* > functions to the generated trans_* functions of decode-tree, we get a lot of > duplication. Therefore, we mostly generate calls to the old gen_* function > which are properly replaced after step 2). > > Each of the trans_ functions are grouped into files corresponding to their > ISA extension, e.g. addi which is in RV32I is translated in the file > 'trans_rvi.inc.c'. > > 2) Convert 16-bit instructions to decodetree [Patch 16-18]: > All 16 bit instructions have a direct mapping to a 32 bit instruction. Thus, > we convert the arguments in the 16 bit trans_ function to the arguments of > the corresponding 32 bit instruction and call the 32 bit trans_ function. > > 3) Remove old manual decoding in gen_* function [Patch 19-29]: > this move all manual translation code into the trans_* instructions of > decode tree, such that we can remove the old decode_* functions. > > 4) Simplify RVC by reusing as much as possible from the RVG decoder as suggested > by Richard. [Patch 30-34] > > full tree available at > https://github.com/bkoppelmann/qemu/tree/riscv-dt-v8 > > Cheers, > Bastian Tested-by: Alistair Francis <alistair.francis@wdc.com> I haven't run any strenuous tests, but it boots 32 and 64-bit Linux/openSBI with no issues. Alistair > > v7 -> v8: > - add REQUIRE_EXT macro > - add missing RVM checks > - add missing RVA checks > - add missing RVF checks > - add missing RVF checks > - add missing RVD checks > - add missing RVD checks > - riscv_has_ext -> has_ext > - env->ctx->priv_version -> ctx->priv_version > - fixed wrongly inserted #ifdef TARGET_RISCV64 that lead to a compile error > > > Bastian Koppelmann (34): > target/riscv: Activate decodetree and implemnt LUI & AUIPC > target/riscv: Convert RVXI branch insns to decodetree > target/riscv: Convert RV32I load/store insns to decodetree > target/riscv: Convert RV64I load/store insns to decodetree > target/riscv: Convert RVXI arithmetic insns to decodetree > target/riscv: Convert RVXI fence insns to decodetree > target/riscv: Convert RVXI csr insns to decodetree > target/riscv: Convert RVXM insns to decodetree > target/riscv: Convert RV32A insns to decodetree > target/riscv: Convert RV64A insns to decodetree > target/riscv: Convert RV32F insns to decodetree > target/riscv: Convert RV64F insns to decodetree > target/riscv: Convert RV32D insns to decodetree > target/riscv: Convert RV64D insns to decodetree > target/riscv: Convert RV priv insns to decodetree > target/riscv: Convert quadrant 0 of RVXC insns to decodetree > target/riscv: Convert quadrant 1 of RVXC insns to decodetree > target/riscv: Convert quadrant 2 of RVXC insns to decodetree > target/riscv: Remove gen_jalr() > target/riscv: Remove manual decoding from gen_branch() > target/riscv: Remove manual decoding from gen_load() > target/riscv: Remove manual decoding from gen_store() > target/riscv: Move gen_arith_imm() decoding into trans_* functions > target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists > target/riscv: Remove shift and slt insn manual decoding > target/riscv: Remove manual decoding of RV32/64M insn > target/riscv: Rename trans_arith to gen_arith > target/riscv: Remove gen_system() > target/riscv: Remove decode_RV32_64G() > target/riscv: Convert @cs_2 insns to share translation functions > target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns > target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 > target/riscv: Splice remaining compressed insn pairs for riscv32 vs > riscv64 > target/riscv: Remaining rvc insn reuse 32 bit translators > > target/riscv/Makefile.objs | 22 + > target/riscv/insn16-32.decode | 31 + > target/riscv/insn16-64.decode | 33 + > target/riscv/insn16.decode | 114 + > target/riscv/insn32-64.decode | 72 + > target/riscv/insn32.decode | 203 ++ > .../riscv/insn_trans/trans_privileged.inc.c | 110 + > target/riscv/insn_trans/trans_rva.inc.c | 218 ++ > target/riscv/insn_trans/trans_rvc.inc.c | 149 ++ > target/riscv/insn_trans/trans_rvd.inc.c | 442 ++++ > target/riscv/insn_trans/trans_rvf.inc.c | 439 ++++ > target/riscv/insn_trans/trans_rvi.inc.c | 568 +++++ > target/riscv/insn_trans/trans_rvm.inc.c | 120 + > target/riscv/translate.c | 1948 ++--------------- > 14 files changed, 2740 insertions(+), 1729 deletions(-) > create mode 100644 target/riscv/insn16-32.decode > create mode 100644 target/riscv/insn16-64.decode > create mode 100644 target/riscv/insn16.decode > create mode 100644 target/riscv/insn32-64.decode > create mode 100644 target/riscv/insn32.decode > create mode 100644 target/riscv/insn_trans/trans_privileged.inc.c > create mode 100644 target/riscv/insn_trans/trans_rva.inc.c > create mode 100644 target/riscv/insn_trans/trans_rvc.inc.c > create mode 100644 target/riscv/insn_trans/trans_rvd.inc.c > create mode 100644 target/riscv/insn_trans/trans_rvf.inc.c > create mode 100644 target/riscv/insn_trans/trans_rvi.inc.c > create mode 100644 target/riscv/insn_trans/trans_rvm.inc.c > > -- > 2.20.1 > >
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' ac35998b5f target/riscv: Remaining rvc insn reuse 32 bit translators fffdd9041b target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 3b2bfb2abd target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 a34d23b730 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns bb8dfd6ed7 target/riscv: Convert @cs_2 insns to share translation functions c0c61f9d8e target/riscv: Remove decode_RV32_64G() adc0f7585b target/riscv: Remove gen_system() b50e52513d target/riscv: Rename trans_arith to gen_arith 598980bf8c target/riscv: Remove manual decoding of RV32/64M insn d8796c1854 target/riscv: Remove shift and slt insn manual decoding 59c761aa98 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 7a47a3d21b target/riscv: Move gen_arith_imm() decoding into trans_* functions d15bbff7e3 target/riscv: Remove manual decoding from gen_store() 635e53014b target/riscv: Remove manual decoding from gen_load() 34d4b93fb9 target/riscv: Remove manual decoding from gen_branch() 4759cd1171 target/riscv: Remove gen_jalr() 8a6aac3a76 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 1b744b6717 target/riscv: Convert quadrant 1 of RVXC insns to decodetree b61fe6010f target/riscv: Convert quadrant 0 of RVXC insns to decodetree 619ad5f255 target/riscv: Convert RV priv insns to decodetree 03d125944f target/riscv: Convert RV64D insns to decodetree da9d960928 target/riscv: Convert RV32D insns to decodetree d8611eee8f target/riscv: Convert RV64F insns to decodetree 2e3f999836 target/riscv: Convert RV32F insns to decodetree befeb7f0dd target/riscv: Convert RV64A insns to decodetree 08e313732e target/riscv: Convert RV32A insns to decodetree 3f454da12d target/riscv: Convert RVXM insns to decodetree 70ef3d6037 target/riscv: Convert RVXI csr insns to decodetree a64bd0dc62 target/riscv: Convert RVXI fence insns to decodetree 311a9ba90e target/riscv: Convert RVXI arithmetic insns to decodetree c1282a4b41 target/riscv: Convert RV64I load/store insns to decodetree 7b9ca3e6aa target/riscv: Convert RV32I load/store insns to decodetree f1f8874efb target/riscv: Convert RVXI branch insns to decodetree 05ea102cd4 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 05ea102cd4f4 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit f1f8874efb91 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 7b9ca3e6aa9a (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit c1282a4b4113 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 311a9ba90e2e (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit a64bd0dc62b4 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 70ef3d6037ff (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 3f454da12deb (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 08e313732e44 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit befeb7f0ddb0 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 2e3f9998360e (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit d8611eee8f6c (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit da9d960928a2 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 03d125944f1b (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 619ad5f255a8 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit b61fe6010f2b (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 1b744b67176c (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 8a6aac3a76af (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 4759cd1171fb (target/riscv: Remove gen_jalr()) 20/34 Checking commit 34d4b93fb960 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 635e53014bb2 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit d15bbff7e3a6 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 7a47a3d21b5a (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 59c761aa9850 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit d8796c185490 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 598980bf8c27 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit b50e52513d9c (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit adc0f7585bf0 (target/riscv: Remove gen_system()) 29/34 Checking commit c0c61f9d8e16 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit bb8dfd6ed7b5 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit a34d23b730c9 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 3b2bfb2abda1 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit fffdd9041b4b (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit ac35998b5fba (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 09b35e6bec target/riscv: Remaining rvc insn reuse 32 bit translators 001fe873bc target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 a233183c14 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 4f333d9439 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 0f4ab1f666 target/riscv: Convert @cs_2 insns to share translation functions 277ad6ab96 target/riscv: Remove decode_RV32_64G() 79d8ceccaf target/riscv: Remove gen_system() a1336175d2 target/riscv: Rename trans_arith to gen_arith 31966a003b target/riscv: Remove manual decoding of RV32/64M insn 8b5f580fd4 target/riscv: Remove shift and slt insn manual decoding f16828a0f7 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 515b6c01e9 target/riscv: Move gen_arith_imm() decoding into trans_* functions dfee899202 target/riscv: Remove manual decoding from gen_store() 039f2bcac3 target/riscv: Remove manual decoding from gen_load() 15938cf110 target/riscv: Remove manual decoding from gen_branch() 7d81140be9 target/riscv: Remove gen_jalr() 885dcaa352 target/riscv: Convert quadrant 2 of RVXC insns to decodetree e3ef6243f2 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 101218ffcc target/riscv: Convert quadrant 0 of RVXC insns to decodetree 61980f056c target/riscv: Convert RV priv insns to decodetree bcbf122a87 target/riscv: Convert RV64D insns to decodetree cf608b7d11 target/riscv: Convert RV32D insns to decodetree 3ecdf7cee6 target/riscv: Convert RV64F insns to decodetree 5e2438c3f4 target/riscv: Convert RV32F insns to decodetree 71e4c269db target/riscv: Convert RV64A insns to decodetree b0fb34ef71 target/riscv: Convert RV32A insns to decodetree 177e3a4c9a target/riscv: Convert RVXM insns to decodetree a2ba9f9139 target/riscv: Convert RVXI csr insns to decodetree ddcde05e3c target/riscv: Convert RVXI fence insns to decodetree 8934da9b82 target/riscv: Convert RVXI arithmetic insns to decodetree 0724cbdcba target/riscv: Convert RV64I load/store insns to decodetree 6f697969fa target/riscv: Convert RV32I load/store insns to decodetree 5328de79e7 target/riscv: Convert RVXI branch insns to decodetree e0ffebaa16 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit e0ffebaa16bd (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 5328de79e736 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 6f697969fa15 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 0724cbdcbaa6 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 8934da9b824b (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit ddcde05e3c48 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit a2ba9f913931 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 177e3a4c9a61 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit b0fb34ef7176 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 71e4c269dbda (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 5e2438c3f44a (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 3ecdf7cee665 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit cf608b7d1117 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit bcbf122a87ac (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 61980f056c20 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 101218ffcc3d (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit e3ef6243f218 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 885dcaa352d1 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 7d81140be949 (target/riscv: Remove gen_jalr()) 20/34 Checking commit 15938cf11007 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 039f2bcac3c2 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit dfee89920297 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 515b6c01e924 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit f16828a0f7ed (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 8b5f580fd46b (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 31966a003bde (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit a1336175d24c (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 79d8ceccaf5d (target/riscv: Remove gen_system()) 29/34 Checking commit 277ad6ab9638 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 0f4ab1f666f7 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 4f333d9439c6 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit a233183c1455 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 001fe873bcd5 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 09b35e6becf0 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 6ff2674d6d target/riscv: Remaining rvc insn reuse 32 bit translators 69cfc476d2 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 a79d96ef4f target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 e21ef3efe4 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns ab13d11898 target/riscv: Convert @cs_2 insns to share translation functions 19a398fcf2 target/riscv: Remove decode_RV32_64G() e5d2d8de1b target/riscv: Remove gen_system() dd1af1569c target/riscv: Rename trans_arith to gen_arith 927ff74675 target/riscv: Remove manual decoding of RV32/64M insn 822b6f55c2 target/riscv: Remove shift and slt insn manual decoding 482da1143e target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 071d1ed649 target/riscv: Move gen_arith_imm() decoding into trans_* functions 0165b0c416 target/riscv: Remove manual decoding from gen_store() 62fd962e29 target/riscv: Remove manual decoding from gen_load() 0ab2c1ea49 target/riscv: Remove manual decoding from gen_branch() acd0d70808 target/riscv: Remove gen_jalr() ad0cbd0254 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 2567da5766 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 60890225d8 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 5bd130a674 target/riscv: Convert RV priv insns to decodetree 10d62bd46c target/riscv: Convert RV64D insns to decodetree 65a093bf38 target/riscv: Convert RV32D insns to decodetree c4f65e1838 target/riscv: Convert RV64F insns to decodetree 6686b81cb9 target/riscv: Convert RV32F insns to decodetree 15ea4f2414 target/riscv: Convert RV64A insns to decodetree 17d3abd7df target/riscv: Convert RV32A insns to decodetree 32e56b1dcf target/riscv: Convert RVXM insns to decodetree 8a5f659685 target/riscv: Convert RVXI csr insns to decodetree 1656880ea1 target/riscv: Convert RVXI fence insns to decodetree 0daef37d04 target/riscv: Convert RVXI arithmetic insns to decodetree cae0f3ea6a target/riscv: Convert RV64I load/store insns to decodetree 638fd049d7 target/riscv: Convert RV32I load/store insns to decodetree 4e9f599f10 target/riscv: Convert RVXI branch insns to decodetree 9af3b29d8f target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 9af3b29d8f7d (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 4e9f599f1041 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 638fd049d74d (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit cae0f3ea6a4e (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 0daef37d049d (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 1656880ea1cd (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 8a5f6596850a (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 32e56b1dcffd (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 17d3abd7df2d (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 15ea4f241437 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 6686b81cb9ed (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit c4f65e18387e (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 65a093bf3820 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 10d62bd46c0b (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 5bd130a67401 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 60890225d8b0 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 2567da57663f (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit ad0cbd02544f (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit acd0d70808ce (target/riscv: Remove gen_jalr()) 20/34 Checking commit 0ab2c1ea499d (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 62fd962e29e0 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 0165b0c41687 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 071d1ed64975 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 482da1143e3b (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 822b6f55c23d (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 927ff7467572 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit dd1af1569c16 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit e5d2d8de1bdd (target/riscv: Remove gen_system()) 29/34 Checking commit 19a398fcf253 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit ab13d11898f6 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit e21ef3efe491 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit a79d96ef4f7b (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 69cfc476d22a (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 6ff2674d6d3e (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' e2a93498c7 target/riscv: Remaining rvc insn reuse 32 bit translators 3f59fb9099 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 c3ad74f61a target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 b9d6ccca81 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 07776db255 target/riscv: Convert @cs_2 insns to share translation functions bbeb07d1c1 target/riscv: Remove decode_RV32_64G() 8c8e0054b7 target/riscv: Remove gen_system() e878cb4757 target/riscv: Rename trans_arith to gen_arith e9bf9ba1ef target/riscv: Remove manual decoding of RV32/64M insn 7d02316889 target/riscv: Remove shift and slt insn manual decoding 4779f009ef target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 0becb12c06 target/riscv: Move gen_arith_imm() decoding into trans_* functions 6934b41240 target/riscv: Remove manual decoding from gen_store() f40c582d09 target/riscv: Remove manual decoding from gen_load() 3257410d02 target/riscv: Remove manual decoding from gen_branch() 68963c7308 target/riscv: Remove gen_jalr() 351570bad7 target/riscv: Convert quadrant 2 of RVXC insns to decodetree dc7cacdecf target/riscv: Convert quadrant 1 of RVXC insns to decodetree 3c963274bc target/riscv: Convert quadrant 0 of RVXC insns to decodetree ae87b5ebb4 target/riscv: Convert RV priv insns to decodetree 67b8d1c9ab target/riscv: Convert RV64D insns to decodetree 3dbfe2e6d2 target/riscv: Convert RV32D insns to decodetree a6305e03b3 target/riscv: Convert RV64F insns to decodetree 93300752fd target/riscv: Convert RV32F insns to decodetree ab18a012c2 target/riscv: Convert RV64A insns to decodetree 3a9341dd5f target/riscv: Convert RV32A insns to decodetree 4f8f8626aa target/riscv: Convert RVXM insns to decodetree e97b251f74 target/riscv: Convert RVXI csr insns to decodetree 2e9fa3a07a target/riscv: Convert RVXI fence insns to decodetree d63e9306d1 target/riscv: Convert RVXI arithmetic insns to decodetree 79cbd6c743 target/riscv: Convert RV64I load/store insns to decodetree c3af671a8f target/riscv: Convert RV32I load/store insns to decodetree ea9489de9b target/riscv: Convert RVXI branch insns to decodetree ce8dc97c46 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit ce8dc97c46f0 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit ea9489de9be2 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit c3af671a8f6f (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 79cbd6c7434d (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit d63e9306d19a (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 2e9fa3a07aca (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit e97b251f7436 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 4f8f8626aacc (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 3a9341dd5f2f (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit ab18a012c2d8 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 93300752fdaf (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit a6305e03b3cc (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 3dbfe2e6d24b (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 67b8d1c9ab86 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit ae87b5ebb451 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 3c963274bcda (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit dc7cacdecf57 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 351570bad75b (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 68963c730858 (target/riscv: Remove gen_jalr()) 20/34 Checking commit 3257410d028f (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit f40c582d0941 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 6934b412409c (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 0becb12c0675 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 4779f009ef4a (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 7d0231688996 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit e9bf9ba1efe6 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit e878cb475771 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 8c8e0054b785 (target/riscv: Remove gen_system()) 29/34 Checking commit bbeb07d1c14f (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 07776db25587 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit b9d6ccca8132 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit c3ad74f61ad1 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 3f59fb90995b (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit e2a93498c7fd (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 28cd3c4e01 target/riscv: Remaining rvc insn reuse 32 bit translators db8685ead5 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 cf234b4e98 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 c78ee6eb34 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 917f362553 target/riscv: Convert @cs_2 insns to share translation functions 7d5869fe83 target/riscv: Remove decode_RV32_64G() 76f5f035f1 target/riscv: Remove gen_system() 375b4b15f5 target/riscv: Rename trans_arith to gen_arith 41e910df32 target/riscv: Remove manual decoding of RV32/64M insn ebc811a04f target/riscv: Remove shift and slt insn manual decoding a58503eb20 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 7b2d9c4ba9 target/riscv: Move gen_arith_imm() decoding into trans_* functions 5c4ceeb7eb target/riscv: Remove manual decoding from gen_store() 6f01cea928 target/riscv: Remove manual decoding from gen_load() 1b464700f0 target/riscv: Remove manual decoding from gen_branch() 37c351dc1f target/riscv: Remove gen_jalr() 44148247a4 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 9860af10ce target/riscv: Convert quadrant 1 of RVXC insns to decodetree 98a034a5cd target/riscv: Convert quadrant 0 of RVXC insns to decodetree d85452cbc3 target/riscv: Convert RV priv insns to decodetree 597f79d06e target/riscv: Convert RV64D insns to decodetree 3b4f3b8cde target/riscv: Convert RV32D insns to decodetree a9cc520dfd target/riscv: Convert RV64F insns to decodetree d3fcf4468a target/riscv: Convert RV32F insns to decodetree 6d4401451b target/riscv: Convert RV64A insns to decodetree cc260b2d08 target/riscv: Convert RV32A insns to decodetree 606da2d9b8 target/riscv: Convert RVXM insns to decodetree 5238cdf1ec target/riscv: Convert RVXI csr insns to decodetree e3063e377e target/riscv: Convert RVXI fence insns to decodetree 638674dbc4 target/riscv: Convert RVXI arithmetic insns to decodetree 2fae598d65 target/riscv: Convert RV64I load/store insns to decodetree 44b8014fde target/riscv: Convert RV32I load/store insns to decodetree 359c51b5f4 target/riscv: Convert RVXI branch insns to decodetree 12375de48a target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 12375de48a1c (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 359c51b5f4db (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 44b8014fde1d (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 2fae598d650f (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 638674dbc45b (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit e3063e377e09 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 5238cdf1ec11 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 606da2d9b8b4 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit cc260b2d0894 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 6d4401451b33 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit d3fcf4468a89 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit a9cc520dfd60 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 3b4f3b8cde6a (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 597f79d06e01 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit d85452cbc30f (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 98a034a5cdbd (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 9860af10cedc (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 44148247a47b (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 37c351dc1f86 (target/riscv: Remove gen_jalr()) 20/34 Checking commit 1b464700f066 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 6f01cea92849 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 5c4ceeb7eb44 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 7b2d9c4ba9f6 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit a58503eb20e9 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit ebc811a04fe1 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 41e910df3275 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 375b4b15f579 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 76f5f035f145 (target/riscv: Remove gen_system()) 29/34 Checking commit 7d5869fe838f (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 917f362553d0 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit c78ee6eb342e (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit cf234b4e9825 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit db8685ead54d (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 28cd3c4e01bd (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 5bd083629e target/riscv: Remaining rvc insn reuse 32 bit translators 5d72035128 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 6efccbbf2a target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 d6cf7db52b target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 3766a76f4d target/riscv: Convert @cs_2 insns to share translation functions 4846b3b328 target/riscv: Remove decode_RV32_64G() 0efdd389e2 target/riscv: Remove gen_system() 1097339ff1 target/riscv: Rename trans_arith to gen_arith d518ed9ce5 target/riscv: Remove manual decoding of RV32/64M insn cf2623e4b3 target/riscv: Remove shift and slt insn manual decoding 2635d088f7 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 6f2c427160 target/riscv: Move gen_arith_imm() decoding into trans_* functions 596eac69db target/riscv: Remove manual decoding from gen_store() fbe9c08387 target/riscv: Remove manual decoding from gen_load() 211fa9a152 target/riscv: Remove manual decoding from gen_branch() 4ed5565c22 target/riscv: Remove gen_jalr() c847376422 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 9e3cc3766e target/riscv: Convert quadrant 1 of RVXC insns to decodetree 651687752b target/riscv: Convert quadrant 0 of RVXC insns to decodetree 58fa4668be target/riscv: Convert RV priv insns to decodetree d73e26f036 target/riscv: Convert RV64D insns to decodetree ad0be02a09 target/riscv: Convert RV32D insns to decodetree 10ed1c1d9b target/riscv: Convert RV64F insns to decodetree b362a9b73c target/riscv: Convert RV32F insns to decodetree 07503d6299 target/riscv: Convert RV64A insns to decodetree d6d96c8381 target/riscv: Convert RV32A insns to decodetree 6af83fc00f target/riscv: Convert RVXM insns to decodetree bb39198396 target/riscv: Convert RVXI csr insns to decodetree a18e334328 target/riscv: Convert RVXI fence insns to decodetree 84adb8041d target/riscv: Convert RVXI arithmetic insns to decodetree 0a2859982c target/riscv: Convert RV64I load/store insns to decodetree f931362647 target/riscv: Convert RV32I load/store insns to decodetree 193ee2c237 target/riscv: Convert RVXI branch insns to decodetree cc59f4df66 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit cc59f4df66ac (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 193ee2c237c0 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit f9313626470d (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 0a2859982c91 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 84adb8041d3b (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit a18e33432833 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit bb3919839612 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 6af83fc00f55 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit d6d96c838102 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 07503d6299f8 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit b362a9b73c2e (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 10ed1c1d9b25 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit ad0be02a0922 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit d73e26f0361e (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 58fa4668be36 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 651687752b1a (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 9e3cc3766ee8 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit c8473764223a (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 4ed5565c22d6 (target/riscv: Remove gen_jalr()) 20/34 Checking commit 211fa9a15238 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit fbe9c08387c3 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 596eac69dbd9 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 6f2c42716035 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 2635d088f707 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit cf2623e4b3df (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit d518ed9ce5c9 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 1097339ff18d (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 0efdd389e281 (target/riscv: Remove gen_system()) 29/34 Checking commit 4846b3b328ee (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 3766a76f4d1a (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit d6cf7db52bbb (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 6efccbbf2a77 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 5d720351288e (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 5bd083629e0f (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 0e1587d723 target/riscv: Remaining rvc insn reuse 32 bit translators 03bc36d2a9 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 0c1098fa38 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 14f6a21758 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns dd6471d6df target/riscv: Convert @cs_2 insns to share translation functions 9022d237a1 target/riscv: Remove decode_RV32_64G() b3bf7e853b target/riscv: Remove gen_system() 8dafe332ee target/riscv: Rename trans_arith to gen_arith e536c49e42 target/riscv: Remove manual decoding of RV32/64M insn a78e0a5ae9 target/riscv: Remove shift and slt insn manual decoding 914e794eb6 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists c05621056a target/riscv: Move gen_arith_imm() decoding into trans_* functions 259f1fb44c target/riscv: Remove manual decoding from gen_store() f36994b013 target/riscv: Remove manual decoding from gen_load() 7898ebce3c target/riscv: Remove manual decoding from gen_branch() ef4f4af849 target/riscv: Remove gen_jalr() 2b5566b964 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 91de7453ce target/riscv: Convert quadrant 1 of RVXC insns to decodetree 2b6dada763 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 2b6165d18b target/riscv: Convert RV priv insns to decodetree 7dc8515d50 target/riscv: Convert RV64D insns to decodetree f8d03d52f4 target/riscv: Convert RV32D insns to decodetree 82662002b1 target/riscv: Convert RV64F insns to decodetree f61b8a780c target/riscv: Convert RV32F insns to decodetree db1a6df36a target/riscv: Convert RV64A insns to decodetree 73fad6f884 target/riscv: Convert RV32A insns to decodetree f10eed5487 target/riscv: Convert RVXM insns to decodetree d5af3ac930 target/riscv: Convert RVXI csr insns to decodetree b7b400c906 target/riscv: Convert RVXI fence insns to decodetree 22a796ba2f target/riscv: Convert RVXI arithmetic insns to decodetree fa09efd852 target/riscv: Convert RV64I load/store insns to decodetree 30155f3443 target/riscv: Convert RV32I load/store insns to decodetree 654ff5f0ec target/riscv: Convert RVXI branch insns to decodetree fd945bbb5b target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit fd945bbb5b4a (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 654ff5f0ecfc (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 30155f344314 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit fa09efd852b6 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 22a796ba2fb3 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit b7b400c9063a (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit d5af3ac93078 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit f10eed548794 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 73fad6f88456 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit db1a6df36a27 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit f61b8a780c37 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 82662002b162 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit f8d03d52f4c4 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 7dc8515d5033 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 2b6165d18b87 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 2b6dada76333 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 91de7453ce87 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 2b5566b96498 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit ef4f4af849b6 (target/riscv: Remove gen_jalr()) 20/34 Checking commit 7898ebce3cd2 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit f36994b0132f (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 259f1fb44ca1 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit c05621056ac7 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 914e794eb635 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit a78e0a5ae9fe (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit e536c49e42d9 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 8dafe332ee78 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit b3bf7e853b17 (target/riscv: Remove gen_system()) 29/34 Checking commit 9022d237a128 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit dd6471d6dfb9 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 14f6a21758ed (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 0c1098fa3841 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 03bc36d2a9a5 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 0e1587d7236a (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 432ee0f2a6 target/riscv: Remaining rvc insn reuse 32 bit translators 3edd14104b target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 223763f086 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 13d60b86f4 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns a0289ca337 target/riscv: Convert @cs_2 insns to share translation functions ef522747fd target/riscv: Remove decode_RV32_64G() 85c176769e target/riscv: Remove gen_system() 7b34c983de target/riscv: Rename trans_arith to gen_arith 3a6d045bea target/riscv: Remove manual decoding of RV32/64M insn 2f6beda13a target/riscv: Remove shift and slt insn manual decoding 9f442e944f target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 743eb3f285 target/riscv: Move gen_arith_imm() decoding into trans_* functions c377ab03d7 target/riscv: Remove manual decoding from gen_store() fe109c44bf target/riscv: Remove manual decoding from gen_load() 9ed52a1acb target/riscv: Remove manual decoding from gen_branch() 0917e89654 target/riscv: Remove gen_jalr() 91ade066d2 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 2c3b66936b target/riscv: Convert quadrant 1 of RVXC insns to decodetree 415e1ab915 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 9af30b4ccc target/riscv: Convert RV priv insns to decodetree 6df8192460 target/riscv: Convert RV64D insns to decodetree 540cd30357 target/riscv: Convert RV32D insns to decodetree 349a03247b target/riscv: Convert RV64F insns to decodetree 3315cb9514 target/riscv: Convert RV32F insns to decodetree 83143afeeb target/riscv: Convert RV64A insns to decodetree 5c2c378e76 target/riscv: Convert RV32A insns to decodetree dffbc3ab8f target/riscv: Convert RVXM insns to decodetree 8ace59a497 target/riscv: Convert RVXI csr insns to decodetree 5cc01544c1 target/riscv: Convert RVXI fence insns to decodetree 080e8e5535 target/riscv: Convert RVXI arithmetic insns to decodetree 8db7ada69f target/riscv: Convert RV64I load/store insns to decodetree 478bc672cd target/riscv: Convert RV32I load/store insns to decodetree cc5a92abae target/riscv: Convert RVXI branch insns to decodetree ae105ec4ed target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit ae105ec4ed93 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit cc5a92abae27 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 478bc672cdfa (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 8db7ada69f10 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 080e8e5535ec (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 5cc01544c1cb (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 8ace59a49753 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit dffbc3ab8f11 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 5c2c378e7675 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 83143afeebaa (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 3315cb95145c (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 349a03247b89 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 540cd303579b (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 6df81924601e (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 9af30b4ccc98 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 415e1ab9157d (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 2c3b66936b2e (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 91ade066d2aa (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 0917e8965420 (target/riscv: Remove gen_jalr()) 20/34 Checking commit 9ed52a1acba2 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit fe109c44bf20 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit c377ab03d7ef (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 743eb3f28565 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 9f442e944fe7 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 2f6beda13a13 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 3a6d045bea37 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 7b34c983dec7 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 85c176769e6b (target/riscv: Remove gen_system()) 29/34 Checking commit ef522747fdcd (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit a0289ca33792 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 13d60b86f407 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 223763f0863b (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 3edd14104b4c (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 432ee0f2a660 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 2bccd31307 target/riscv: Remaining rvc insn reuse 32 bit translators 0f7a90f92e target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 d280cf9975 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 e07932137e target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns ecc8d2c072 target/riscv: Convert @cs_2 insns to share translation functions 0afeac566c target/riscv: Remove decode_RV32_64G() b8d3653c5f target/riscv: Remove gen_system() 49a817f32f target/riscv: Rename trans_arith to gen_arith c052fba9fb target/riscv: Remove manual decoding of RV32/64M insn fc201c16cc target/riscv: Remove shift and slt insn manual decoding 6d4f8b0140 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 31176cd07a target/riscv: Move gen_arith_imm() decoding into trans_* functions a98f088a24 target/riscv: Remove manual decoding from gen_store() d41b2728e0 target/riscv: Remove manual decoding from gen_load() 78d9069947 target/riscv: Remove manual decoding from gen_branch() c7c365c8dc target/riscv: Remove gen_jalr() a4f18a22cf target/riscv: Convert quadrant 2 of RVXC insns to decodetree ce66c130b4 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 291a35ae2b target/riscv: Convert quadrant 0 of RVXC insns to decodetree 47d163aea4 target/riscv: Convert RV priv insns to decodetree 78dd2af4fa target/riscv: Convert RV64D insns to decodetree d2c318df64 target/riscv: Convert RV32D insns to decodetree 496076a9ce target/riscv: Convert RV64F insns to decodetree 3ac0ac0c5e target/riscv: Convert RV32F insns to decodetree 5170d58ec1 target/riscv: Convert RV64A insns to decodetree ebdae9e69a target/riscv: Convert RV32A insns to decodetree 00740fadcb target/riscv: Convert RVXM insns to decodetree 6575067a23 target/riscv: Convert RVXI csr insns to decodetree 32b7b1f5ba target/riscv: Convert RVXI fence insns to decodetree 37bbf949f0 target/riscv: Convert RVXI arithmetic insns to decodetree 7a9c48e2f3 target/riscv: Convert RV64I load/store insns to decodetree 3f90cfa25f target/riscv: Convert RV32I load/store insns to decodetree 90d544ab68 target/riscv: Convert RVXI branch insns to decodetree 9685b5d011 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 9685b5d011e8 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 90d544ab6835 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 3f90cfa25f76 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 7a9c48e2f3be (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 37bbf949f054 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 32b7b1f5ba5c (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 6575067a2365 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 00740fadcb65 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit ebdae9e69abd (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 5170d58ec187 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 3ac0ac0c5eab (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 496076a9ceb5 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit d2c318df64d7 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 78dd2af4fa05 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 47d163aea496 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 291a35ae2b9c (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit ce66c130b495 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit a4f18a22cf1a (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit c7c365c8dc0c (target/riscv: Remove gen_jalr()) 20/34 Checking commit 78d90699477b (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit d41b2728e07f (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit a98f088a24fd (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 31176cd07a8c (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 6d4f8b01403b (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit fc201c16ccee (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit c052fba9fb87 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 49a817f32f33 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit b8d3653c5f0e (target/riscv: Remove gen_system()) 29/34 Checking commit 0afeac566c6f (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit ecc8d2c072f5 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit e07932137eca (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit d280cf997594 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 0f7a90f92ef0 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 2bccd31307cb (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 5151e227ca target/riscv: Remaining rvc insn reuse 32 bit translators ab29232b07 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 574a876a74 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 1cd5ba7c9d target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 1fee8e7fd2 target/riscv: Convert @cs_2 insns to share translation functions 3580ae8151 target/riscv: Remove decode_RV32_64G() 3794409d29 target/riscv: Remove gen_system() f5781a75a0 target/riscv: Rename trans_arith to gen_arith e94963588c target/riscv: Remove manual decoding of RV32/64M insn 06881e800c target/riscv: Remove shift and slt insn manual decoding 82a7df5c19 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists a4e3383293 target/riscv: Move gen_arith_imm() decoding into trans_* functions fd78f76f5d target/riscv: Remove manual decoding from gen_store() ffe7f21c63 target/riscv: Remove manual decoding from gen_load() 524109932e target/riscv: Remove manual decoding from gen_branch() 2ecee20041 target/riscv: Remove gen_jalr() 42e5d8cc41 target/riscv: Convert quadrant 2 of RVXC insns to decodetree a04293c3d8 target/riscv: Convert quadrant 1 of RVXC insns to decodetree edfb43ad65 target/riscv: Convert quadrant 0 of RVXC insns to decodetree ceef6fd959 target/riscv: Convert RV priv insns to decodetree 7ebb8921af target/riscv: Convert RV64D insns to decodetree eea48fec16 target/riscv: Convert RV32D insns to decodetree 43a8ecfb50 target/riscv: Convert RV64F insns to decodetree cb07a6f179 target/riscv: Convert RV32F insns to decodetree 52a7560c45 target/riscv: Convert RV64A insns to decodetree 67af82888e target/riscv: Convert RV32A insns to decodetree 2ee948d423 target/riscv: Convert RVXM insns to decodetree d31956cb65 target/riscv: Convert RVXI csr insns to decodetree 8899edc648 target/riscv: Convert RVXI fence insns to decodetree f909ec4291 target/riscv: Convert RVXI arithmetic insns to decodetree 4b0cf0d671 target/riscv: Convert RV64I load/store insns to decodetree 7ffa0b6fee target/riscv: Convert RV32I load/store insns to decodetree 137f154684 target/riscv: Convert RVXI branch insns to decodetree 6df0248170 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 6df024817084 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 137f1546842d (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 7ffa0b6feeba (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 4b0cf0d671ea (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit f909ec429144 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 8899edc64836 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit d31956cb658a (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 2ee948d4232d (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 67af82888e6a (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 52a7560c4520 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit cb07a6f17966 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 43a8ecfb5028 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit eea48fec1653 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 7ebb8921af68 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit ceef6fd9591f (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit edfb43ad6505 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit a04293c3d834 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 42e5d8cc4162 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 2ecee2004173 (target/riscv: Remove gen_jalr()) 20/34 Checking commit 524109932ec8 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit ffe7f21c63ef (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit fd78f76f5ded (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit a4e338329341 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 82a7df5c19c7 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 06881e800c4c (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit e94963588c2c (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit f5781a75a00d (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 3794409d292a (target/riscv: Remove gen_system()) 29/34 Checking commit 3580ae81511d (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 1fee8e7fd29c (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 1cd5ba7c9d3e (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 574a876a748c (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit ab29232b0705 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 5151e227ca32 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 79d073df01 target/riscv: Remaining rvc insn reuse 32 bit translators 149a4e77e7 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 c378cd6332 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 c2f98fed12 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns d0651d3ced target/riscv: Convert @cs_2 insns to share translation functions 5c1ce86bf7 target/riscv: Remove decode_RV32_64G() 1252c0978f target/riscv: Remove gen_system() 9de09ac79d target/riscv: Rename trans_arith to gen_arith f0b34b5843 target/riscv: Remove manual decoding of RV32/64M insn bfa8a3fdf7 target/riscv: Remove shift and slt insn manual decoding acf34a297c target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 57547a0f0d target/riscv: Move gen_arith_imm() decoding into trans_* functions cca0e9bc81 target/riscv: Remove manual decoding from gen_store() 18873e6110 target/riscv: Remove manual decoding from gen_load() bd963236b9 target/riscv: Remove manual decoding from gen_branch() 0caa845fcc target/riscv: Remove gen_jalr() b753bbf2f3 target/riscv: Convert quadrant 2 of RVXC insns to decodetree e13984b314 target/riscv: Convert quadrant 1 of RVXC insns to decodetree c26e3fb706 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 1fba6972de target/riscv: Convert RV priv insns to decodetree 76465c2a96 target/riscv: Convert RV64D insns to decodetree 0e2c2360fc target/riscv: Convert RV32D insns to decodetree f65c343c00 target/riscv: Convert RV64F insns to decodetree eb79c070af target/riscv: Convert RV32F insns to decodetree 1672d35f94 target/riscv: Convert RV64A insns to decodetree bba2c8eee0 target/riscv: Convert RV32A insns to decodetree dfafa8effa target/riscv: Convert RVXM insns to decodetree e6a9b9eb65 target/riscv: Convert RVXI csr insns to decodetree 2816db131b target/riscv: Convert RVXI fence insns to decodetree e1eb41a99d target/riscv: Convert RVXI arithmetic insns to decodetree c2bb7bb14c target/riscv: Convert RV64I load/store insns to decodetree 4d300c477c target/riscv: Convert RV32I load/store insns to decodetree d3a535d4bd target/riscv: Convert RVXI branch insns to decodetree 24ce3b7417 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 24ce3b7417f1 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit d3a535d4bd44 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 4d300c477c0b (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit c2bb7bb14cd7 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit e1eb41a99dd5 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 2816db131b63 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit e6a9b9eb652d (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit dfafa8effa70 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit bba2c8eee088 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 1672d35f9405 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit eb79c070af0b (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit f65c343c002e (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 0e2c2360fce4 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 76465c2a96a8 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 1fba6972dea7 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit c26e3fb70684 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit e13984b314bd (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit b753bbf2f36f (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 0caa845fcc38 (target/riscv: Remove gen_jalr()) 20/34 Checking commit bd963236b905 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 18873e6110e2 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit cca0e9bc81ce (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 57547a0f0d4f (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit acf34a297c4e (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit bfa8a3fdf72b (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit f0b34b584344 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 9de09ac79d0c (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 1252c0978f40 (target/riscv: Remove gen_system()) 29/34 Checking commit 5c1ce86bf7d1 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit d0651d3ced6a (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit c2f98fed12a3 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit c378cd63324f (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 149a4e77e75e (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 79d073df013a (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 37bb85441f target/riscv: Remaining rvc insn reuse 32 bit translators 9eb32177f0 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 7127800787 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 7b1f42f401 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns a17458b518 target/riscv: Convert @cs_2 insns to share translation functions 052d012b95 target/riscv: Remove decode_RV32_64G() c3fcde7f93 target/riscv: Remove gen_system() 082e98ca6c target/riscv: Rename trans_arith to gen_arith e687672603 target/riscv: Remove manual decoding of RV32/64M insn e5b15ba5a8 target/riscv: Remove shift and slt insn manual decoding a85fe50403 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 67a677b8f7 target/riscv: Move gen_arith_imm() decoding into trans_* functions 68428dc7de target/riscv: Remove manual decoding from gen_store() cac91cc71c target/riscv: Remove manual decoding from gen_load() c7341df853 target/riscv: Remove manual decoding from gen_branch() b726b0d129 target/riscv: Remove gen_jalr() 16ccf55b2f target/riscv: Convert quadrant 2 of RVXC insns to decodetree ffe4128236 target/riscv: Convert quadrant 1 of RVXC insns to decodetree d20056d590 target/riscv: Convert quadrant 0 of RVXC insns to decodetree a509f822ba target/riscv: Convert RV priv insns to decodetree bbb45d6628 target/riscv: Convert RV64D insns to decodetree 0dfa35a520 target/riscv: Convert RV32D insns to decodetree 5e4455e54b target/riscv: Convert RV64F insns to decodetree e8461667df target/riscv: Convert RV32F insns to decodetree d198f61b95 target/riscv: Convert RV64A insns to decodetree 5c250c9d43 target/riscv: Convert RV32A insns to decodetree 08eb4cf836 target/riscv: Convert RVXM insns to decodetree 9c29fd0ad6 target/riscv: Convert RVXI csr insns to decodetree 8ba0e0e6ea target/riscv: Convert RVXI fence insns to decodetree 424a350d9b target/riscv: Convert RVXI arithmetic insns to decodetree 7cd95a6fb2 target/riscv: Convert RV64I load/store insns to decodetree 200460b9a9 target/riscv: Convert RV32I load/store insns to decodetree f0ada4c256 target/riscv: Convert RVXI branch insns to decodetree d648923d68 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit d648923d684d (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit f0ada4c2565e (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 200460b9a95f (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 7cd95a6fb2e4 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 424a350d9b21 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 8ba0e0e6eaec (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 9c29fd0ad64f (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 08eb4cf836a1 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 5c250c9d43de (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit d198f61b95a4 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit e8461667dfd7 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 5e4455e54bf6 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 0dfa35a52067 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit bbb45d662815 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit a509f822ba82 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit d20056d59070 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit ffe4128236d5 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 16ccf55b2f43 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit b726b0d129e1 (target/riscv: Remove gen_jalr()) 20/34 Checking commit c7341df85382 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit cac91cc71c79 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 68428dc7de6e (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 67a677b8f77f (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit a85fe50403fc (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit e5b15ba5a8a7 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit e687672603f5 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 082e98ca6c4f (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit c3fcde7f93dd (target/riscv: Remove gen_system()) 29/34 Checking commit 052d012b957f (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit a17458b5189e (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 7b1f42f40175 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 7127800787a7 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 9eb32177f092 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 37bb85441fe0 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' aefaa6d27f target/riscv: Remaining rvc insn reuse 32 bit translators 7d38b6a3a6 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 e7c4cef989 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 acd1bd17bc target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 773c114e21 target/riscv: Convert @cs_2 insns to share translation functions 820409bf26 target/riscv: Remove decode_RV32_64G() d9b6c4fbf1 target/riscv: Remove gen_system() b710a729d4 target/riscv: Rename trans_arith to gen_arith d0889eee71 target/riscv: Remove manual decoding of RV32/64M insn 13c3ed811a target/riscv: Remove shift and slt insn manual decoding 68260932ac target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists c97f381c73 target/riscv: Move gen_arith_imm() decoding into trans_* functions 5f07685572 target/riscv: Remove manual decoding from gen_store() 06f8936794 target/riscv: Remove manual decoding from gen_load() fcffa51cc7 target/riscv: Remove manual decoding from gen_branch() 71d2bfc56a target/riscv: Remove gen_jalr() 67acb3a13a target/riscv: Convert quadrant 2 of RVXC insns to decodetree 667b7025a2 target/riscv: Convert quadrant 1 of RVXC insns to decodetree a6a54cd665 target/riscv: Convert quadrant 0 of RVXC insns to decodetree aaafc94d51 target/riscv: Convert RV priv insns to decodetree 93022dd55c target/riscv: Convert RV64D insns to decodetree d1161d5230 target/riscv: Convert RV32D insns to decodetree 3e90fd0856 target/riscv: Convert RV64F insns to decodetree 59864b1685 target/riscv: Convert RV32F insns to decodetree 3a2c5f541d target/riscv: Convert RV64A insns to decodetree f82abf658a target/riscv: Convert RV32A insns to decodetree ab048656b6 target/riscv: Convert RVXM insns to decodetree 111f67b3e7 target/riscv: Convert RVXI csr insns to decodetree c396660ebe target/riscv: Convert RVXI fence insns to decodetree 39398bc39f target/riscv: Convert RVXI arithmetic insns to decodetree 7992aaf172 target/riscv: Convert RV64I load/store insns to decodetree 442919643f target/riscv: Convert RV32I load/store insns to decodetree a06aff74df target/riscv: Convert RVXI branch insns to decodetree be6c9c1db2 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit be6c9c1db2eb (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit a06aff74df2b (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 442919643fdd (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 7992aaf1722d (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 39398bc39fe4 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit c396660ebe10 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 111f67b3e707 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit ab048656b681 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit f82abf658aad (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 3a2c5f541dfc (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 59864b16854b (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 3e90fd0856c1 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit d1161d52309a (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 93022dd55c16 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit aaafc94d51e5 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit a6a54cd66584 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 667b7025a214 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 67acb3a13a99 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 71d2bfc56aa4 (target/riscv: Remove gen_jalr()) 20/34 Checking commit fcffa51cc7f8 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 06f8936794fb (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 5f076855726a (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit c97f381c73ba (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 68260932acb5 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 13c3ed811adb (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit d0889eee7120 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit b710a729d453 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit d9b6c4fbf13d (target/riscv: Remove gen_system()) 29/34 Checking commit 820409bf26c8 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 773c114e215d (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit acd1bd17bca6 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit e7c4cef989c4 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 7d38b6a3a6ee (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit aefaa6d27f88 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' b3680b9211 target/riscv: Remaining rvc insn reuse 32 bit translators 353eaa0c82 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 47eb4ce57f target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 bcd933a911 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns ed1fe94b1a target/riscv: Convert @cs_2 insns to share translation functions 8dc2e2f80c target/riscv: Remove decode_RV32_64G() 8be8ea8835 target/riscv: Remove gen_system() 9c8dab6a0d target/riscv: Rename trans_arith to gen_arith dbc939326b target/riscv: Remove manual decoding of RV32/64M insn 0fc82cee12 target/riscv: Remove shift and slt insn manual decoding b48a7a1ffa target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 15e618a3c0 target/riscv: Move gen_arith_imm() decoding into trans_* functions 5832bf5371 target/riscv: Remove manual decoding from gen_store() 8e8ae1a6ff target/riscv: Remove manual decoding from gen_load() 72b0bc8e6b target/riscv: Remove manual decoding from gen_branch() 6220e2a4ee target/riscv: Remove gen_jalr() 22a61ce9be target/riscv: Convert quadrant 2 of RVXC insns to decodetree 3431c59aa7 target/riscv: Convert quadrant 1 of RVXC insns to decodetree c0277a3524 target/riscv: Convert quadrant 0 of RVXC insns to decodetree dd7ac7d493 target/riscv: Convert RV priv insns to decodetree fd0102d6bd target/riscv: Convert RV64D insns to decodetree 15a42d4ebf target/riscv: Convert RV32D insns to decodetree e3af3901b7 target/riscv: Convert RV64F insns to decodetree 5f78f14ea9 target/riscv: Convert RV32F insns to decodetree c5a4843d91 target/riscv: Convert RV64A insns to decodetree e15b1c8d50 target/riscv: Convert RV32A insns to decodetree e516885419 target/riscv: Convert RVXM insns to decodetree 423134822e target/riscv: Convert RVXI csr insns to decodetree 3e129a19d0 target/riscv: Convert RVXI fence insns to decodetree ed768ba555 target/riscv: Convert RVXI arithmetic insns to decodetree 15ccf67408 target/riscv: Convert RV64I load/store insns to decodetree aa66ca6313 target/riscv: Convert RV32I load/store insns to decodetree ff1e687da9 target/riscv: Convert RVXI branch insns to decodetree d865d233c4 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit d865d233c40d (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit ff1e687da98c (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit aa66ca631309 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 15ccf6740861 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit ed768ba5551a (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 3e129a19d0dd (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 423134822ee2 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit e516885419d8 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit e15b1c8d5077 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit c5a4843d91d2 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 5f78f14ea996 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit e3af3901b766 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 15a42d4ebfdf (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit fd0102d6bd23 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit dd7ac7d49373 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit c0277a3524e9 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 3431c59aa72c (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 22a61ce9be34 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 6220e2a4ee3b (target/riscv: Remove gen_jalr()) 20/34 Checking commit 72b0bc8e6beb (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 8e8ae1a6ff12 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 5832bf537181 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 15e618a3c002 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit b48a7a1ffa3b (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 0fc82cee1229 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit dbc939326b61 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 9c8dab6a0dd4 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 8be8ea883508 (target/riscv: Remove gen_system()) 29/34 Checking commit 8dc2e2f80c80 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit ed1fe94b1a06 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit bcd933a911cf (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 47eb4ce57fd3 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 353eaa0c822f (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit b3680b921129 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 8567625d24 target/riscv: Remaining rvc insn reuse 32 bit translators 16284d1570 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 7a459f22de target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 178531b141 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 58ad8f384c target/riscv: Convert @cs_2 insns to share translation functions 3a826e8f2c target/riscv: Remove decode_RV32_64G() 6df88e71b4 target/riscv: Remove gen_system() 8200b724b4 target/riscv: Rename trans_arith to gen_arith e640abf75e target/riscv: Remove manual decoding of RV32/64M insn e42677a8e4 target/riscv: Remove shift and slt insn manual decoding e8467f02a2 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists ff020ec93d target/riscv: Move gen_arith_imm() decoding into trans_* functions 1d42c6a385 target/riscv: Remove manual decoding from gen_store() ebdbd7db9b target/riscv: Remove manual decoding from gen_load() f8141eb2ec target/riscv: Remove manual decoding from gen_branch() 8d0f300898 target/riscv: Remove gen_jalr() 8ecb0e9105 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 618692e9c0 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 218512d554 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 036847261f target/riscv: Convert RV priv insns to decodetree d74f1476fe target/riscv: Convert RV64D insns to decodetree 653b965f94 target/riscv: Convert RV32D insns to decodetree 8b9a88d86d target/riscv: Convert RV64F insns to decodetree d8f776f978 target/riscv: Convert RV32F insns to decodetree 1fe180b80f target/riscv: Convert RV64A insns to decodetree 0aa1f5b2a6 target/riscv: Convert RV32A insns to decodetree 921a4104b9 target/riscv: Convert RVXM insns to decodetree 564bdc4ad7 target/riscv: Convert RVXI csr insns to decodetree a93a9825a8 target/riscv: Convert RVXI fence insns to decodetree e45699e605 target/riscv: Convert RVXI arithmetic insns to decodetree 4f7a74fff5 target/riscv: Convert RV64I load/store insns to decodetree b16b342efa target/riscv: Convert RV32I load/store insns to decodetree 03854cfd9d target/riscv: Convert RVXI branch insns to decodetree 23c894a493 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 23c894a4932d (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 03854cfd9d63 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit b16b342efa04 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 4f7a74fff5dc (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit e45699e605de (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit a93a9825a83a (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 564bdc4ad757 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 921a4104b97a (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 0aa1f5b2a658 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 1fe180b80f2b (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit d8f776f978e3 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 8b9a88d86d02 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 653b965f94d3 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit d74f1476fe37 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 036847261f5f (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 218512d55491 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 618692e9c08e (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 8ecb0e91056d (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 8d0f300898b6 (target/riscv: Remove gen_jalr()) 20/34 Checking commit f8141eb2ec6c (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit ebdbd7db9b8a (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 1d42c6a38553 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit ff020ec93d95 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit e8467f02a200 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit e42677a8e4aa (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit e640abf75e28 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 8200b724b4e3 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 6df88e71b4e0 (target/riscv: Remove gen_system()) 29/34 Checking commit 3a826e8f2cd6 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 58ad8f384c92 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 178531b141dd (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 7a459f22de2e (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 16284d157005 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 8567625d2492 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 91cc4dfad3 target/riscv: Remaining rvc insn reuse 32 bit translators 79243bdedd target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 ac80713cbf target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 be4a93d1ae target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 0af65c8a81 target/riscv: Convert @cs_2 insns to share translation functions 0f2bcb080e target/riscv: Remove decode_RV32_64G() 48dae4c6c1 target/riscv: Remove gen_system() 81012608ba target/riscv: Rename trans_arith to gen_arith c32b0ddb01 target/riscv: Remove manual decoding of RV32/64M insn 1cbdef86a0 target/riscv: Remove shift and slt insn manual decoding bf1eb05463 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists c44883a45f target/riscv: Move gen_arith_imm() decoding into trans_* functions 729d0c27d8 target/riscv: Remove manual decoding from gen_store() 29268a2e32 target/riscv: Remove manual decoding from gen_load() 42480e9c4e target/riscv: Remove manual decoding from gen_branch() a0e56ae155 target/riscv: Remove gen_jalr() 099e7cc2a9 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 5d417af932 target/riscv: Convert quadrant 1 of RVXC insns to decodetree f717d25ae8 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 7cd07bd1f3 target/riscv: Convert RV priv insns to decodetree 9232eb4b5a target/riscv: Convert RV64D insns to decodetree 161edc2890 target/riscv: Convert RV32D insns to decodetree 04c15ff22d target/riscv: Convert RV64F insns to decodetree b2c620b634 target/riscv: Convert RV32F insns to decodetree aa86b10249 target/riscv: Convert RV64A insns to decodetree 16f0ae6ac1 target/riscv: Convert RV32A insns to decodetree a31688ad60 target/riscv: Convert RVXM insns to decodetree 9445dc0bc2 target/riscv: Convert RVXI csr insns to decodetree e3e07c9150 target/riscv: Convert RVXI fence insns to decodetree e67c611dbe target/riscv: Convert RVXI arithmetic insns to decodetree 1d6f6057a9 target/riscv: Convert RV64I load/store insns to decodetree e8d0a0f018 target/riscv: Convert RV32I load/store insns to decodetree d1a7635515 target/riscv: Convert RVXI branch insns to decodetree b3e857ac85 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit b3e857ac85d4 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit d1a763551523 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit e8d0a0f0186b (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 1d6f6057a90e (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit e67c611dbece (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit e3e07c915094 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 9445dc0bc230 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit a31688ad607d (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 16f0ae6ac198 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit aa86b10249bc (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit b2c620b6342e (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 04c15ff22d21 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 161edc2890c8 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 9232eb4b5a32 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 7cd07bd1f3e6 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit f717d25ae89b (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 5d417af9324c (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 099e7cc2a965 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit a0e56ae1553e (target/riscv: Remove gen_jalr()) 20/34 Checking commit 42480e9c4ed4 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 29268a2e3292 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 729d0c27d89c (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit c44883a45f26 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit bf1eb054635e (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 1cbdef86a019 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit c32b0ddb018f (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 81012608bac5 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 48dae4c6c1bf (target/riscv: Remove gen_system()) 29/34 Checking commit 0f2bcb080eb1 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 0af65c8a8166 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit be4a93d1aeed (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit ac80713cbf5b (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 79243bdedd4b (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 91cc4dfad33a (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 5360362b31 target/riscv: Remaining rvc insn reuse 32 bit translators 10832a8af4 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 5571cc43be target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 564c0ac7d6 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 87b8558aa3 target/riscv: Convert @cs_2 insns to share translation functions 50437f39ef target/riscv: Remove decode_RV32_64G() 1dfbf86296 target/riscv: Remove gen_system() db091a8aec target/riscv: Rename trans_arith to gen_arith b2529831a9 target/riscv: Remove manual decoding of RV32/64M insn 4d9c016363 target/riscv: Remove shift and slt insn manual decoding fa92787ed4 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 3eec88dcc5 target/riscv: Move gen_arith_imm() decoding into trans_* functions 8100a6f5fe target/riscv: Remove manual decoding from gen_store() 3272124b3a target/riscv: Remove manual decoding from gen_load() b3587f0271 target/riscv: Remove manual decoding from gen_branch() e11a3d3b2f target/riscv: Remove gen_jalr() 1f7c8222ef target/riscv: Convert quadrant 2 of RVXC insns to decodetree 75dad193fa target/riscv: Convert quadrant 1 of RVXC insns to decodetree 40c4217e9c target/riscv: Convert quadrant 0 of RVXC insns to decodetree 910ba2141b target/riscv: Convert RV priv insns to decodetree e74d191af3 target/riscv: Convert RV64D insns to decodetree 059f3dc87a target/riscv: Convert RV32D insns to decodetree 4c999b97e1 target/riscv: Convert RV64F insns to decodetree 4fed7e6516 target/riscv: Convert RV32F insns to decodetree 2fc5742879 target/riscv: Convert RV64A insns to decodetree ec8376410f target/riscv: Convert RV32A insns to decodetree baf2143c7e target/riscv: Convert RVXM insns to decodetree 22ff1d5f7e target/riscv: Convert RVXI csr insns to decodetree 548c99a4da target/riscv: Convert RVXI fence insns to decodetree c0b977af83 target/riscv: Convert RVXI arithmetic insns to decodetree 3a99ee7b3a target/riscv: Convert RV64I load/store insns to decodetree bb3f7d468d target/riscv: Convert RV32I load/store insns to decodetree 56dbd0e7c1 target/riscv: Convert RVXI branch insns to decodetree 3fc565ce28 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 3fc565ce284a (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 56dbd0e7c12f (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit bb3f7d468d0c (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 3a99ee7b3a16 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit c0b977af8321 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 548c99a4da9b (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 22ff1d5f7e05 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit baf2143c7ed8 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit ec8376410f59 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 2fc574287901 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 4fed7e65169f (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 4c999b97e194 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 059f3dc87a56 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit e74d191af39a (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 910ba2141b70 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 40c4217e9c64 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 75dad193fa5c (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 1f7c8222efac (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit e11a3d3b2f9e (target/riscv: Remove gen_jalr()) 20/34 Checking commit b3587f0271d0 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 3272124b3a7c (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 8100a6f5fe5d (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 3eec88dcc51f (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit fa92787ed4c7 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 4d9c0163635c (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit b2529831a916 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit db091a8aec70 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 1dfbf862969a (target/riscv: Remove gen_system()) 29/34 Checking commit 50437f39ef7a (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 87b8558aa3ce (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 564c0ac7d659 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 5571cc43beef (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 10832a8af42c (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 5360362b3101 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de t [tag update] patchew/20190227164900.16378-1-dgilbert@redhat.com -> patchew/20190227164900.16378-1-dgilbert@redhat.com Switched to a new branch 'test' 3b9d37e069 target/riscv: Remaining rvc insn reuse 32 bit translators 9fe8c74651 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 f0d42e11ed target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 6372447bab target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns fbfdca289f target/riscv: Convert @cs_2 insns to share translation functions 9b1f13fef0 target/riscv: Remove decode_RV32_64G() e1b04f5631 target/riscv: Remove gen_system() 0cf15d4fde target/riscv: Rename trans_arith to gen_arith 4476739bb6 target/riscv: Remove manual decoding of RV32/64M insn 9c74a64743 target/riscv: Remove shift and slt insn manual decoding 0712e5d505 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists e576b335a3 target/riscv: Move gen_arith_imm() decoding into trans_* functions 411a0657a5 target/riscv: Remove manual decoding from gen_store() 847027c8df target/riscv: Remove manual decoding from gen_load() 4d09f89815 target/riscv: Remove manual decoding from gen_branch() a2e6e2a506 target/riscv: Remove gen_jalr() 745647749f target/riscv: Convert quadrant 2 of RVXC insns to decodetree 620e151c96 target/riscv: Convert quadrant 1 of RVXC insns to decodetree c65c33204a target/riscv: Convert quadrant 0 of RVXC insns to decodetree 7496f66eea target/riscv: Convert RV priv insns to decodetree f8def66abe target/riscv: Convert RV64D insns to decodetree b09c15290d target/riscv: Convert RV32D insns to decodetree 73fa49c40e target/riscv: Convert RV64F insns to decodetree 031e9b105b target/riscv: Convert RV32F insns to decodetree 568deed796 target/riscv: Convert RV64A insns to decodetree 439771055d target/riscv: Convert RV32A insns to decodetree 9f1a2b333f target/riscv: Convert RVXM insns to decodetree 67032b74c5 target/riscv: Convert RVXI csr insns to decodetree 248c9cbbab target/riscv: Convert RVXI fence insns to decodetree 73c1e54c41 target/riscv: Convert RVXI arithmetic insns to decodetree 082d0d36e5 target/riscv: Convert RV64I load/store insns to decodetree f2abcccebe target/riscv: Convert RV32I load/store insns to decodetree 3b85b9c661 target/riscv: Convert RVXI branch insns to decodetree 685654f547 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 685654f547cf (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 3b85b9c661bd (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit f2abcccebece (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 082d0d36e5d8 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 73c1e54c4106 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 248c9cbbab67 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 67032b74c569 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 9f1a2b333f8b (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 439771055d06 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 568deed7965c (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 031e9b105b76 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 73fa49c40e16 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit b09c15290d31 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit f8def66abe0a (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 7496f66eea0e (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit c65c33204ac4 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 620e151c96f5 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 745647749f25 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit a2e6e2a506d5 (target/riscv: Remove gen_jalr()) 20/34 Checking commit 4d09f89815f6 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 847027c8df72 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 411a0657a555 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit e576b335a339 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 0712e5d505d3 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 9c74a6474389 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 4476739bb651 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 0cf15d4fdebf (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit e1b04f563128 (target/riscv: Remove gen_system()) 29/34 Checking commit 9b1f13fef020 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit fbfdca289f1b (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 6372447babca (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit f0d42e11ed0d (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 9fe8c746511d (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 3b9d37e069c1 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 2d38a32cd2 target/riscv: Remaining rvc insn reuse 32 bit translators f78e38076d target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 c44e532fe8 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 0b27c4efb5 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns bfbca08977 target/riscv: Convert @cs_2 insns to share translation functions 817c810259 target/riscv: Remove decode_RV32_64G() d449051b86 target/riscv: Remove gen_system() 02c282a707 target/riscv: Rename trans_arith to gen_arith da08d4630c target/riscv: Remove manual decoding of RV32/64M insn c26a73f1eb target/riscv: Remove shift and slt insn manual decoding c813653652 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 889b9a3ac1 target/riscv: Move gen_arith_imm() decoding into trans_* functions 575eaddbf9 target/riscv: Remove manual decoding from gen_store() bc35db457c target/riscv: Remove manual decoding from gen_load() 9137c358aa target/riscv: Remove manual decoding from gen_branch() 733ba16e7a target/riscv: Remove gen_jalr() 65e9687470 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 014865a06b target/riscv: Convert quadrant 1 of RVXC insns to decodetree 07cbd2eee2 target/riscv: Convert quadrant 0 of RVXC insns to decodetree f5ea50b3f9 target/riscv: Convert RV priv insns to decodetree f174857a8d target/riscv: Convert RV64D insns to decodetree 8addf378cc target/riscv: Convert RV32D insns to decodetree 08dc5b9219 target/riscv: Convert RV64F insns to decodetree cab5e5b87d target/riscv: Convert RV32F insns to decodetree d900682426 target/riscv: Convert RV64A insns to decodetree 1b32036a98 target/riscv: Convert RV32A insns to decodetree 79f6f5dae7 target/riscv: Convert RVXM insns to decodetree 39012e5d62 target/riscv: Convert RVXI csr insns to decodetree e5360a38b0 target/riscv: Convert RVXI fence insns to decodetree 723fc1625b target/riscv: Convert RVXI arithmetic insns to decodetree 3d54710b38 target/riscv: Convert RV64I load/store insns to decodetree 67861de31a target/riscv: Convert RV32I load/store insns to decodetree 770f72af73 target/riscv: Convert RVXI branch insns to decodetree d72e61d38a target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit d72e61d38a1a (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 770f72af73af (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 67861de31a54 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 3d54710b3803 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 723fc1625b3e (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit e5360a38b093 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 39012e5d6288 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 79f6f5dae7cb (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 1b32036a98a6 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit d900682426a1 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit cab5e5b87d6e (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 08dc5b92193b (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 8addf378cc61 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit f174857a8d0e (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit f5ea50b3f9a4 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 07cbd2eee20d (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 014865a06bc3 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 65e9687470d0 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 733ba16e7ae3 (target/riscv: Remove gen_jalr()) 20/34 Checking commit 9137c358aa1f (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit bc35db457cc6 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 575eaddbf907 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 889b9a3ac1aa (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit c813653652e7 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit c26a73f1ebbe (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit da08d4630ce4 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 02c282a70757 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit d449051b86ce (target/riscv: Remove gen_system()) 29/34 Checking commit 817c810259f5 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit bfbca089774f (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 0b27c4efb545 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit c44e532fe846 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit f78e38076d67 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 2d38a32cd249 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' b743b2708d target/riscv: Remaining rvc insn reuse 32 bit translators 97151915f5 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 64110323f1 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 27afdd0f91 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 7a460bcb99 target/riscv: Convert @cs_2 insns to share translation functions 2be9091aba target/riscv: Remove decode_RV32_64G() 2725a49a4b target/riscv: Remove gen_system() ddbd02c7b3 target/riscv: Rename trans_arith to gen_arith 1694fea27d target/riscv: Remove manual decoding of RV32/64M insn c863548047 target/riscv: Remove shift and slt insn manual decoding a210ebe4d2 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 3bdee97f0b target/riscv: Move gen_arith_imm() decoding into trans_* functions b543464822 target/riscv: Remove manual decoding from gen_store() 9ff5a67fcc target/riscv: Remove manual decoding from gen_load() 2d1c64f887 target/riscv: Remove manual decoding from gen_branch() bdaf5ddf31 target/riscv: Remove gen_jalr() 78a6813f86 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 2b5d0b8dca target/riscv: Convert quadrant 1 of RVXC insns to decodetree cf530fdd73 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 2b10a8540e target/riscv: Convert RV priv insns to decodetree 0257600022 target/riscv: Convert RV64D insns to decodetree 1ece744398 target/riscv: Convert RV32D insns to decodetree 399b83982f target/riscv: Convert RV64F insns to decodetree 9a7dfa767f target/riscv: Convert RV32F insns to decodetree 7d41f5f383 target/riscv: Convert RV64A insns to decodetree 4622cedb38 target/riscv: Convert RV32A insns to decodetree a7d64cae55 target/riscv: Convert RVXM insns to decodetree a6218396a7 target/riscv: Convert RVXI csr insns to decodetree 22bd7ea86a target/riscv: Convert RVXI fence insns to decodetree 7a82ec67ed target/riscv: Convert RVXI arithmetic insns to decodetree 857a130e0d target/riscv: Convert RV64I load/store insns to decodetree cc3e90fc2c target/riscv: Convert RV32I load/store insns to decodetree e5c2ac77b0 target/riscv: Convert RVXI branch insns to decodetree 2d7a3e4329 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 2d7a3e4329be (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit e5c2ac77b074 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit cc3e90fc2cc0 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 857a130e0d4d (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 7a82ec67edab (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 22bd7ea86ae4 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit a6218396a705 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit a7d64cae556e (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 4622cedb385c (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 7d41f5f383b4 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 9a7dfa767f2d (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 399b83982f45 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 1ece7443984a (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 025760002299 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 2b10a8540e59 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit cf530fdd733f (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 2b5d0b8dca51 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 78a6813f8648 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit bdaf5ddf312d (target/riscv: Remove gen_jalr()) 20/34 Checking commit 2d1c64f88730 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 9ff5a67fcc8b (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit b543464822b5 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 3bdee97f0b9e (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit a210ebe4d2d5 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit c86354804726 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 1694fea27daa (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit ddbd02c7b30e (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 2725a49a4bab (target/riscv: Remove gen_system()) 29/34 Checking commit 2be9091abae5 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 7a460bcb995e (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 27afdd0f91c9 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 64110323f178 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 97151915f5d9 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit b743b2708d74 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' c90f0b1c1f target/riscv: Remaining rvc insn reuse 32 bit translators f4ec91a15f target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 7c79aff681 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 c3d9dcf346 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns b40b8bfcef target/riscv: Convert @cs_2 insns to share translation functions e290faf869 target/riscv: Remove decode_RV32_64G() 4637bf24c6 target/riscv: Remove gen_system() 7c46cc508c target/riscv: Rename trans_arith to gen_arith ba39f3cbee target/riscv: Remove manual decoding of RV32/64M insn 777a5ef2eb target/riscv: Remove shift and slt insn manual decoding 7144485ed8 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists f59c1ea746 target/riscv: Move gen_arith_imm() decoding into trans_* functions b1ae2701d2 target/riscv: Remove manual decoding from gen_store() 4d141ae68d target/riscv: Remove manual decoding from gen_load() 3e53b0632d target/riscv: Remove manual decoding from gen_branch() 5fb2434794 target/riscv: Remove gen_jalr() dfbe3100f0 target/riscv: Convert quadrant 2 of RVXC insns to decodetree cee70279b4 target/riscv: Convert quadrant 1 of RVXC insns to decodetree b2bc191262 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 92538ecf34 target/riscv: Convert RV priv insns to decodetree b1870f1012 target/riscv: Convert RV64D insns to decodetree edde2c7cae target/riscv: Convert RV32D insns to decodetree 71044a62c9 target/riscv: Convert RV64F insns to decodetree faf08ac6d1 target/riscv: Convert RV32F insns to decodetree aa0069bfc8 target/riscv: Convert RV64A insns to decodetree 2a0110d30f target/riscv: Convert RV32A insns to decodetree f00df81137 target/riscv: Convert RVXM insns to decodetree dc9c4675b4 target/riscv: Convert RVXI csr insns to decodetree 6dd33fa4a7 target/riscv: Convert RVXI fence insns to decodetree 9ba0da58a1 target/riscv: Convert RVXI arithmetic insns to decodetree addb297559 target/riscv: Convert RV64I load/store insns to decodetree 938440b817 target/riscv: Convert RV32I load/store insns to decodetree 9e67d7855b target/riscv: Convert RVXI branch insns to decodetree fcbe27fed9 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit fcbe27fed9d5 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 9e67d7855b83 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 938440b817e3 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit addb29755983 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 9ba0da58a1b0 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 6dd33fa4a7c4 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit dc9c4675b447 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit f00df811376d (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 2a0110d30f3d (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit aa0069bfc8a0 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit faf08ac6d110 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 71044a62c9e4 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit edde2c7cae6b (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit b1870f101244 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 92538ecf3408 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit b2bc19126209 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit cee70279b40a (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit dfbe3100f024 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 5fb2434794a8 (target/riscv: Remove gen_jalr()) 20/34 Checking commit 3e53b0632d6f (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 4d141ae68d99 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit b1ae2701d205 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit f59c1ea746d6 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 7144485ed80e (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 777a5ef2ebff (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit ba39f3cbeea0 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 7c46cc508cef (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 4637bf24c671 (target/riscv: Remove gen_system()) 29/34 Checking commit e290faf86918 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit b40b8bfcef10 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit c3d9dcf3466f (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 7c79aff68154 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit f4ec91a15f35 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit c90f0b1c1f4b (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' c2c69aa251 target/riscv: Remaining rvc insn reuse 32 bit translators 9a318148d1 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 eeeb834db3 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 b016042b0a target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns cb2dec98be target/riscv: Convert @cs_2 insns to share translation functions ff0c910b57 target/riscv: Remove decode_RV32_64G() 927d960855 target/riscv: Remove gen_system() 2e0ac36052 target/riscv: Rename trans_arith to gen_arith f44b0d8f40 target/riscv: Remove manual decoding of RV32/64M insn 1ea92eefa9 target/riscv: Remove shift and slt insn manual decoding 9498f1127e target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 3dfa4c4c4c target/riscv: Move gen_arith_imm() decoding into trans_* functions 0655e2906a target/riscv: Remove manual decoding from gen_store() fcdae66c13 target/riscv: Remove manual decoding from gen_load() c6ee42b012 target/riscv: Remove manual decoding from gen_branch() 049e24ff90 target/riscv: Remove gen_jalr() fece7c1586 target/riscv: Convert quadrant 2 of RVXC insns to decodetree c34654aade target/riscv: Convert quadrant 1 of RVXC insns to decodetree bf271dccd0 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 3fd0fe5807 target/riscv: Convert RV priv insns to decodetree 947553ce03 target/riscv: Convert RV64D insns to decodetree 0244c4e5ca target/riscv: Convert RV32D insns to decodetree 2facd2733c target/riscv: Convert RV64F insns to decodetree efa4b868cc target/riscv: Convert RV32F insns to decodetree cab479143a target/riscv: Convert RV64A insns to decodetree ea955e80aa target/riscv: Convert RV32A insns to decodetree 62ab9b09e5 target/riscv: Convert RVXM insns to decodetree 36114883eb target/riscv: Convert RVXI csr insns to decodetree c005651841 target/riscv: Convert RVXI fence insns to decodetree 846964b556 target/riscv: Convert RVXI arithmetic insns to decodetree 9d969e37b0 target/riscv: Convert RV64I load/store insns to decodetree 847d9c0582 target/riscv: Convert RV32I load/store insns to decodetree b4b1e9df59 target/riscv: Convert RVXI branch insns to decodetree 919230eab3 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 919230eab384 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit b4b1e9df59b8 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 847d9c058244 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 9d969e37b044 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 846964b55682 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit c005651841a7 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 36114883ebb6 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 62ab9b09e53a (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit ea955e80aab8 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit cab479143aff (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit efa4b868ccf1 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 2facd2733cfb (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 0244c4e5ca8b (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 947553ce034a (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 3fd0fe580789 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit bf271dccd014 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit c34654aade41 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit fece7c1586e0 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 049e24ff90dc (target/riscv: Remove gen_jalr()) 20/34 Checking commit c6ee42b0124d (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit fcdae66c1343 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 0655e2906aed (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 3dfa4c4c4c81 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 9498f1127ef7 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 1ea92eefa95d (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit f44b0d8f40a3 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 2e0ac36052ad (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 927d96085513 (target/riscv: Remove gen_system()) 29/34 Checking commit ff0c910b57bc (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit cb2dec98bed8 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit b016042b0a1f (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit eeeb834db343 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 9a318148d1f6 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit c2c69aa251b3 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 72df75a777 target/riscv: Remaining rvc insn reuse 32 bit translators ac327c0ac9 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 4ebe14c582 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 812966d438 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 06e544919e target/riscv: Convert @cs_2 insns to share translation functions b7013da7f9 target/riscv: Remove decode_RV32_64G() 02f42d7145 target/riscv: Remove gen_system() 4e60e91dc7 target/riscv: Rename trans_arith to gen_arith e991dfaa7d target/riscv: Remove manual decoding of RV32/64M insn fb0e577549 target/riscv: Remove shift and slt insn manual decoding 9a495cf36e target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists bde9c95401 target/riscv: Move gen_arith_imm() decoding into trans_* functions 60c0bc9616 target/riscv: Remove manual decoding from gen_store() 25cab6f652 target/riscv: Remove manual decoding from gen_load() e9840d0cbe target/riscv: Remove manual decoding from gen_branch() 4840e9f2d5 target/riscv: Remove gen_jalr() 230f7f47c0 target/riscv: Convert quadrant 2 of RVXC insns to decodetree e60c8ac1e1 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 590998de94 target/riscv: Convert quadrant 0 of RVXC insns to decodetree b7f573400e target/riscv: Convert RV priv insns to decodetree 5ca82670a8 target/riscv: Convert RV64D insns to decodetree dc294c4664 target/riscv: Convert RV32D insns to decodetree e33c931799 target/riscv: Convert RV64F insns to decodetree d8458e4eaf target/riscv: Convert RV32F insns to decodetree e28bad669b target/riscv: Convert RV64A insns to decodetree 83facf8e66 target/riscv: Convert RV32A insns to decodetree d62f8d335c target/riscv: Convert RVXM insns to decodetree 5164f378e0 target/riscv: Convert RVXI csr insns to decodetree 3f206cb1cb target/riscv: Convert RVXI fence insns to decodetree ce53d87477 target/riscv: Convert RVXI arithmetic insns to decodetree be8a4c67e2 target/riscv: Convert RV64I load/store insns to decodetree cdbbb37a2d target/riscv: Convert RV32I load/store insns to decodetree 9e489f4ff8 target/riscv: Convert RVXI branch insns to decodetree 138a68c761 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 138a68c761b7 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 9e489f4ff813 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit cdbbb37a2d98 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit be8a4c67e295 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit ce53d87477a9 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 3f206cb1cb69 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 5164f378e0e3 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit d62f8d335c9e (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 83facf8e66d6 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit e28bad669bc1 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit d8458e4eafb7 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit e33c9317996c (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit dc294c4664df (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 5ca82670a81f (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit b7f573400e74 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 590998de94e5 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit e60c8ac1e1eb (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 230f7f47c0b5 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 4840e9f2d590 (target/riscv: Remove gen_jalr()) 20/34 Checking commit e9840d0cbe1d (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 25cab6f65212 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 60c0bc9616a6 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit bde9c95401d9 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 9a495cf36e7e (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit fb0e57754972 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit e991dfaa7db9 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 4e60e91dc72a (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 02f42d7145a5 (target/riscv: Remove gen_system()) 29/34 Checking commit b7013da7f93c (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 06e544919e67 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 812966d438a7 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 4ebe14c58219 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit ac327c0ac92e (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 72df75a7770a (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 575e951e3b target/riscv: Remaining rvc insn reuse 32 bit translators 145f2de704 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 488a3dbd5b target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 1a22ffc51d target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns c1cb5fe305 target/riscv: Convert @cs_2 insns to share translation functions c0ed712696 target/riscv: Remove decode_RV32_64G() 33fb27a103 target/riscv: Remove gen_system() 526ce18f70 target/riscv: Rename trans_arith to gen_arith 31197b635d target/riscv: Remove manual decoding of RV32/64M insn e3be11df5a target/riscv: Remove shift and slt insn manual decoding 1f50bd6713 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 966a93a77d target/riscv: Move gen_arith_imm() decoding into trans_* functions 18b2204791 target/riscv: Remove manual decoding from gen_store() 8391fd64e7 target/riscv: Remove manual decoding from gen_load() 1a4878abc1 target/riscv: Remove manual decoding from gen_branch() e9185ddceb target/riscv: Remove gen_jalr() f3e2629027 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 5ccf0cbbe3 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 33c2fb427f target/riscv: Convert quadrant 0 of RVXC insns to decodetree fad9363d56 target/riscv: Convert RV priv insns to decodetree e6ed80e3a3 target/riscv: Convert RV64D insns to decodetree a42295749f target/riscv: Convert RV32D insns to decodetree a52f605ff0 target/riscv: Convert RV64F insns to decodetree 4b8cec3579 target/riscv: Convert RV32F insns to decodetree 3358c9735f target/riscv: Convert RV64A insns to decodetree 542959299f target/riscv: Convert RV32A insns to decodetree 1489475225 target/riscv: Convert RVXM insns to decodetree 3a445c5718 target/riscv: Convert RVXI csr insns to decodetree ec1bad37be target/riscv: Convert RVXI fence insns to decodetree 863a74e1c1 target/riscv: Convert RVXI arithmetic insns to decodetree c872667ddf target/riscv: Convert RV64I load/store insns to decodetree 909f6cd5d6 target/riscv: Convert RV32I load/store insns to decodetree df16d51e9c target/riscv: Convert RVXI branch insns to decodetree 85516cfa42 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 85516cfa42f3 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit df16d51e9c94 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 909f6cd5d657 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit c872667ddf92 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 863a74e1c1d1 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit ec1bad37be50 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 3a445c571840 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 1489475225b9 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 542959299f3e (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 3358c9735ff5 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 4b8cec35790a (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit a52f605ff062 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit a42295749f72 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit e6ed80e3a32a (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit fad9363d563d (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 33c2fb427f6b (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 5ccf0cbbe376 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit f3e2629027f0 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit e9185ddceb45 (target/riscv: Remove gen_jalr()) 20/34 Checking commit 1a4878abc19a (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 8391fd64e77d (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 18b220479121 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 966a93a77d52 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 1f50bd67136c (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit e3be11df5aec (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 31197b635d05 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 526ce18f70e2 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 33fb27a10390 (target/riscv: Remove gen_system()) 29/34 Checking commit c0ed71269686 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit c1cb5fe30514 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 1a22ffc51d45 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 488a3dbd5b3d (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 145f2de704e7 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 575e951e3bab (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 57411c3df0 target/riscv: Remaining rvc insn reuse 32 bit translators 2b316ef6df target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 7c8f620985 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 3190c0d175 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 9804caa658 target/riscv: Convert @cs_2 insns to share translation functions 856bcfa746 target/riscv: Remove decode_RV32_64G() 087442ffb4 target/riscv: Remove gen_system() 553427a06a target/riscv: Rename trans_arith to gen_arith 548b9638bb target/riscv: Remove manual decoding of RV32/64M insn 4907b8b7d8 target/riscv: Remove shift and slt insn manual decoding ee0ef5e44a target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 320faa091e target/riscv: Move gen_arith_imm() decoding into trans_* functions 5977392ef6 target/riscv: Remove manual decoding from gen_store() 0bfeeaed56 target/riscv: Remove manual decoding from gen_load() a379dadde6 target/riscv: Remove manual decoding from gen_branch() 028d418d4b target/riscv: Remove gen_jalr() 133e6877ce target/riscv: Convert quadrant 2 of RVXC insns to decodetree a50f8fbea2 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 4a72c7e887 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 213f1ee177 target/riscv: Convert RV priv insns to decodetree 5da98dc3d6 target/riscv: Convert RV64D insns to decodetree 93da015fd5 target/riscv: Convert RV32D insns to decodetree 50fc219371 target/riscv: Convert RV64F insns to decodetree 7f4494ad4b target/riscv: Convert RV32F insns to decodetree a0645a0247 target/riscv: Convert RV64A insns to decodetree 18917ac52a target/riscv: Convert RV32A insns to decodetree 6ce00dee9a target/riscv: Convert RVXM insns to decodetree 5e79599aee target/riscv: Convert RVXI csr insns to decodetree 6db7a4cb0c target/riscv: Convert RVXI fence insns to decodetree 922467ba90 target/riscv: Convert RVXI arithmetic insns to decodetree 0b208e6923 target/riscv: Convert RV64I load/store insns to decodetree 2e06d08b59 target/riscv: Convert RV32I load/store insns to decodetree 0a5dab3195 target/riscv: Convert RVXI branch insns to decodetree 0f3720f4ef target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 0f3720f4efb7 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 0a5dab319590 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 2e06d08b59cb (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 0b208e69236f (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 922467ba9081 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 6db7a4cb0c7f (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 5e79599aeeb2 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 6ce00dee9a01 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 18917ac52a17 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit a0645a0247eb (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 7f4494ad4bc1 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 50fc2193712b (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 93da015fd520 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 5da98dc3d619 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 213f1ee1775a (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 4a72c7e887ed (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit a50f8fbea22c (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 133e6877ce81 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 028d418d4b5b (target/riscv: Remove gen_jalr()) 20/34 Checking commit a379dadde6af (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 0bfeeaed5620 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 5977392ef687 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 320faa091e79 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit ee0ef5e44aa0 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 4907b8b7d898 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 548b9638bb0e (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 553427a06aa7 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 087442ffb48b (target/riscv: Remove gen_system()) 29/34 Checking commit 856bcfa74672 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 9804caa658dc (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 3190c0d17543 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 7c8f620985ca (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 2b316ef6df2e (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 57411c3df0c8 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' d3ad1848a6 target/riscv: Remaining rvc insn reuse 32 bit translators af1913c05d target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 6963c921f9 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 58c75d3141 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns d084322875 target/riscv: Convert @cs_2 insns to share translation functions c351eb0ae8 target/riscv: Remove decode_RV32_64G() 23deae3b9b target/riscv: Remove gen_system() 77ff803f8f target/riscv: Rename trans_arith to gen_arith ae280bc4f1 target/riscv: Remove manual decoding of RV32/64M insn a8c3d18049 target/riscv: Remove shift and slt insn manual decoding 4128d0ced1 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 99e3fc2efd target/riscv: Move gen_arith_imm() decoding into trans_* functions 8dd27df30a target/riscv: Remove manual decoding from gen_store() 1e746316f3 target/riscv: Remove manual decoding from gen_load() b1814e4382 target/riscv: Remove manual decoding from gen_branch() 0bb9dae337 target/riscv: Remove gen_jalr() cefa65a0e5 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 492885cb14 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 4db7a126c0 target/riscv: Convert quadrant 0 of RVXC insns to decodetree f4a72664f5 target/riscv: Convert RV priv insns to decodetree 4f16046c27 target/riscv: Convert RV64D insns to decodetree 53196e5d8a target/riscv: Convert RV32D insns to decodetree 70ed1de904 target/riscv: Convert RV64F insns to decodetree 94ab95eb96 target/riscv: Convert RV32F insns to decodetree 373e5f4d89 target/riscv: Convert RV64A insns to decodetree 5f8b81a2c0 target/riscv: Convert RV32A insns to decodetree 27a8c76421 target/riscv: Convert RVXM insns to decodetree 9de2f054f4 target/riscv: Convert RVXI csr insns to decodetree 2447efc130 target/riscv: Convert RVXI fence insns to decodetree c3431cf3a3 target/riscv: Convert RVXI arithmetic insns to decodetree 959691a272 target/riscv: Convert RV64I load/store insns to decodetree bb7f3b05c7 target/riscv: Convert RV32I load/store insns to decodetree 44dece7d64 target/riscv: Convert RVXI branch insns to decodetree 3397dd74ae target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 3397dd74ae95 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 44dece7d64d8 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit bb7f3b05c7b4 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 959691a2728b (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit c3431cf3a39b (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 2447efc130a0 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 9de2f054f47f (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 27a8c764212b (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 5f8b81a2c0d2 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 373e5f4d8968 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 94ab95eb96d8 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 70ed1de904b0 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 53196e5d8a74 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 4f16046c27c5 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit f4a72664f537 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 4db7a126c020 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 492885cb1452 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit cefa65a0e5f9 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 0bb9dae3379f (target/riscv: Remove gen_jalr()) 20/34 Checking commit b1814e438227 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 1e746316f3f0 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 8dd27df30ae1 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 99e3fc2efdac (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 4128d0ced126 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit a8c3d18049c6 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit ae280bc4f195 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 77ff803f8f10 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 23deae3b9b0c (target/riscv: Remove gen_system()) 29/34 Checking commit c351eb0ae8a5 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit d084322875cd (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 58c75d3141b1 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 6963c921f9fd (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit af1913c05db8 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit d3ad1848a68b (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 4970e0da25 target/riscv: Remaining rvc insn reuse 32 bit translators da1f3e3750 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 a1bf3ba5b9 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 1ecd7677af target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns b875bf8020 target/riscv: Convert @cs_2 insns to share translation functions 02d41b33a9 target/riscv: Remove decode_RV32_64G() 0a8a289053 target/riscv: Remove gen_system() 43db899c10 target/riscv: Rename trans_arith to gen_arith 9169852bf6 target/riscv: Remove manual decoding of RV32/64M insn 2343c176ea target/riscv: Remove shift and slt insn manual decoding f09be7e1d6 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists b8c8e71abd target/riscv: Move gen_arith_imm() decoding into trans_* functions 14d0b8b743 target/riscv: Remove manual decoding from gen_store() 4c5dc279d6 target/riscv: Remove manual decoding from gen_load() 824e4f0e94 target/riscv: Remove manual decoding from gen_branch() 9ae02e8e09 target/riscv: Remove gen_jalr() e39f61eb60 target/riscv: Convert quadrant 2 of RVXC insns to decodetree fdc41b9f43 target/riscv: Convert quadrant 1 of RVXC insns to decodetree d3b4c466b3 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 2efb6e31ed target/riscv: Convert RV priv insns to decodetree 74b6adaf30 target/riscv: Convert RV64D insns to decodetree b7d0ee721d target/riscv: Convert RV32D insns to decodetree f45fe63ecd target/riscv: Convert RV64F insns to decodetree 281a6771a1 target/riscv: Convert RV32F insns to decodetree 4ac2f5f9a9 target/riscv: Convert RV64A insns to decodetree 7059369fb1 target/riscv: Convert RV32A insns to decodetree c6415d8f70 target/riscv: Convert RVXM insns to decodetree e5f8a73b10 target/riscv: Convert RVXI csr insns to decodetree a3918d697a target/riscv: Convert RVXI fence insns to decodetree f9bc9a8e5a target/riscv: Convert RVXI arithmetic insns to decodetree 72eda7dfe6 target/riscv: Convert RV64I load/store insns to decodetree 0328135453 target/riscv: Convert RV32I load/store insns to decodetree e65c22f552 target/riscv: Convert RVXI branch insns to decodetree b06b60dc08 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit b06b60dc086a (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit e65c22f55253 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 0328135453ab (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 72eda7dfe6ab (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit f9bc9a8e5aff (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit a3918d697ab0 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit e5f8a73b10fd (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit c6415d8f70b7 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 7059369fb123 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 4ac2f5f9a9bc (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 281a6771a143 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit f45fe63ecd4d (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit b7d0ee721d7a (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 74b6adaf3046 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 2efb6e31ed28 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit d3b4c466b346 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit fdc41b9f436c (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit e39f61eb6007 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 9ae02e8e0902 (target/riscv: Remove gen_jalr()) 20/34 Checking commit 824e4f0e94b2 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 4c5dc279d608 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 14d0b8b743d2 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit b8c8e71abd0a (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit f09be7e1d6be (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 2343c176ea14 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 9169852bf6df (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 43db899c1016 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 0a8a289053f2 (target/riscv: Remove gen_system()) 29/34 Checking commit 02d41b33a991 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit b875bf80200a (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 1ecd7677afef (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit a1bf3ba5b93d (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit da1f3e3750d3 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 4970e0da25eb (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 13675555e5 target/riscv: Remaining rvc insn reuse 32 bit translators 115c117df9 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 994387064c target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 d13b40ed12 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 25611ad897 target/riscv: Convert @cs_2 insns to share translation functions 2589dfcbee target/riscv: Remove decode_RV32_64G() 89c15cbd76 target/riscv: Remove gen_system() ab3c0b429e target/riscv: Rename trans_arith to gen_arith 8056650f79 target/riscv: Remove manual decoding of RV32/64M insn 36fd7789f5 target/riscv: Remove shift and slt insn manual decoding 92769a48c7 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 743385aa26 target/riscv: Move gen_arith_imm() decoding into trans_* functions a9c474569f target/riscv: Remove manual decoding from gen_store() 6140efd89e target/riscv: Remove manual decoding from gen_load() 79ac650f56 target/riscv: Remove manual decoding from gen_branch() f9156ac845 target/riscv: Remove gen_jalr() 628e2ef24e target/riscv: Convert quadrant 2 of RVXC insns to decodetree acc7f50080 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 4fd1181ee3 target/riscv: Convert quadrant 0 of RVXC insns to decodetree e3a4548a0b target/riscv: Convert RV priv insns to decodetree 111ab99339 target/riscv: Convert RV64D insns to decodetree 8b1cbcfdb0 target/riscv: Convert RV32D insns to decodetree 3b814c1bc6 target/riscv: Convert RV64F insns to decodetree 8aebcb350c target/riscv: Convert RV32F insns to decodetree 83d2832ed1 target/riscv: Convert RV64A insns to decodetree 5450d8d488 target/riscv: Convert RV32A insns to decodetree abc495f861 target/riscv: Convert RVXM insns to decodetree 29c983f8f0 target/riscv: Convert RVXI csr insns to decodetree 674da1a178 target/riscv: Convert RVXI fence insns to decodetree 0b0675d537 target/riscv: Convert RVXI arithmetic insns to decodetree da5e5746e2 target/riscv: Convert RV64I load/store insns to decodetree 4a0c4de165 target/riscv: Convert RV32I load/store insns to decodetree 4f89876d36 target/riscv: Convert RVXI branch insns to decodetree 5bacc0d5f9 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 5bacc0d5f955 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 4f89876d362f (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 4a0c4de1659b (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit da5e5746e24c (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 0b0675d537be (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 674da1a17830 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 29c983f8f032 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit abc495f8616a (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 5450d8d4886a (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 83d2832ed17e (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 8aebcb350c32 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 3b814c1bc6a7 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 8b1cbcfdb000 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 111ab993394d (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit e3a4548a0b77 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 4fd1181ee3be (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit acc7f5008001 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 628e2ef24e5a (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit f9156ac8451e (target/riscv: Remove gen_jalr()) 20/34 Checking commit 79ac650f56c8 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 6140efd89e23 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit a9c474569fcc (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 743385aa2611 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 92769a48c704 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 36fd7789f5ae (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 8056650f79a0 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit ab3c0b429e67 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 89c15cbd76f7 (target/riscv: Remove gen_system()) 29/34 Checking commit 2589dfcbeefc (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 25611ad897f2 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit d13b40ed122f (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 994387064c39 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 115c117df912 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 13675555e5de (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 7692ab0351 target/riscv: Remaining rvc insn reuse 32 bit translators 6f4cc4e269 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 8f1ab68947 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 4b4347bfc3 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 58571f5a45 target/riscv: Convert @cs_2 insns to share translation functions f5ce37eb3f target/riscv: Remove decode_RV32_64G() ac20d18ca3 target/riscv: Remove gen_system() 69640cace7 target/riscv: Rename trans_arith to gen_arith 8958d96778 target/riscv: Remove manual decoding of RV32/64M insn 1b24c49640 target/riscv: Remove shift and slt insn manual decoding fe39d1e690 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 643e94e33a target/riscv: Move gen_arith_imm() decoding into trans_* functions b752855cca target/riscv: Remove manual decoding from gen_store() 8385908b09 target/riscv: Remove manual decoding from gen_load() 128aa73a84 target/riscv: Remove manual decoding from gen_branch() 28cfb5416c target/riscv: Remove gen_jalr() 26803d3402 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 4fc0aab391 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 57609e2bd5 target/riscv: Convert quadrant 0 of RVXC insns to decodetree ab2dfaf8cb target/riscv: Convert RV priv insns to decodetree 0fc0413abb target/riscv: Convert RV64D insns to decodetree e1047cd9e8 target/riscv: Convert RV32D insns to decodetree 83a7091035 target/riscv: Convert RV64F insns to decodetree acf9a69cae target/riscv: Convert RV32F insns to decodetree cc15e79a60 target/riscv: Convert RV64A insns to decodetree 227b936e28 target/riscv: Convert RV32A insns to decodetree 6f4a70e32b target/riscv: Convert RVXM insns to decodetree 310acadeb9 target/riscv: Convert RVXI csr insns to decodetree e1c5f910b7 target/riscv: Convert RVXI fence insns to decodetree 37277bdcfe target/riscv: Convert RVXI arithmetic insns to decodetree 8150475e72 target/riscv: Convert RV64I load/store insns to decodetree efbd813cb7 target/riscv: Convert RV32I load/store insns to decodetree dcd54e1ccd target/riscv: Convert RVXI branch insns to decodetree 1cb2803474 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 1cb280347411 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit dcd54e1ccd9b (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit efbd813cb73f (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 8150475e72cf (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 37277bdcfe46 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit e1c5f910b74e (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 310acadeb98c (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 6f4a70e32b1a (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 227b936e28bd (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit cc15e79a6056 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit acf9a69cae1a (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 83a709103546 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit e1047cd9e881 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 0fc0413abb21 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit ab2dfaf8cbf5 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 57609e2bd519 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 4fc0aab391a2 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 26803d3402c8 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 28cfb5416cb0 (target/riscv: Remove gen_jalr()) 20/34 Checking commit 128aa73a84e4 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 8385908b090c (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit b752855cca08 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 643e94e33ada (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit fe39d1e69089 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 1b24c496403c (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 8958d9677874 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 69640cace762 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit ac20d18ca34d (target/riscv: Remove gen_system()) 29/34 Checking commit f5ce37eb3f79 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 58571f5a453b (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 4b4347bfc39b (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 8f1ab689478a (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 6f4cc4e269f6 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 7692ab035121 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' e09a605c06 target/riscv: Remaining rvc insn reuse 32 bit translators 7cd2a8a1dd target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 91f37fbc67 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 1b6aa72048 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 3610605612 target/riscv: Convert @cs_2 insns to share translation functions a52fdac789 target/riscv: Remove decode_RV32_64G() 52777411d1 target/riscv: Remove gen_system() 68104aff5d target/riscv: Rename trans_arith to gen_arith 44ee020c00 target/riscv: Remove manual decoding of RV32/64M insn f5b0464a03 target/riscv: Remove shift and slt insn manual decoding f409f5fd91 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 5d8472fc87 target/riscv: Move gen_arith_imm() decoding into trans_* functions be9b612598 target/riscv: Remove manual decoding from gen_store() f748f6cf8b target/riscv: Remove manual decoding from gen_load() dc8a556b68 target/riscv: Remove manual decoding from gen_branch() 0656f71d82 target/riscv: Remove gen_jalr() 8cf5b85c70 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 85cff29d3e target/riscv: Convert quadrant 1 of RVXC insns to decodetree 7f465ab803 target/riscv: Convert quadrant 0 of RVXC insns to decodetree e55d0e1783 target/riscv: Convert RV priv insns to decodetree b961f21457 target/riscv: Convert RV64D insns to decodetree 1fcf3def16 target/riscv: Convert RV32D insns to decodetree 45566cba73 target/riscv: Convert RV64F insns to decodetree 6cb690660a target/riscv: Convert RV32F insns to decodetree 3143ae903b target/riscv: Convert RV64A insns to decodetree bc3ec6ac00 target/riscv: Convert RV32A insns to decodetree 7d299a6f18 target/riscv: Convert RVXM insns to decodetree 2169c49711 target/riscv: Convert RVXI csr insns to decodetree c3bed35df2 target/riscv: Convert RVXI fence insns to decodetree 3a15d2fe53 target/riscv: Convert RVXI arithmetic insns to decodetree 62a286aaf5 target/riscv: Convert RV64I load/store insns to decodetree 04bd913382 target/riscv: Convert RV32I load/store insns to decodetree 8a59c3a056 target/riscv: Convert RVXI branch insns to decodetree eae77e5898 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit eae77e589836 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 8a59c3a056c5 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 04bd91338248 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 62a286aaf569 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 3a15d2fe5338 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit c3bed35df276 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 2169c4971112 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 7d299a6f18be (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit bc3ec6ac00ad (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 3143ae903be2 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 6cb690660a2a (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 45566cba7371 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 1fcf3def16a2 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit b961f2145701 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit e55d0e178370 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 7f465ab80399 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 85cff29d3eb3 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 8cf5b85c70d5 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 0656f71d82a1 (target/riscv: Remove gen_jalr()) 20/34 Checking commit dc8a556b68fc (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit f748f6cf8bf2 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit be9b612598bf (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 5d8472fc87ed (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit f409f5fd91e1 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit f5b0464a0391 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 44ee020c00a3 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 68104aff5d0a (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 52777411d1ce (target/riscv: Remove gen_system()) 29/34 Checking commit a52fdac78974 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 36106056126a (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 1b6aa72048aa (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 91f37fbc67c4 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 7cd2a8a1dd71 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit e09a605c063f (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 0ccb36bdb9 target/riscv: Remaining rvc insn reuse 32 bit translators c8844da104 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 9d9d15f5ad target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 bde8dff68c target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns a0edcbd157 target/riscv: Convert @cs_2 insns to share translation functions 6fb54c8cf3 target/riscv: Remove decode_RV32_64G() 9b1d307737 target/riscv: Remove gen_system() 9921d33bdd target/riscv: Rename trans_arith to gen_arith 0e9bfc6cfc target/riscv: Remove manual decoding of RV32/64M insn f61e83b050 target/riscv: Remove shift and slt insn manual decoding 027416235e target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists f89cdc4840 target/riscv: Move gen_arith_imm() decoding into trans_* functions 98995c5d08 target/riscv: Remove manual decoding from gen_store() 472ff95917 target/riscv: Remove manual decoding from gen_load() 1f64ddc61b target/riscv: Remove manual decoding from gen_branch() 1cec38c6a3 target/riscv: Remove gen_jalr() ce449e7757 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 5947da36b5 target/riscv: Convert quadrant 1 of RVXC insns to decodetree e78b74569a target/riscv: Convert quadrant 0 of RVXC insns to decodetree d26e158770 target/riscv: Convert RV priv insns to decodetree fa243130cb target/riscv: Convert RV64D insns to decodetree dbf2aedfb4 target/riscv: Convert RV32D insns to decodetree 44962a0e7b target/riscv: Convert RV64F insns to decodetree 78cfbc497e target/riscv: Convert RV32F insns to decodetree 8c1b94f60a target/riscv: Convert RV64A insns to decodetree 96aa55ec50 target/riscv: Convert RV32A insns to decodetree 8baecc31e5 target/riscv: Convert RVXM insns to decodetree 014292da10 target/riscv: Convert RVXI csr insns to decodetree 5fd757167d target/riscv: Convert RVXI fence insns to decodetree f972af043f target/riscv: Convert RVXI arithmetic insns to decodetree 5346012bb0 target/riscv: Convert RV64I load/store insns to decodetree a2ffd12b79 target/riscv: Convert RV32I load/store insns to decodetree 32d890482d target/riscv: Convert RVXI branch insns to decodetree 44f86f707d target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 44f86f707d0a (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 32d890482d81 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit a2ffd12b7936 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 5346012bb075 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit f972af043f14 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 5fd757167d13 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 014292da100c (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 8baecc31e54d (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 96aa55ec5028 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 8c1b94f60aeb (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 78cfbc497e5c (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 44962a0e7b1d (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit dbf2aedfb4b6 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit fa243130cbf1 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit d26e15877013 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit e78b74569ab6 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 5947da36b5f5 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit ce449e7757eb (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 1cec38c6a3ac (target/riscv: Remove gen_jalr()) 20/34 Checking commit 1f64ddc61b2b (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 472ff95917fd (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 98995c5d0806 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit f89cdc4840d0 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 027416235e39 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit f61e83b05074 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 0e9bfc6cfc7c (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 9921d33bdd07 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 9b1d307737a5 (target/riscv: Remove gen_system()) 29/34 Checking commit 6fb54c8cf38f (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit a0edcbd157bd (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit bde8dff68cc6 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 9d9d15f5ad23 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit c8844da104be (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 0ccb36bdb9f6 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbastian@mail.uni-paderborn.de Switched to a new branch 'test' 1b358aa13f target/riscv: Remaining rvc insn reuse 32 bit translators 66cbd8997f target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 b9b30047d8 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 7121a134b0 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 35070e7e89 target/riscv: Convert @cs_2 insns to share translation functions 34b5aa251b target/riscv: Remove decode_RV32_64G() 0e5ffcf2e7 target/riscv: Remove gen_system() 2fcff73aa6 target/riscv: Rename trans_arith to gen_arith 018d544430 target/riscv: Remove manual decoding of RV32/64M insn b8c2713f2a target/riscv: Remove shift and slt insn manual decoding 0ff74e10cb target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 071e341603 target/riscv: Move gen_arith_imm() decoding into trans_* functions b7cbbf58d2 target/riscv: Remove manual decoding from gen_store() 8bba1273b3 target/riscv: Remove manual decoding from gen_load() 7a4990291c target/riscv: Remove manual decoding from gen_branch() a652749d9e target/riscv: Remove gen_jalr() a47421cba2 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 9e07bdd4ba target/riscv: Convert quadrant 1 of RVXC insns to decodetree 08a47610c5 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 416a23688c target/riscv: Convert RV priv insns to decodetree 8329afd789 target/riscv: Convert RV64D insns to decodetree 45bc6de0a2 target/riscv: Convert RV32D insns to decodetree 0ce7e82bb5 target/riscv: Convert RV64F insns to decodetree 823c63ebf0 target/riscv: Convert RV32F insns to decodetree e476e5fc78 target/riscv: Convert RV64A insns to decodetree 28096a518e target/riscv: Convert RV32A insns to decodetree 7ae028f18b target/riscv: Convert RVXM insns to decodetree cdef25ca90 target/riscv: Convert RVXI csr insns to decodetree 4a5b58cad4 target/riscv: Convert RVXI fence insns to decodetree df5a8a0f0b target/riscv: Convert RVXI arithmetic insns to decodetree 520a45f4be target/riscv: Convert RV64I load/store insns to decodetree 04904238b2 target/riscv: Convert RV32I load/store insns to decodetree 287fecbc36 target/riscv: Convert RVXI branch insns to decodetree 6748037cd4 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 6748037cd4ed (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 287fecbc3628 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 04904238b253 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 520a45f4be9f (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit df5a8a0f0b0c (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 4a5b58cad488 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit cdef25ca901a (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 7ae028f18b79 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 28096a518e25 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit e476e5fc78dc (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 823c63ebf048 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 0ce7e82bb54b (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 45bc6de0a2b0 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 8329afd78925 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 416a23688cf6 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 08a47610c5a4 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 9e07bdd4bad1 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit a47421cba21a (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit a652749d9ece (target/riscv: Remove gen_jalr()) 20/34 Checking commit 7a4990291c3d (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 8bba1273b3d7 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit b7cbbf58d27c (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 071e3416031c (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 0ff74e10cbeb (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit b8c2713f2a48 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 018d54443056 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 2fcff73aa6ee (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 0e5ffcf2e712 (target/riscv: Remove gen_system()) 29/34 Checking commit 34b5aa251b7e (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 35070e7e8977 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 7121a134b04b (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit b9b30047d81b (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 66cbd8997f2f (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 1b358aa13f6a (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 27/02/2019 18.55, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ > > Hi, > > This series seems to have some coding style problems. See output below for > more information: Fam, Paolo, Patchew is really going wild these days. It replied 32 times to this patch series - quite a bit annoying. Could this be fixed, please? Thanks, Thomas
On 28/02/19 09:37, Thomas Huth wrote: > On 27/02/2019 18.55, no-reply@patchew.org wrote: >> Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbastian@mail.uni-paderborn.de/ >> >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: > > Fam, Paolo, > > Patchew is really going wild these days. It replied 32 times to this > patch series - quite a bit annoying. Could this be fixed, please? I have a fix, I haven't deployed it yet to patchew.org though. Paolo
Hi, this patchset converts the RISC-V decoder to decodetree in four major steps: 1) Convert 32-bit instructions to decodetree [Patch 1-15]: Many of the gen_* functions are called by the decode functions for 16-bit and 32-bit functions. If we move translation code from the gen_* functions to the generated trans_* functions of decode-tree, we get a lot of duplication. Therefore, we mostly generate calls to the old gen_* function which are properly replaced after step 2). Each of the trans_ functions are grouped into files corresponding to their ISA extension, e.g. addi which is in RV32I is translated in the file 'trans_rvi.inc.c'. 2) Convert 16-bit instructions to decodetree [Patch 16-18]: All 16 bit instructions have a direct mapping to a 32 bit instruction. Thus, we convert the arguments in the 16 bit trans_ function to the arguments of the corresponding 32 bit instruction and call the 32 bit trans_ function. 3) Remove old manual decoding in gen_* function [Patch 19-29]: this move all manual translation code into the trans_* instructions of decode tree, such that we can remove the old decode_* functions. 4) Simplify RVC by reusing as much as possible from the RVG decoder as suggested by Richard. [Patch 30-34] full tree available at https://github.com/bkoppelmann/qemu/tree/riscv-dt-v8 Cheers, Bastian v7 -> v8: - add REQUIRE_EXT macro - add missing RVM checks - add missing RVA checks - add missing RVF checks - add missing RVF checks - add missing RVD checks - add missing RVD checks - riscv_has_ext -> has_ext - env->ctx->priv_version -> ctx->priv_version - fixed wrongly inserted #ifdef TARGET_RISCV64 that lead to a compile error Bastian Koppelmann (34): target/riscv: Activate decodetree and implemnt LUI & AUIPC target/riscv: Convert RVXI branch insns to decodetree target/riscv: Convert RV32I load/store insns to decodetree target/riscv: Convert RV64I load/store insns to decodetree target/riscv: Convert RVXI arithmetic insns to decodetree target/riscv: Convert RVXI fence insns to decodetree target/riscv: Convert RVXI csr insns to decodetree target/riscv: Convert RVXM insns to decodetree target/riscv: Convert RV32A insns to decodetree target/riscv: Convert RV64A insns to decodetree target/riscv: Convert RV32F insns to decodetree target/riscv: Convert RV64F insns to decodetree target/riscv: Convert RV32D insns to decodetree target/riscv: Convert RV64D insns to decodetree target/riscv: Convert RV priv insns to decodetree target/riscv: Convert quadrant 0 of RVXC insns to decodetree target/riscv: Convert quadrant 1 of RVXC insns to decodetree target/riscv: Convert quadrant 2 of RVXC insns to decodetree target/riscv: Remove gen_jalr() target/riscv: Remove manual decoding from gen_branch() target/riscv: Remove manual decoding from gen_load() target/riscv: Remove manual decoding from gen_store() target/riscv: Move gen_arith_imm() decoding into trans_* functions target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists target/riscv: Remove shift and slt insn manual decoding target/riscv: Remove manual decoding of RV32/64M insn target/riscv: Rename trans_arith to gen_arith target/riscv: Remove gen_system() target/riscv: Remove decode_RV32_64G() target/riscv: Convert @cs_2 insns to share translation functions target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 target/riscv: Remaining rvc insn reuse 32 bit translators target/riscv/Makefile.objs | 22 + target/riscv/insn16-32.decode | 31 + target/riscv/insn16-64.decode | 33 + target/riscv/insn16.decode | 114 + target/riscv/insn32-64.decode | 72 + target/riscv/insn32.decode | 203 ++ .../riscv/insn_trans/trans_privileged.inc.c | 110 + target/riscv/insn_trans/trans_rva.inc.c | 218 ++ target/riscv/insn_trans/trans_rvc.inc.c | 149 ++ target/riscv/insn_trans/trans_rvd.inc.c | 442 ++++ target/riscv/insn_trans/trans_rvf.inc.c | 439 ++++ target/riscv/insn_trans/trans_rvi.inc.c | 568 +++++ target/riscv/insn_trans/trans_rvm.inc.c | 120 + target/riscv/translate.c | 1948 ++--------------- 14 files changed, 2740 insertions(+), 1729 deletions(-) create mode 100644 target/riscv/insn16-32.decode create mode 100644 target/riscv/insn16-64.decode create mode 100644 target/riscv/insn16.decode create mode 100644 target/riscv/insn32-64.decode create mode 100644 target/riscv/insn32.decode create mode 100644 target/riscv/insn_trans/trans_privileged.inc.c create mode 100644 target/riscv/insn_trans/trans_rva.inc.c create mode 100644 target/riscv/insn_trans/trans_rvc.inc.c create mode 100644 target/riscv/insn_trans/trans_rvd.inc.c create mode 100644 target/riscv/insn_trans/trans_rvf.inc.c create mode 100644 target/riscv/insn_trans/trans_rvi.inc.c create mode 100644 target/riscv/insn_trans/trans_rvm.inc.c