| Message ID | 20240202215749.2571545-1-numans@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] tests: Fix incorrect 'check_engine_stats' helper function. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
Acked-by: Mark Michelson <mmichels@redhat.com> On 2/2/24 16:57, numans@ovn.org wrote: > From: Numan Siddique <numans@ovn.org> > > The patch which added the helper function 'check_engine_stats' > didn't add it properly because of which we are seeing the below > warnings. > > test-source: line 2187: check_engine_stats: command not found > > This patch fixes it by using m4_divert_push/m4_divert_pop macros. > > Fixes: c69119ca3b59 ("tests: Add a couple of tests in ovn-northd for I-P.") > > Signed-off-by: Numan Siddique <numans@ovn.org> > --- > tests/ovn-northd.at | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at > index 5c597eb1ce..817defdd67 100644 > --- a/tests/ovn-northd.at > +++ b/tests/ovn-northd.at > @@ -36,6 +36,7 @@ m4_define([CHECK_NO_CHANGE_AFTER_RECOMPUTE], [ > ]) > ]) > > +m4_divert_push([PREPARE_TESTS]) > # Checks if the provided engine node recomputed or not > # and if it computed or not. > # 1st argument is the engine node. > @@ -79,6 +80,7 @@ $recompute : compute - $compute" > check test "$node_compute_ct" -ne "0" > fi > } > +m4_divert_pop([PREPARE_TESTS]) > > OVN_FOR_EACH_NORTHD_NO_HV([ > AT_SETUP([check from NBDB to SBDB])
On Fri, Feb 2, 2024 at 5:23 PM Mark Michelson <mmichels@redhat.com> wrote: > > Acked-by: Mark Michelson <mmichels@redhat.com> Thanks. Applied to main. Numan > > On 2/2/24 16:57, numans@ovn.org wrote: > > From: Numan Siddique <numans@ovn.org> > > > > The patch which added the helper function 'check_engine_stats' > > didn't add it properly because of which we are seeing the below > > warnings. > > > > test-source: line 2187: check_engine_stats: command not found > > > > This patch fixes it by using m4_divert_push/m4_divert_pop macros. > > > > Fixes: c69119ca3b59 ("tests: Add a couple of tests in ovn-northd for I-P.") > > > > Signed-off-by: Numan Siddique <numans@ovn.org> > > --- > > tests/ovn-northd.at | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at > > index 5c597eb1ce..817defdd67 100644 > > --- a/tests/ovn-northd.at > > +++ b/tests/ovn-northd.at > > @@ -36,6 +36,7 @@ m4_define([CHECK_NO_CHANGE_AFTER_RECOMPUTE], [ > > ]) > > ]) > > > > +m4_divert_push([PREPARE_TESTS]) > > # Checks if the provided engine node recomputed or not > > # and if it computed or not. > > # 1st argument is the engine node. > > @@ -79,6 +80,7 @@ $recompute : compute - $compute" > > check test "$node_compute_ct" -ne "0" > > fi > > } > > +m4_divert_pop([PREPARE_TESTS]) > > > > OVN_FOR_EACH_NORTHD_NO_HV([ > > AT_SETUP([check from NBDB to SBDB]) > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at index 5c597eb1ce..817defdd67 100644 --- a/tests/ovn-northd.at +++ b/tests/ovn-northd.at @@ -36,6 +36,7 @@ m4_define([CHECK_NO_CHANGE_AFTER_RECOMPUTE], [ ]) ]) +m4_divert_push([PREPARE_TESTS]) # Checks if the provided engine node recomputed or not # and if it computed or not. # 1st argument is the engine node. @@ -79,6 +80,7 @@ $recompute : compute - $compute" check test "$node_compute_ct" -ne "0" fi } +m4_divert_pop([PREPARE_TESTS]) OVN_FOR_EACH_NORTHD_NO_HV([ AT_SETUP([check from NBDB to SBDB])