From patchwork Fri Feb 2 21:57:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Numan Siddique X-Patchwork-Id: 1894790 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TRV5K3L0tz23gM for ; Sat, 3 Feb 2024 08:58:13 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 4EB42613C5; Fri, 2 Feb 2024 21:58:11 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4EB42613C5 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R-w5XR2qTdCE; Fri, 2 Feb 2024 21:58:10 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 9274360AAC; Fri, 2 Feb 2024 21:58:09 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9274360AAC Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6F730C0072; Fri, 2 Feb 2024 21:58:09 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id AFA3CC0037 for ; Fri, 2 Feb 2024 21:58:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7E79C418BB for ; Fri, 2 Feb 2024 21:58:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7E79C418BB X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FhQrx7OtS-gH for ; Fri, 2 Feb 2024 21:58:07 +0000 (UTC) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by smtp4.osuosl.org (Postfix) with ESMTPS id 8D3AC4168C for ; Fri, 2 Feb 2024 21:58:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8D3AC4168C Received: by mail.gandi.net (Postfix) with ESMTPSA id 2754DFF802; Fri, 2 Feb 2024 21:58:03 +0000 (UTC) From: numans@ovn.org To: dev@openvswitch.org Date: Fri, 2 Feb 2024 16:57:49 -0500 Message-ID: <20240202215749.2571545-1-numans@ovn.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-GND-Sasl: numans@ovn.org Subject: [ovs-dev] [PATCH ovn] tests: Fix incorrect 'check_engine_stats' helper function. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Numan Siddique The patch which added the helper function 'check_engine_stats' didn't add it properly because of which we are seeing the below warnings. test-source: line 2187: check_engine_stats: command not found This patch fixes it by using m4_divert_push/m4_divert_pop macros. Fixes: c69119ca3b59 ("tests: Add a couple of tests in ovn-northd for I-P.") Signed-off-by: Numan Siddique Acked-by: Mark Michelson --- tests/ovn-northd.at | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at index 5c597eb1ce..817defdd67 100644 --- a/tests/ovn-northd.at +++ b/tests/ovn-northd.at @@ -36,6 +36,7 @@ m4_define([CHECK_NO_CHANGE_AFTER_RECOMPUTE], [ ]) ]) +m4_divert_push([PREPARE_TESTS]) # Checks if the provided engine node recomputed or not # and if it computed or not. # 1st argument is the engine node. @@ -79,6 +80,7 @@ $recompute : compute - $compute" check test "$node_compute_ct" -ne "0" fi } +m4_divert_pop([PREPARE_TESTS]) OVN_FOR_EACH_NORTHD_NO_HV([ AT_SETUP([check from NBDB to SBDB])