| Message ID | 20230713110819.2408240-4-xsimonar@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Fixed 4 Unit Tests | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On Thu, Jul 13, 2023 at 1:10 PM Xavier Simonart <xsimonar@redhat.com> wrote: > Tests was randomly failing as missing some packets (e.g > from Second arrives to hv2:Migrator) > > Signed-off-by: Xavier Simonart <xsimonar@redhat.com> > --- > tests/ovn.at | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/ovn.at b/tests/ovn.at > index 2ce8478f8..3b705db54 100644 > --- a/tests/ovn.at > +++ b/tests/ovn.at > @@ -14811,6 +14811,11 @@ wait_column "$hv1_uuid" Port_Binding > requested_chassis logical_port=migrator > wait_column "$hv2_uuid" Port_Binding additional_chassis > logical_port=migrator > wait_column "$hv2_uuid" Port_Binding requested_additional_chassis > logical_port=migrator > > +# Port should be up (and flows installed) when migration is completed on > hv1. > +# However, neither ports up nor additional_chassis do guarantee that > flows on hv2 are fully installed. > +# ovn-installed on hv2 should guarantee that. > +OVS_WAIT_UNTIL([test `as hv2 ovs-vsctl get Interface migrator > external_ids:ovn-installed` = '"true"']) > + > # check that... > # unicast from First arrives to hv1:Migrator > # unicast from First arrives to hv2:Migrator > -- > 2.31.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Looks good to me, thanks. Acked-by: Ales Musil <amusil@redhat.com>
On 7/14/23 08:18, Ales Musil wrote: > On Thu, Jul 13, 2023 at 1:10 PM Xavier Simonart <xsimonar@redhat.com> wrote: > >> Tests was randomly failing as missing some packets (e.g >> from Second arrives to hv2:Migrator) >> >> Signed-off-by: Xavier Simonart <xsimonar@redhat.com> >> --- >> tests/ovn.at | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/tests/ovn.at b/tests/ovn.at >> index 2ce8478f8..3b705db54 100644 >> --- a/tests/ovn.at >> +++ b/tests/ovn.at >> @@ -14811,6 +14811,11 @@ wait_column "$hv1_uuid" Port_Binding >> requested_chassis logical_port=migrator >> wait_column "$hv2_uuid" Port_Binding additional_chassis >> logical_port=migrator >> wait_column "$hv2_uuid" Port_Binding requested_additional_chassis >> logical_port=migrator >> >> +# Port should be up (and flows installed) when migration is completed on >> hv1. >> +# However, neither ports up nor additional_chassis do guarantee that >> flows on hv2 are fully installed. >> +# ovn-installed on hv2 should guarantee that. >> +OVS_WAIT_UNTIL([test `as hv2 ovs-vsctl get Interface migrator >> external_ids:ovn-installed` = '"true"']) >> + >> # check that... >> # unicast from First arrives to hv1:Migrator >> # unicast from First arrives to hv2:Migrator >> -- >> 2.31.1 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> >> > Looks good to me, thanks. > > Acked-by: Ales Musil <amusil@redhat.com> > Thanks, Xavier and Ales! Applied to main and backported to all branches down to 22.06. Regards, Dumitru
diff --git a/tests/ovn.at b/tests/ovn.at index 2ce8478f8..3b705db54 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -14811,6 +14811,11 @@ wait_column "$hv1_uuid" Port_Binding requested_chassis logical_port=migrator wait_column "$hv2_uuid" Port_Binding additional_chassis logical_port=migrator wait_column "$hv2_uuid" Port_Binding requested_additional_chassis logical_port=migrator +# Port should be up (and flows installed) when migration is completed on hv1. +# However, neither ports up nor additional_chassis do guarantee that flows on hv2 are fully installed. +# ovn-installed on hv2 should guarantee that. +OVS_WAIT_UNTIL([test `as hv2 ovs-vsctl get Interface migrator external_ids:ovn-installed` = '"true"']) + # check that... # unicast from First arrives to hv1:Migrator # unicast from First arrives to hv2:Migrator
Tests was randomly failing as missing some packets (e.g from Second arrives to hv2:Migrator) Signed-off-by: Xavier Simonart <xsimonar@redhat.com> --- tests/ovn.at | 5 +++++ 1 file changed, 5 insertions(+)