diff mbox series

[ovs-dev,4/4] tests: fixed "Tiered ACLs"

Message ID 20230713110819.2408240-5-xsimonar@redhat.com
State Accepted
Headers show
Series Fixed 4 Unit Tests | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes success github build: passed

Commit Message

Xavier Simonart July 13, 2023, 11:08 a.m. UTC
Signed-off-by: Xavier Simonart <xsimonar@redhat.com>
---
 tests/system-ovn.at | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ales Musil July 14, 2023, 6:18 a.m. UTC | #1
On Thu, Jul 13, 2023 at 1:09 PM Xavier Simonart <xsimonar@redhat.com> wrote:

> Signed-off-by: Xavier Simonart <xsimonar@redhat.com>
> ---
>  tests/system-ovn.at | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/system-ovn.at b/tests/system-ovn.at
> index f09dddd99..cf3b272ec 100644
> --- a/tests/system-ovn.at
> +++ b/tests/system-ovn.at
> @@ -11353,7 +11353,7 @@ check ovn-nbctl ls-add ls
>  check ovn-nbctl lsp-add ls lsp1 -- lsp-set-addresses lsp1
> "00:00:00:00:00:01 10.0.0.1"
>  check ovn-nbctl lsp-add ls lsp2 -- lsp-set-addresses lsp2
> "00:00:00:00:00:02 10.0.0.2"
>
> -check ovn-nbctl pg-add pg lsp1 lsp2
> +check ovn-nbctl --wait=hv pg-add pg lsp1 lsp2
>
>  ADD_NAMESPACES(lsp1)
>  ADD_VETH(lsp1, lsp1, br-int, "10.0.0.1/24", "00:00:00:00:00:01")
> --
> 2.31.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Looks good to me, thanks.

Acked-by: Ales Musil <amusil@redhat.com>
Dumitru Ceara July 25, 2023, 3:22 p.m. UTC | #2
On 7/14/23 08:18, Ales Musil wrote:
> On Thu, Jul 13, 2023 at 1:09 PM Xavier Simonart <xsimonar@redhat.com> wrote:
> 
>> Signed-off-by: Xavier Simonart <xsimonar@redhat.com>
>> ---
>>  tests/system-ovn.at | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/system-ovn.at b/tests/system-ovn.at
>> index f09dddd99..cf3b272ec 100644
>> --- a/tests/system-ovn.at
>> +++ b/tests/system-ovn.at
>> @@ -11353,7 +11353,7 @@ check ovn-nbctl ls-add ls
>>  check ovn-nbctl lsp-add ls lsp1 -- lsp-set-addresses lsp1
>> "00:00:00:00:00:01 10.0.0.1"
>>  check ovn-nbctl lsp-add ls lsp2 -- lsp-set-addresses lsp2
>> "00:00:00:00:00:02 10.0.0.2"
>>
>> -check ovn-nbctl pg-add pg lsp1 lsp2
>> +check ovn-nbctl --wait=hv pg-add pg lsp1 lsp2
>>
>>  ADD_NAMESPACES(lsp1)
>>  ADD_VETH(lsp1, lsp1, br-int, "10.0.0.1/24", "00:00:00:00:00:01")
>> --
>> 2.31.1
>>
>> _______________________________________________
>> dev mailing list
>> dev@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>
>>
> Looks good to me, thanks.
> 
> Acked-by: Ales Musil <amusil@redhat.com>
> 

Thanks, Xavier and Ales!  Applied to main and backported to 23.06.

Regards,
Dumitru
diff mbox series

Patch

diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index f09dddd99..cf3b272ec 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -11353,7 +11353,7 @@  check ovn-nbctl ls-add ls
 check ovn-nbctl lsp-add ls lsp1 -- lsp-set-addresses lsp1 "00:00:00:00:00:01 10.0.0.1"
 check ovn-nbctl lsp-add ls lsp2 -- lsp-set-addresses lsp2 "00:00:00:00:00:02 10.0.0.2"
 
-check ovn-nbctl pg-add pg lsp1 lsp2
+check ovn-nbctl --wait=hv pg-add pg lsp1 lsp2
 
 ADD_NAMESPACES(lsp1)
 ADD_VETH(lsp1, lsp1, br-int, "10.0.0.1/24", "00:00:00:00:00:01")