| Message ID | CAD2Yd_Yca1E=XrjdB=3XYHMSD=AJTAW4-+4hpXVQj8bh8pox-g@mail.gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 2016-05-09 12:50, Graham Fairweather wrote: > From: Graham Fairweather <xotic750@gmail.com> > > This patch fixes the logged detected CPU ID when an equivalent is used, > like in the case where we have a bcm6369 and configuration for a > bcm6368 is used. > So, it will display 'Detected Broadcom 0x6369 CPU revision b2' instead of > 'Detected Broadcom 0x6369 CPU revision b2'. More info can be found at: > > https://forum.openwrt.org/viewtopic.php?id=64621 > https://github.com/Xotic750/openwrt/tree/fix_logged_cpu_id_bcm63xx > Signed-off-by: Graham Fairweather <xotic750@gmail.com> Please stop spamming the list with the same patch over and over again. While you're still trying to figure out how to send patches properly, please send them to yourself instead of the list. - Felix
It wasn't my intention to spam the list. I asked for help on the forum, I asked for help on IRC and I was told to try things. The documents say if unsuccessful then try again. As a noob, it is not the easiest process to follow, especially when something doesn't work. How would sending the mail to myself, which I did by the way, help me knowing what the problem was? Thanks for your patience and your advice. On 9 May 2016 at 12:54, Felix Fietkau <nbd@nbd.name> wrote: > On 2016-05-09 12:50, Graham Fairweather wrote: >> From: Graham Fairweather <xotic750@gmail.com> >> >> This patch fixes the logged detected CPU ID when an equivalent is used, >> like in the case where we have a bcm6369 and configuration for a >> bcm6368 is used. >> So, it will display 'Detected Broadcom 0x6369 CPU revision b2' instead of >> 'Detected Broadcom 0x6369 CPU revision b2'. More info can be found at: >> >> https://forum.openwrt.org/viewtopic.php?id=64621 >> https://github.com/Xotic750/openwrt/tree/fix_logged_cpu_id_bcm63xx >> Signed-off-by: Graham Fairweather <xotic750@gmail.com> > Please stop spamming the list with the same patch over and over again. > While you're still trying to figure out how to send patches properly, > please send them to yourself instead of the list. > > - Felix
On 09/05/2016 13:19, Graham Fairweather wrote: > It wasn't my intention to spam the list. I asked for help on the > forum, I asked for help on IRC and I was told to try things. The > documents say if unsuccessful then try again. As a noob, it is not the > easiest process to follow, especially when something doesn't work. How > would sending the mail to myself, which I did by the way, help me > knowing what the problem was? Thanks for your patience and your > advice. > Hi Graham, no worries, we all started doing this at some point. once you have the patch and send it to yourslef, you can save the email and try it out on your local tree. if all went well, you should be able to ally the mail/patch with "git am mypatch.eml" the easiest way to make sure that sending the patch always works is to use "git send-email" John > On 9 May 2016 at 12:54, Felix Fietkau <nbd@nbd.name> wrote: >> On 2016-05-09 12:50, Graham Fairweather wrote: >>> From: Graham Fairweather <xotic750@gmail.com> >>> >>> This patch fixes the logged detected CPU ID when an equivalent is used, >>> like in the case where we have a bcm6369 and configuration for a >>> bcm6368 is used. >>> So, it will display 'Detected Broadcom 0x6369 CPU revision b2' instead of >>> 'Detected Broadcom 0x6369 CPU revision b2'. More info can be found at: >>> >>> https://forum.openwrt.org/viewtopic.php?id=64621 >>> https://github.com/Xotic750/openwrt/tree/fix_logged_cpu_id_bcm63xx >>> Signed-off-by: Graham Fairweather <xotic750@gmail.com> >> Please stop spamming the list with the same patch over and over again. >> While you're still trying to figure out how to send patches properly, >> please send them to yourself instead of the list. >> >> - Felix > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel >
On 2016-05-09 13:19, Graham Fairweather wrote: > It wasn't my intention to spam the list. I asked for help on the > forum, I asked for help on IRC and I was told to try things. The > documents say if unsuccessful then try again. As a noob, it is not the > easiest process to follow, especially when something doesn't work. How > would sending the mail to myself, which I did by the way, help me > knowing what the problem was? Thanks for your patience and your > advice. If you send the email to yourself instead of the list, you can check if it came out right by trying to apply it. By the way, the easiest way to ensure that your patches are sent correctly is to use git send-email. - Felix
Thanks. I'm looking into that, but currently my system doesn't support 'git send-email' and I'm researching why. My apologies for the noob spam, I still have much to learn and mistakes to make. John has just pointed me toward 'git am', which I also didn't know about. Thank you. On 9 May 2016 at 13:23, Felix Fietkau <nbd@nbd.name> wrote: > On 2016-05-09 13:19, Graham Fairweather wrote: >> It wasn't my intention to spam the list. I asked for help on the >> forum, I asked for help on IRC and I was told to try things. The >> documents say if unsuccessful then try again. As a noob, it is not the >> easiest process to follow, especially when something doesn't work. How >> would sending the mail to myself, which I did by the way, help me >> knowing what the problem was? Thanks for your patience and your >> advice. > If you send the email to yourself instead of the list, you can check if > it came out right by trying to apply it. By the way, the easiest way to > ensure that your patches are sent correctly is to use git send-email. > > - Felix
diff --git a/target/linux/brcm63xx/patches-4.1/330-MIPS-BCM63XX-add-a-new-cpu-variant-helper.patch b/target/linux/brcm63xx/patches-4.1/330-MIPS-BCM63XX-add-a-new-cpu-variant-helper.patch index 661abf6..23491aa 100644 --- a/target/linux/brcm63xx/patches-4.1/330-MIPS-BCM63XX-add-a-new-cpu-variant-helper.patch +++ b/target/linux/brcm63xx/patches-4.1/330-MIPS-BCM63XX-add-a-new-cpu-variant-helper.patch @@ -41,6 +41,15 @@ Subject: [PATCH 40/53] MIPS: BCM63XX: add a new cpu variant helper bcm63xx_cpu_rev = (tmp & REV_REVID_MASK) >> REV_REVID_SHIFT; switch (bcm63xx_cpu_id) { +@@ -377,7 +387,7 @@ void __init bcm63xx_cpu_init(void) + bcm63xx_memory_size = detect_memory_size(); + + printk(KERN_INFO "Detected Broadcom 0x%04x CPU revision %02x\n", +- bcm63xx_cpu_id, bcm63xx_cpu_rev); ++ bcm63xx_cpu_variant, bcm63xx_cpu_rev); + printk(KERN_INFO "CPU frequency is %u MHz\n", + bcm63xx_cpu_freq / 1000000); + printk(KERN_INFO "%uMB of RAM installed\n", --- a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_cpu.h +++ b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_cpu.h @@ -19,6 +19,7 @@ diff --git a/target/linux/brcm63xx/patches-4.4/330-MIPS-BCM63XX-add-a-new-cpu-variant-helper.patch b/target/linux/brcm63xx/patches-4.4/330-MIPS-BCM63XX-add-a-new-cpu-variant-helper.patch index 661abf6..330a9e6 100644 --- a/target/linux/brcm63xx/patches-4.4/330-MIPS-BCM63XX-add-a-new-cpu-variant-helper.patch +++ b/target/linux/brcm63xx/patches-4.4/330-MIPS-BCM63XX-add-a-new-cpu-variant-helper.patch @@ -41,6 +41,15 @@ Subject: [PATCH 40/53] MIPS: BCM63XX: add a new cpu variant helper bcm63xx_cpu_rev = (tmp & REV_REVID_MASK) >> REV_REVID_SHIFT; switch (bcm63xx_cpu_id) { +@@ -377,7 +387,7 @@ void __init bcm63xx_cpu_init(void) + bcm63xx_memory_size = detect_memory_size(); + + pr_info("Detected Broadcom 0x%04x CPU revision %02x\n", +- bcm63xx_cpu_id, bcm63xx_cpu_rev); ++ bcm63xx_cpu_variant, bcm63xx_cpu_rev); + pr_info("CPU frequency is %u MHz\n", + bcm63xx_cpu_freq / 1000000); + pr_info("%uMB of RAM installed\n", --- a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_cpu.h +++ b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_cpu.h