| Message ID | 20230619063618.2595217-6-linus.walleij@linaro.org |
|---|---|
| State | Rejected |
| Delegated to: | Rafał Miłecki |
| Headers | show |
| Series | bcm53xx: Support D-Link DIR-890L | expand |
pon., 19 cze 2023 o 08:39 Linus Walleij <linus.walleij@linaro.org> napisał(a): > This adds the lan/wan default bridge config and also the MAC > NVRAM read-out for et2. > > DIR-885L was missing a default bridge config so I just added > that too while I was at it. Why do you need to handle D-Link devices individually at all? Your code seems to be identical to the default switch case "*)".
On Sun, Aug 20, 2023 at 4:17 PM Rafał Miłecki <zajec5@gmail.com> wrote: > pon., 19 cze 2023 o 08:39 Linus Walleij <linus.walleij@linaro.org> napisał(a): > > This adds the lan/wan default bridge config and also the MAC > > NVRAM read-out for et2. > > > > DIR-885L was missing a default bridge config so I just added > > that too while I was at it. > > Why do you need to handle D-Link devices individually at all? Your > code seems to be identical to the default switch case "*)". Oh right, I don't know what I was thinking. Skip this patch! Yours, Linus Walleij
diff --git a/target/linux/bcm53xx/base-files/etc/board.d/02_network b/target/linux/bcm53xx/base-files/etc/board.d/02_network index 6bec600540ea..ba1cf7ac8d94 100644 --- a/target/linux/bcm53xx/base-files/etc/board.d/02_network +++ b/target/linux/bcm53xx/base-files/etc/board.d/02_network @@ -16,6 +16,10 @@ bcm53xx_setup_interfaces() asus,rt-ac88u) ucidef_set_interfaces_lan_wan "lan1 lan2 lan3 lan4 extsw" "wan" ;; + dlink,dir-885l | \ + dlink,dir-890l) + ucidef_set_interfaces_lan_wan "lan1 lan2 lan3 lan4" "wan" + ;; dlink,dwl-8610ap) ucidef_set_interface_lan "eth0 eth1" "dhcp" ;;
This adds the lan/wan default bridge config and also the MAC NVRAM read-out for et2. DIR-885L was missing a default bridge config so I just added that too while I was at it. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- ChangeLog v2->v3: - Rebased on master ChangeLog v1->v2: - The DIR-890L sets up the Mac address from the NVRAM indicated in the device tree so drop that oneliner. --- target/linux/bcm53xx/base-files/etc/board.d/02_network | 4 ++++ 1 file changed, 4 insertions(+)