| Message ID | 20230619063618.2595217-2-linus.walleij@linaro.org |
|---|---|
| State | Rejected |
| Delegated to: | Rafał Miłecki |
| Headers | show |
| Series | bcm53xx: Support D-Link DIR-890L | expand |
On 19.06.2023 08:36, Linus Walleij wrote: > The v6.1 kernel does not build for me, building with -j1 V=s > reveals that it is prompting for a kernel config option. > I also needed to add CONFIG_MTD_SPLIT_FIRMWARE for splitting > to work. > > This make the v6.1 config work nicely as a baseline for my > DIR-890L patches. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> I've dropped MTD_SPLIT_FIRMWARE for bcm53xx years ago in the commit d3381b5a6401 ("bcm53xx: request Seama parser on DIR-885L directly"). Is is really needed? Can you explain why? What device needs that semi-guess-based splitting of the "firmware" partition? As for CONFIG_ARCH_FORCE_MAX_ORDER it's nice to have kernel refreshed but I was never queried about it while compiling. Are you sure this was the NEW symbol? I had actual problem compiling 6.1 but it was another symbol: IBM Operation Panel driver (INPUT_IBM_PANEL) [N/m/?] (NEW) I've sent a fix for that: [PATCH] kernel: add unset CONFIG_INPUT_IBM_PANEL symbol to config-6.1 https://patchwork.ozlabs.org/project/openwrt/patch/20230826160754.18880-1-zajec5@gmail.com/ > --- > ChangeLog ->v3: > - New patch to make kernel v6.1 work > --- > target/linux/bcm53xx/config-6.1 | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/target/linux/bcm53xx/config-6.1 b/target/linux/bcm53xx/config-6.1 > index d96beb687df0..0ffd90b64d1c 100644 > --- a/target/linux/bcm53xx/config-6.1 > +++ b/target/linux/bcm53xx/config-6.1 > @@ -5,6 +5,7 @@ CONFIG_ARCH_BCM_5301X=y > CONFIG_ARCH_BCM_53573=y > # CONFIG_ARCH_BCM_HR2 is not set > CONFIG_ARCH_BCM_IPROC=y > +CONFIG_ARCH_FORCE_MAX_ORDER=11 > CONFIG_ARCH_HIBERNATION_POSSIBLE=y > CONFIG_ARCH_KEEP_MEMBLOCK=y > CONFIG_ARCH_MIGHT_HAVE_PC_PARPORT=y > @@ -207,6 +208,7 @@ CONFIG_MTD_PARSER_TPLINK_SAFELOADER=y > CONFIG_MTD_PARSER_TRX=y > CONFIG_MTD_RAW_NAND=y > CONFIG_MTD_SPI_NOR=y > +CONFIG_MTD_SPLIT_FIRMWARE=y > CONFIG_MTD_SPLIT_SEAMA_FW=y > CONFIG_MTD_UBI=y > CONFIG_MTD_UBI_BEB_LIMIT=20
On Mon, Aug 28, 2023 at 8:10 AM Rafał Miłecki <zajec5@gmail.com> wrote: > On 19.06.2023 08:36, Linus Walleij wrote: > > The v6.1 kernel does not build for me, building with -j1 V=s > > reveals that it is prompting for a kernel config option. > > I also needed to add CONFIG_MTD_SPLIT_FIRMWARE for splitting > > to work. > > > > This make the v6.1 config work nicely as a baseline for my > > DIR-890L patches. > > > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > > I've dropped MTD_SPLIT_FIRMWARE for bcm53xx years ago in the commit > d3381b5a6401 ("bcm53xx: request Seama parser on DIR-885L directly"). > > Is is really needed? Can you explain why? What device needs that > semi-guess-based splitting of the "firmware" partition? Just skip it for now, it was probably just a mistake during development. I bet it works fine just like this. Thanks for looking into this! Yours, Linus Walleij
diff --git a/target/linux/bcm53xx/config-6.1 b/target/linux/bcm53xx/config-6.1 index d96beb687df0..0ffd90b64d1c 100644 --- a/target/linux/bcm53xx/config-6.1 +++ b/target/linux/bcm53xx/config-6.1 @@ -5,6 +5,7 @@ CONFIG_ARCH_BCM_5301X=y CONFIG_ARCH_BCM_53573=y # CONFIG_ARCH_BCM_HR2 is not set CONFIG_ARCH_BCM_IPROC=y +CONFIG_ARCH_FORCE_MAX_ORDER=11 CONFIG_ARCH_HIBERNATION_POSSIBLE=y CONFIG_ARCH_KEEP_MEMBLOCK=y CONFIG_ARCH_MIGHT_HAVE_PC_PARPORT=y @@ -207,6 +208,7 @@ CONFIG_MTD_PARSER_TPLINK_SAFELOADER=y CONFIG_MTD_PARSER_TRX=y CONFIG_MTD_RAW_NAND=y CONFIG_MTD_SPI_NOR=y +CONFIG_MTD_SPLIT_FIRMWARE=y CONFIG_MTD_SPLIT_SEAMA_FW=y CONFIG_MTD_UBI=y CONFIG_MTD_UBI_BEB_LIMIT=20
The v6.1 kernel does not build for me, building with -j1 V=s reveals that it is prompting for a kernel config option. I also needed to add CONFIG_MTD_SPLIT_FIRMWARE for splitting to work. This make the v6.1 config work nicely as a baseline for my DIR-890L patches. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- ChangeLog ->v3: - New patch to make kernel v6.1 work --- target/linux/bcm53xx/config-6.1 | 2 ++ 1 file changed, 2 insertions(+)